Skip to content

Commit 2f41ec6

Browse files
Replace usages of 'client' and 'cluster' with 'driver' and 'enterprise' throughout (#212)
## What is the goal of this PR? We replace the term 'cluster' with 'enterprise', to reflect the new consistent terminology used through Vaticle. We also replace 'client' with 'driver', where appropriate. ## What are the changes implemented in this PR? * Update REPL, README and code to no longer refer to TypeDB 'Clients', and use the new terminology of TypeDB 'Drivers', and replace usage of TypeDB 'Cluster' with TypeDB 'Enterprise' --------- Co-authored-by: joshua <[email protected]>
1 parent a442d08 commit 2f41ec6

File tree

7 files changed

+192
-192
lines changed

7 files changed

+192
-192
lines changed

BUILD

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,9 @@ java_library(
4242
name = "console",
4343
srcs = glob(["*.java", "*/*.java", "*/*/*.java"], exclude=["bazel-*/*"]) + [":version"],
4444
deps = [
45-
"@vaticle_typedb_client_java//java:client-java",
46-
"@vaticle_typedb_client_java//java/api",
47-
"@vaticle_typedb_client_java//java/common",
45+
"@vaticle_typedb_driver//java:driver-java",
46+
"@vaticle_typedb_driver//java/api",
47+
"@vaticle_typedb_driver//java/common",
4848
"@vaticle_typeql//java:typeql-lang",
4949
"@vaticle_typeql//java/common:common",
5050
"@vaticle_typeql//java/query",
@@ -196,7 +196,7 @@ release_validate_deps(
196196
tagged_deps = [
197197
"@vaticle_typedb_common",
198198
"@vaticle_typeql",
199-
"@vaticle_typedb_client_java",
199+
"@vaticle_typedb_driver",
200200
],
201201
tags = ["manual"] # in order for bazel test //... to not fail
202202
)

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,11 @@ cd <your_typedb_console_dir>/
2020
You can provide several command arguments when running console in the terminal.
2121

2222
- `--server=<address>` : TypeDB server address to which the console will connect to.
23-
- `--cluster=<address>` : TypeDB Cluster server address to which the console will connect to.
24-
- `--username=<username>` : TypeDB Cluster username to connect with.
25-
- `--password` : Interactively enter password to connect to TypeDB Cluster with.
23+
- `--enterprise=<address>` : TypeDB Enterprise server address to which the console will connect to.
24+
- `--username=<username>` : TypeDB Enterprise username to connect with.
25+
- `--password` : Interactively enter password to connect to TypeDB Enterprise with.
2626
- `--script=<script>` : Run commands in the script file in non-interactive mode.
27-
- `--tls-enabled`: Enable TLS for connecting to TypeDB Cluster.
27+
- `--tls-enabled`: Enable TLS for connecting to TypeDB Enterprise.
2828
- `--tls-root-ca`: Path to root CA certificate for TLS encryption.
2929
- `--command=<command1> --command=<command2> ...` : Run commands in non-interactive mode.
3030
- `-V, --version` : Print version information and exit.

TypeDBConsole.java

Lines changed: 131 additions & 131 deletions
Large diffs are not rendered by default.

WORKSPACE

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -145,11 +145,11 @@ pip_deps()
145145
################################
146146

147147
# Load repositories
148-
load("//dependencies/vaticle:repositories.bzl", "vaticle_typedb_common", "vaticle_typedb_client_java")
148+
load("//dependencies/vaticle:repositories.bzl", "vaticle_typedb_common", "vaticle_typedb_driver")
149149
vaticle_typedb_common()
150-
vaticle_typedb_client_java()
150+
vaticle_typedb_driver()
151151

152-
load("@vaticle_typedb_client_java//dependencies/vaticle:repositories.bzl", "vaticle_typedb_protocol", "vaticle_typeql")
152+
load("@vaticle_typedb_driver//dependencies/vaticle:repositories.bzl", "vaticle_typedb_protocol", "vaticle_typeql")
153153
vaticle_typeql()
154154
vaticle_typedb_protocol()
155155

@@ -160,7 +160,7 @@ vaticle_typedb_artifact()
160160
# Load maven
161161
load("@vaticle_typedb_common//dependencies/maven:artifacts.bzl", vaticle_typedb_common_artifacts = "artifacts")
162162
load("@vaticle_typeql//dependencies/maven:artifacts.bzl", vaticle_typeql_artifacts = "artifacts")
163-
load("@vaticle_typedb_client_java//dependencies/maven:artifacts.bzl", vaticle_typedb_client_java_artifacts = "artifacts")
163+
load("@vaticle_typedb_driver//dependencies/maven:artifacts.bzl", vaticle_typedb_driver_artifacts = "artifacts")
164164
load("@vaticle_typedb_console//dependencies/maven:artifacts.bzl", vaticle_typedb_console_artifacts = "artifacts")
165165

166166
###############
@@ -171,7 +171,7 @@ load("@vaticle_dependencies//library/maven:rules.bzl", "maven")
171171
maven(
172172
vaticle_typedb_common_artifacts +
173173
vaticle_typeql_artifacts +
174-
vaticle_typedb_client_java_artifacts +
174+
vaticle_typedb_driver_artifacts +
175175
vaticle_typedb_console_artifacts +
176176
vaticle_dependencies_tool_maven_artifacts +
177177
io_grpc_artifacts,

command/REPLCommand.java

Lines changed: 30 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,10 @@
1717

1818
package com.vaticle.typedb.console.command;
1919

20-
import com.vaticle.typedb.client.api.TypeDBClient;
21-
import com.vaticle.typedb.client.api.TypeDBOptions;
22-
import com.vaticle.typedb.client.api.TypeDBSession;
23-
import com.vaticle.typedb.client.api.TypeDBTransaction;
20+
import com.vaticle.typedb.driver.api.TypeDBDriver;
21+
import com.vaticle.typedb.driver.api.TypeDBOptions;
22+
import com.vaticle.typedb.driver.api.TypeDBSession;
23+
import com.vaticle.typedb.driver.api.TypeDBTransaction;
2424
import com.vaticle.typedb.common.collection.Pair;
2525
import com.vaticle.typedb.console.common.Printer;
2626
import com.vaticle.typedb.console.common.Utils;
@@ -532,17 +532,17 @@ class Options {
532532

533533
public static String token = "transaction-options";
534534

535-
static TypeDBOptions from(String[] optionTokens, boolean isCluster) {
536-
if (isCluster) return parseClusterOptions(optionTokens, new TypeDBOptions());
535+
static TypeDBOptions from(String[] optionTokens, boolean isEnterprise) {
536+
if (isEnterprise) return parseEnterpriseOptions(optionTokens, new TypeDBOptions());
537537
else return parseCoreOptions(optionTokens, new TypeDBOptions());
538538
}
539539

540-
private static TypeDBOptions parseClusterOptions(String[] optionTokens, TypeDBOptions options) {
540+
private static TypeDBOptions parseEnterpriseOptions(String[] optionTokens, TypeDBOptions options) {
541541
for (int i = 0; i < optionTokens.length; i += 2) {
542542
String token = optionTokens[i];
543543
String arg = optionTokens[i + 1];
544544
assert token.charAt(0) == '-' && token.charAt(1) == '-';
545-
Option<TypeDBOptions> option = Options.Cluster.clusterOption(token.substring(2));
545+
Option<TypeDBOptions> option = Options.Enterprise.enterpriseOption(token.substring(2));
546546
try {
547547
options = option.build(options, arg);
548548
} catch (IllegalArgumentException e) {
@@ -606,20 +606,20 @@ static List<Pair<String, String>> helpMenu(List<? extends Option<? extends TypeD
606606
}
607607
}
608608

609-
static class Cluster extends Core {
609+
static class Enterprise extends Core {
610610

611-
private static List<Option.Cluster> options = withCoreOptions(
612-
Option.cluster("read-any-replica", Option.Arg.BOOLEAN, "Allow (possibly stale) reads from any replica", (opt, arg) -> opt.readAnyReplica((Boolean) arg))
611+
private static List<Option.Enterprise> options = withCoreOptions(
612+
Option.enterprise("read-any-replica", Option.Arg.BOOLEAN, "Allow (possibly stale) reads from any replica", (opt, arg) -> opt.readAnyReplica((Boolean) arg))
613613
);
614614

615-
private static List<Option.Cluster> withCoreOptions(Option.Cluster... clusterOptions) {
616-
List<Option.Cluster> extendedOptions = new ArrayList<>();
617-
Core.options.forEach(opt -> extendedOptions.add(opt.asClusterOption()));
618-
extendedOptions.addAll(Arrays.asList(clusterOptions));
615+
private static List<Option.Enterprise> withCoreOptions(Option.Enterprise... enterpriseOptions) {
616+
List<Option.Enterprise> extendedOptions = new ArrayList<>();
617+
Core.options.forEach(opt -> extendedOptions.add(opt.asEnterpriseOption()));
618+
extendedOptions.addAll(Arrays.asList(enterpriseOptions));
619619
return extendedOptions;
620620
}
621621

622-
public static Option<TypeDBOptions> clusterOption(String token) throws IllegalArgumentException {
622+
public static Option<TypeDBOptions> enterpriseOption(String token) throws IllegalArgumentException {
623623
return from(token, options);
624624
}
625625

@@ -646,8 +646,8 @@ static Option.Core core(String name, Arg arg, String description, BiFunction<Typ
646646
return new Option.Core(name, arg, description, builder);
647647
}
648648

649-
static Option.Cluster cluster(String name, Arg arg, String description, BiFunction<TypeDBOptions, Object, TypeDBOptions> builder) {
650-
return new Option.Cluster(name, arg, description, builder);
649+
static Option.Enterprise enterprise(String name, Arg arg, String description, BiFunction<TypeDBOptions, Object, TypeDBOptions> builder) {
650+
return new Option.Enterprise(name, arg, description, builder);
651651
}
652652

653653
OPTIONS build(OPTIONS options, String arg) {
@@ -666,14 +666,14 @@ private Core(String name, Arg arg, String description, BiFunction<TypeDBOptions,
666666
super(name, arg, description, builder);
667667
}
668668

669-
Option.Cluster asClusterOption() {
670-
return new Option.Cluster(name, arg, description, (clusterOption, arg) -> builder.apply(clusterOption, arg));
669+
Option.Enterprise asEnterpriseOption() {
670+
return new Option.Enterprise(name, arg, description, (enterpriseOption, arg) -> builder.apply(enterpriseOption, arg));
671671
}
672672
}
673673

674-
static class Cluster extends Option<TypeDBOptions> {
674+
static class Enterprise extends Option<TypeDBOptions> {
675675

676-
private Cluster(String name, Arg arg, String description, BiFunction<TypeDBOptions, Object, TypeDBOptions> builder) {
676+
private Enterprise(String name, Arg arg, String description, BiFunction<TypeDBOptions, Object, TypeDBOptions> builder) {
677677
super(name, arg, description, builder);
678678
}
679679
}
@@ -700,9 +700,9 @@ Object parse(String arg) throws IllegalArgumentException {
700700
}
701701
}
702702

703-
static String createHelpMenu(TypeDBClient client, boolean isCluster) {
703+
static String createHelpMenu(TypeDBDriver driver, boolean isEnterprise) {
704704
List<Pair<String, String>> menu = new ArrayList<>();
705-
if (client.users() != null) {
705+
if (driver.users() != null) {
706706
menu.addAll(Arrays.asList(
707707
pair(User.List.helpCommand, User.List.description),
708708
pair(User.Create.helpCommand, User.Create.description),
@@ -717,12 +717,12 @@ static String createHelpMenu(TypeDBClient client, boolean isCluster) {
717717
pair(Database.Delete.helpCommand, Database.Delete.description),
718718
pair(Database.Schema.helpCommand, Database.Schema.description)));
719719

720-
if (isCluster) {
720+
if (isEnterprise) {
721721
menu.add(pair(Database.Replicas.helpCommand, Database.Replicas.description));
722722
}
723723

724724
menu.add(pair(Transaction.helpCommand, Transaction.description));
725-
if (isCluster) menu.addAll(Options.Cluster.helpMenu());
725+
if (isEnterprise) menu.addAll(Options.Enterprise.helpMenu());
726726
else menu.addAll(Options.Core.helpMenu());
727727

728728
menu.addAll(Arrays.asList(
@@ -733,11 +733,11 @@ static String createHelpMenu(TypeDBClient client, boolean isCluster) {
733733
return Utils.createHelpMenu(menu);
734734
}
735735

736-
static REPLCommand readREPLCommand(LineReader reader, Printer printer, String prompt, boolean isCluster) throws InterruptedException {
736+
static REPLCommand readREPLCommand(LineReader reader, Printer printer, String prompt, boolean isEnterprise) throws InterruptedException {
737737
REPLCommand command = null;
738738
while (command == null) {
739739
String line = Utils.readNonEmptyLine(reader, prompt);
740-
command = readREPLCommand(line, reader, isCluster);
740+
command = readREPLCommand(line, reader, isEnterprise);
741741
if (command == null) {
742742
printer.error("Unrecognised command, please check help menu");
743743
}
@@ -746,7 +746,7 @@ static REPLCommand readREPLCommand(LineReader reader, Printer printer, String pr
746746
return command;
747747
}
748748

749-
static REPLCommand readREPLCommand(String line, @Nullable LineReader passwordReader, boolean isCluster) {
749+
static REPLCommand readREPLCommand(String line, @Nullable LineReader passwordReader, boolean isEnterprise) {
750750
REPLCommand command = null;
751751
String[] tokens = Utils.splitLineByWhitespace(line);
752752
if (tokens.length == 1 && tokens[0].equals(Exit.token)) {
@@ -795,7 +795,7 @@ static REPLCommand readREPLCommand(String line, @Nullable LineReader passwordRea
795795
TypeDBSession.Type sessionType = tokens[2].equals("schema") ? TypeDBSession.Type.SCHEMA : TypeDBSession.Type.DATA;
796796
TypeDBTransaction.Type transactionType = tokens[3].equals("read") ? TypeDBTransaction.Type.READ : TypeDBTransaction.Type.WRITE;
797797
TypeDBOptions options;
798-
if (tokens.length > 4) options = Options.from(Arrays.copyOfRange(tokens, 4, tokens.length), isCluster);
798+
if (tokens.length > 4) options = Options.from(Arrays.copyOfRange(tokens, 4, tokens.length), isEnterprise);
799799
else options = new TypeDBOptions();
800800
command = new Transaction(database, sessionType, transactionType, options);
801801
}

common/Printer.java

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -17,19 +17,19 @@
1717

1818
package com.vaticle.typedb.console.common;
1919

20-
import com.vaticle.typedb.client.api.TypeDBTransaction;
21-
import com.vaticle.typedb.client.api.answer.ConceptMap;
22-
import com.vaticle.typedb.client.api.answer.ConceptMapGroup;
23-
import com.vaticle.typedb.client.api.answer.Numeric;
24-
import com.vaticle.typedb.client.api.answer.NumericGroup;
25-
import com.vaticle.typedb.client.api.concept.Concept;
26-
import com.vaticle.typedb.client.api.concept.thing.Attribute;
27-
import com.vaticle.typedb.client.api.concept.thing.Relation;
28-
import com.vaticle.typedb.client.api.concept.thing.Thing;
29-
import com.vaticle.typedb.client.api.concept.type.RoleType;
30-
import com.vaticle.typedb.client.api.concept.type.Type;
31-
import com.vaticle.typedb.client.api.concept.value.Value;
32-
import com.vaticle.typedb.client.api.database.Database;
20+
import com.vaticle.typedb.driver.api.TypeDBTransaction;
21+
import com.vaticle.typedb.driver.api.answer.ConceptMap;
22+
import com.vaticle.typedb.driver.api.answer.ConceptMapGroup;
23+
import com.vaticle.typedb.driver.api.answer.Numeric;
24+
import com.vaticle.typedb.driver.api.answer.NumericGroup;
25+
import com.vaticle.typedb.driver.api.concept.Concept;
26+
import com.vaticle.typedb.driver.api.concept.thing.Attribute;
27+
import com.vaticle.typedb.driver.api.concept.thing.Relation;
28+
import com.vaticle.typedb.driver.api.concept.thing.Thing;
29+
import com.vaticle.typedb.driver.api.concept.type.RoleType;
30+
import com.vaticle.typedb.driver.api.concept.type.Type;
31+
import com.vaticle.typedb.driver.api.concept.value.Value;
32+
import com.vaticle.typedb.driver.api.database.Database;
3333
import com.vaticle.typedb.console.common.exception.TypeDBConsoleException;
3434
import com.vaticle.typeql.lang.common.TypeQLToken;
3535
import org.jline.utils.AttributedString;

dependencies/vaticle/repositories.bzl

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,12 @@ def vaticle_typedb_common():
2828
git_repository(
2929
name = "vaticle_typedb_common",
3030
remote = "https://github.com/vaticle/typedb-common",
31-
commit = "40f8ab74b34447b59517ce3f027c8700a8aa057a", # sync-marker: do not remove this comment, this is used for sync-dependencies by @vaticle_typedb_common
31+
tag = "2.24.1", # sync-marker: do not remove this comment, this is used for sync-dependencies by @vaticle_typedb_common
3232
)
3333

34-
def vaticle_typedb_client_java():
34+
def vaticle_typedb_driver():
3535
git_repository(
36-
name = "vaticle_typedb_client_java",
37-
remote = "https://github.com/vaticle/typedb-driver-java",
38-
commit = "c9f39aa628ac5eb9d20e46018bf97685587d936a", # sync-marker: do not remove this comment, this is used for sync-dependencies by @vaticle_typedb_client_java
36+
name = "vaticle_typedb_driver",
37+
remote = "https://github.com/vaticle/typedb-driver",
38+
commit = "8c410a4a1332875b79333457ff63d5cf80861989", # sync-marker: do not remove this comment, this is used for sync-dependencies by @vaticle_typedb_driver
3939
)

0 commit comments

Comments
 (0)