Mandate password prompt for user creation (#195)

## What is the goal of this PR?

We now force passwords to be entered in a password prompt. This prevents
passwords from showing up in the command history.

## What are the changes implemented in this PR?

We've changed the flow of the user create command. Now, when creating a
user, you supply a username and are then prompted to supply a password
separately.

Author: James Williams

TypeDBConsole.java

@@ -36,6 +36,7 @@
 import com.vaticle.typedb.console.command.REPLCommand;
 import com.vaticle.typedb.console.command.TransactionREPLCommand;
 import com.vaticle.typedb.console.common.Printer;
+import com.vaticle.typedb.console.common.Utils;
 import com.vaticle.typedb.console.common.exception.TypeDBConsoleException;
 import com.vaticle.typeql.lang.TypeQL;
 import com.vaticle.typeql.lang.common.TypeQLArg;
@@ -771,7 +772,7 @@ private static class CLIOptions implements Runnable {
         @CommandLine.Option(
                 names = {"--password"},
                 description = "Password",
-                prompt = "Enter password:",
+                prompt = "Password: ",
                 interactive = true,
                 arity = "0..1"
         )

command/REPLCommand.java

@@ -341,8 +341,8 @@ public User.List asUserList() {
         public static class Create extends REPLCommand.User {
 
             public static String token = "create";
-            private static String helpCommand = User.token + " " + token + " " + "<username> <password>";
-            private static String description = "Create a user with name <username> and password <password> on the server";
+            private static String helpCommand = User.token + " " + token + " " + "<username>";
+            private static String description = "Create a user with name <username> and a supplied password on the server";
 
             private final String user;
             private final String password;
@@ -673,15 +673,10 @@ static REPLCommand readREPLCommand(String line, @Nullable LineReader passwordRea
         }
         else if (tokens.length == 2 && tokens[0].equals(User.token) && tokens[1].equals(User.List.token)) {
             command = new User.List();
-        } else if ((tokens.length == 3 || tokens.length == 4) && tokens[0].equals(User.token) && tokens[1].equals(User.Create.token)) {
+        } else if (tokens.length == 3 && tokens[0].equals(User.token) && tokens[1].equals(User.Create.token)) {
             String name = tokens[2];
-            String password;
-            if (tokens.length == 3) {
-                if (passwordReader == null) throw new TypeDBConsoleException(UNABLE_TO_READ_PASSWORD_INTERACTIVELY);
-                password = Utils.readPassword(passwordReader, "Enter password:");
-            } else {
-                password = tokens[3];
-            }
+            if (passwordReader == null) throw new TypeDBConsoleException(UNABLE_TO_READ_PASSWORD_INTERACTIVELY);
+            String password = Utils.readPassword(passwordReader, "Password: ");
             command = new User.Create(name, password);
         } else if (tokens.length == 3 && tokens[0].equals(User.token) && tokens[1].equals(User.Delete.token)) {
             String name = tokens[2];

common/Utils.java

@@ -73,7 +73,7 @@ public static String readNonEmptyLine(LineReader reader, String prompt) throws I
     }
 
     public static String readPassword(LineReader passwordReader, String prompt) {
-        return passwordReader.readLine(prompt, (char) 0);
+        return passwordReader.readLine(prompt, '*');
     }
 
     public static String getContinuationPrompt(String prompt) {