Merge for 2.28.4 release (#253)

## Usage and product changes
Merge for 2.28.4 release

Author: typedb-bot

RELEASE_NOTES_LATEST.md

@@ -1,20 +1,20 @@
 ## Distribution
 
-Download from TypeDB Package Repository: https://cloudsmith.io/~typedb/repos/public-release/packages/?q=name:^typedb-console+version:2.28.2-rc1
+Download from TypeDB Package Repository: https://cloudsmith.io/~typedb/repos/public-release/packages/?q=name:^typedb-console+version:2.28.4
 
 
 ## New Features
 
-
 ## Bugs Fixed
-
+- **Remove hard-coded value for transaction timeout**
+  Removes a hard-coded value for transaction timeout, which prevented the user's setting from taking effect.
 
 ## Code Refactors
 
-
 ## Other Improvements
+- **Bump dependencies for rules-python & pin CircleCI windows executor**
+  Bump dependencies for rules-python update. This fixes an error on windows builds in CircleCI.
+  We also pin the image used for Windows builds  on CircleCI to prevent updates from breaking the pipeline.
+
 - **Turn off statistics reporting in CI**
-  We turn off the `--diagnostics.reporting.statistics` in our CI builds not to send non-real diagnostics data.
-  
-  In version 2.28 and earlier, this flag purely prevents `TypeDB` from sending any diagnostics data.
-  In the upcoming version 2.28.1, this flag still allows `TypeDB` to send a single diagnostics snapshot with the information of when the diagnostics data has been turned off, but it happens only after the server runs for 1 hour, so we expect the CI builds not to reach this point and not to send any diagnostics data as well.
+  We turn off the statistics reporting in our CI builds not to send non-real diagnostics data.

TypeDBConsole.java

@@ -101,7 +101,6 @@ public class TypeDBConsole {
     private static final Logger LOG = LoggerFactory.getLogger(TypeDBConsole.class);
 
     private static final Duration PASSWORD_EXPIRY_WARN = Duration.ofDays(7);
-    private static final int ONE_HOUR_IN_MILLIS = 60 * 60 * 1000;
 
     private final Printer printer;
     private ExecutorService executorService;
@@ -338,7 +337,6 @@ private boolean transactionREPL(TypeDBDriver driver, boolean isCloud, String dat
         if (isCloud && options.readAnyReplica().isPresent() && options.readAnyReplica().get()) {
             promptBuilder.append("[any-replica]");
         }
-        options.transactionTimeoutMillis(ONE_HOUR_IN_MILLIS);
         try (TypeDBSession session = driver.session(database, sessionType, options);
              TypeDBTransaction tx = session.transaction(transactionType, options)) {
             hasUncommittedChanges = false;

VERSION

@@ -1 +1 @@
-2.28.2-rc1
+2.28.4

dependencies/maven/artifacts.snapshot

@@ -28,8 +28,9 @@
 @maven//:com_googlecode_java_diff_utils_diffutils_1_3_0
 @maven//:com_squareup_okhttp_okhttp_2_7_5
 @maven//:com_squareup_okio_okio_1_17_5
-@maven//:com_vaticle_typedb_typedb_cloud_runner_2_28_0
-@maven//:com_vaticle_typedb_typedb_runner_2_28_0
+@maven//:com_vaticle_typedb_typedb_cloud_runner_2_28_3
+@maven//:com_vaticle_typedb_typedb_common_2_28_1
+@maven//:com_vaticle_typedb_typedb_runner_2_28_3
 @maven//:com_vdurmont_semver4j_3_1_0
 @maven//:commons_codec_commons_codec_1_13
 @maven//:commons_io_commons_io_2_3

dependencies/vaticle/repositories.bzl

@@ -8,12 +8,12 @@ def vaticle_dependencies():
     git_repository(
         name = "vaticle_dependencies",
         remote = "https://github.com/vaticle/dependencies",
-        commit = "729d960a92e145e03794395bbe59e02f122f1aee", # sync-marker: do not remove this comment, this is used for sync-dependencies by @vaticle_dependencies
+        commit = "294ef724c3853c9851e1e0c6bc04e0470c724e10", # sync-marker: do not remove this comment, this is used for sync-dependencies by @vaticle_dependencies
     )
 
 def vaticle_typedb_driver():
     git_repository(
         name = "vaticle_typedb_driver",
         remote = "https://github.com/vaticle/typedb-driver",
-        tag = "2.28.2-rc1",  # sync-marker: do not remove this comment, this is used for sync-dependencies by @vaticle_typedb_driver
+        tag = "2.28.4",  # sync-marker: do not remove this comment, this is used for sync-dependencies by @vaticle_typedb_driver
     )

test/assembly/AssemblyTest.java

@@ -22,11 +22,7 @@ public class AssemblyTest {
     @Test
     public void test_console_command() throws IOException, InterruptedException, TimeoutException {
         TypeDBConsoleRunner consoleRunner = new TypeDBConsoleRunner();
-        Map<String, String> coreOptions = new HashMap<>();
-        coreOptions.put("--diagnostics.reporting.errors", "false");
-        coreOptions.put("--diagnostics.reporting.statistics", "false");
-        coreOptions.put("--diagnostics.monitoring.enable", "false");
-        TypeDBCoreRunner coreRunner = new TypeDBCoreRunner(coreOptions);
+        TypeDBCoreRunner coreRunner = new TypeDBCoreRunner();
         try {
             coreRunner.start();
             int status = consoleRunner.run("--core", coreRunner.address(), "--command", "database create assembly-test-db");