Adjust cargo IDE sync tool to depend on external dependencies via git (#560)

## What is the goal of this PR?

As part of the initiative to streamline the Rust developer experience,
we aim to commit autogenerated cargo manifests. For them to be usable
without Bazel, we add the ability to depend on internal git repositories
rather than pointing the dependency via path into the generated cargo
workspace.

## What are the changes implemented in this PR?

We also merge crates at the same path that have the same name under the
assumption that they represent alternative modes of compilation for the
same target (i.e., enable different features).

Author: dmitrii-ubskii

WORKSPACE

@@ -103,7 +103,7 @@ load("@crates//:defs.bzl", "crate_repositories")
 crate_repositories()
 
 ###############################################
-# Create @typedb_dependencies_workspace_refs #
+# Create @typedb_dependencies_workspace_refs  #
 ###############################################
 
 load("@typedb_bazel_distribution//common:rules.bzl", "workspace_refs")

builder/rust/cargo/project_aspect.bzl

@@ -21,6 +21,7 @@ _LIB_ENTRY_POINT = "lib.rs"
 CrateInfo = provider(fields = [
     "kind",            # str
     "crate_name",      # str
+    "workspace_name",  # str
     "crate_path",      # str
     "version",         # str
     "features",        # List[str]
@@ -81,13 +82,15 @@ def _crate_info(ctx, target):
             if tag.startswith("crate-name"):
                 crate_name = tag.split("=")[1]
 
+    workspace_name = target.label.workspace_name
     crate_path = target.label.package
     deps = _crate_deps(ctx, target)
     transitive_deps = _transitive_crate_deps(deps)
 
     return CrateInfo(
         kind = ctx.rule.kind,
         crate_name = crate_name,
+        workspace_name = workspace_name,
         crate_path = crate_path,
         version = getattr(ctx.rule.attr, "version", "0.0.0"),
         features = getattr(ctx.rule.attr, "crate_features", []),
@@ -196,6 +199,7 @@ def _get_properties(target, ctx, source_files, crate_info):
     properties = {}
     properties["name"] = crate_info.crate_name
     properties["path"] = crate_info.crate_path
+    properties["features"] = ",".join(crate_info.features)
     properties["target.name"] = target.label.name
     properties["type"] = target_type
     properties["version"] = crate_info.version
@@ -220,7 +224,7 @@ def _crate_deps_info(target, crate_info):
         if _is_universe_crate(dependency):
             location = "version={}".format(dependency_info.version)
         elif not _is_external_target(target) and _is_external_target(dependency):
-            location = "path=../{}".format(dependency_info.crate_name)
+            location = "path=../{};workspace_name={}".format(dependency_info.crate_name, dependency_info.workspace_name)
         else:
             target_to_root = _package_relative_path_to_root(target.label)
             root_to_dep = _package_path_from_root(dependency.label)

tool/ide/BUILD

@@ -25,6 +25,7 @@ kt_jvm_library(
         "@typedb_bazel_distribution//common/shell",
         "@typedb_bazel_distribution//common/util",
 
+        "@maven//:com_eclipsesource_minimal_json_minimal_json",
         "@maven//:com_electronwill_night_config_core",
         "@maven//:com_electronwill_night_config_toml",
         "@maven//:info_picocli_picocli",

tool/ide/RustManifestSyncer.kt

@@ -8,7 +8,6 @@ load("@typedb_dependencies//tool/checkstyle:rules.bzl", "checkstyle_test")
 rust_library(
     name = "test-lib",
     srcs = ["lib.rs"],
-    deps = ["@typedb_extern//:a"],
 )
 
 checkstyle_test(

tool/ide/test/BUILD

@@ -54,7 +54,15 @@ load("@typedb_dependencies//tool/common:deps.bzl", typedb_dependencies_tool_mave
 load("@typedb_dependencies//library/maven:rules.bzl", "maven")
 maven(typedb_dependencies_tool_maven_artifacts)
 
-local_repository(
-    name = "typedb_extern", # we filter external crates by `@typedb_`!
-    path = "extern",
-)
+###############################
+# Create @test_workspace_refs #
+###############################
+
+# Load //@typedb_bazel_distribution//common
+load("@typedb_bazel_distribution//common:deps.bzl", "rules_pkg")
+rules_pkg()
+load("@rules_pkg//:deps.bzl", "rules_pkg_dependencies")
+rules_pkg_dependencies()
+
+load("@typedb_bazel_distribution//common:rules.bzl", "workspace_refs")
+workspace_refs(name = "test_workspace_refs")

tool/ide/test/WORKSPACE

@@ -9,7 +9,6 @@ load("@typedb_dependencies//tool/checkstyle:rules.bzl", "checkstyle_test")
 rust_library(
     name = "lib1",
     srcs = ["lib.rs"],
-    deps = ["@typedb_extern//:a", "//lib2:lib2"],
 )
 
 rust_test(

tool/ide/test/lib1/BUILD

@@ -9,7 +9,6 @@ load("@typedb_dependencies//tool/checkstyle:rules.bzl", "checkstyle_test")
 rust_test(
     name = "lib2_integration_test",
     srcs = ["test.rs"],
-    deps = ["//lib2:lib2", "@typedb_extern//:b"],
 )
 
 checkstyle_test(

tool/ide/test/lib2/tests/BUILD

@@ -3,5 +3,4 @@
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at https://mozilla.org/MPL/2.0/.
 
-
-bazel run @typedb_dependencies//tool/ide:rust_sync
+bazel run @typedb_dependencies//tool/ide:rust_sync -- @test_workspace_refs//:refs.json