Invert address translation table: map public addresses to private (#676)

## Usage and product changes

NOTE: The address translation table now represents mapping _from_ the
desired connection addresses to the addresses the cloud servers are
configured with. This change does not impact users of TypeDB Core or
TypeDB Cloud through the TypeDB Cloud Platform
(https://cloud.typedb.com/)

---------

Co-authored-by: Haikal Pribadi <[email protected]>

Author: dmitrii-ubskii

.factory/automation.yml

@@ -26,7 +26,7 @@ config:
 build:
   quality:
     filter:
-      owner: vaticle
+      owner: typedb
       branch: [master, development]
     dependency-analysis:
       image: vaticle-ubuntu-22.04
@@ -125,7 +125,7 @@ build:
       machine: 8-core-32-gb
       image: vaticle-ubuntu-20.04 # Ubuntu 20.04 has GLIBC version 2.31 (2020) which we should verify to compile against
       filter:
-        owner: vaticle
+        owner: typedb
         branch: [master, development]
       dependencies:
         - build
@@ -149,7 +149,7 @@ build:
       machine: 8-core-32-gb
       image: vaticle-ubuntu-20.04 # Ubuntu 20.04 has GLIBC version 2.31 (2020) which we should verify to compile against
       filter:
-        owner: vaticle
+        owner: typedb
         branch: [master, development]
       dependencies:
         - build
@@ -509,7 +509,7 @@ build:
     sync-dependencies:
       image: vaticle-ubuntu-22.04
       filter:
-        owner: vaticle
+        owner: typedb
         branch: [master, development]
       dependencies:
         - build
@@ -546,7 +546,7 @@ build:
 
 release:
   filter:
-    owner: vaticle
+    owner: typedb
     branch: [master]
   validation:
     validate-dependencies:

c/src/concept/concept.rs

@@ -19,7 +19,7 @@
 
 use std::ffi::c_char;
 
-use chrono::NaiveDateTime;
+use chrono::DateTime;
 use typedb_driver::{
     concept::{
         Annotation, Attribute, AttributeType, Concept, Entity, EntityType, Relation, RelationType, RoleType, Value,
@@ -56,7 +56,7 @@ pub extern "C" fn value_new_string(string: *const c_char) -> *mut Concept {
 /// Creates a new ``Value`` object of the specified datetime value.
 #[no_mangle]
 pub extern "C" fn value_new_date_time_from_millis(millis: i64) -> *mut Concept {
-    release(Concept::Value(Value::DateTime(NaiveDateTime::from_timestamp_millis(millis).unwrap())))
+    release(Concept::Value(Value::DateTime(DateTime::from_timestamp_millis(millis).unwrap().naive_utc())))
 }
 
 /// Returns <code>true</code> if the value which this ``Value`` concept holds is of type <code>boolean</code>.
@@ -143,7 +143,7 @@ pub extern "C" fn value_get_string(value: *const Concept) -> *mut c_char {
 #[no_mangle]
 pub extern "C" fn value_get_date_time_as_millis(value: *const Concept) -> i64 {
     if let Value::DateTime(date_time) = borrow_as_value(value) {
-        date_time.timestamp_millis()
+        date_time.and_utc().timestamp_millis()
     } else {
         unreachable!("Attempting to unwrap a non-datetime {:?} as datetime", borrow_as_value(value))
     }

c/src/connection.rs

@@ -52,18 +52,18 @@ pub extern "C" fn connection_open_cloud(
 /// Open a TypeDB Driver to TypeDB Cloud server(s), using provided address translation, with
 /// the provided credential.
 ///
-/// @param advertised_addresses A null-terminated array holding the address(es) the TypeDB server(s)
-/// are configured to advertise
-/// @param translated_addresses A null-terminated array holding the address(es) of the TypeDB server(s)
+/// @param public_addresses A null-terminated array holding the address(es) of the TypeDB server(s)
 /// the driver will connect to. This array <i>must</i> have the same length as <code>advertised_addresses</code>
+/// @param private_addresses A null-terminated array holding the address(es) the TypeDB server(s)
+/// are configured to advertise
 /// @param credential The <code>Credential</code> to connect with
 #[no_mangle]
 pub extern "C" fn connection_open_cloud_translated(
-    advertised_addresses: *const *const c_char,
-    translated_addresses: *const *const c_char,
+    public_addresses: *const *const c_char,
+    private_addresses: *const *const c_char,
     credential: *const Credential,
 ) -> *mut Connection {
-    let addresses = string_array_view(advertised_addresses).zip_eq(string_array_view(translated_addresses)).collect();
+    let addresses = string_array_view(public_addresses).zip_eq(string_array_view(private_addresses)).collect();
     try_release(Connection::new_cloud_with_translation(addresses, borrow(credential).clone()))
 }
 

cpp/include/typedb/connection/driver.hpp

@@ -85,8 +85,8 @@ class Driver {
      * Driver::cloudDriver(addresses, credential);
      * </pre>
      *
-     * @param addresses The address(es) of the TypeDB server(s) or translation map from addresses
-     * received from the TypeDB server(s) to addresses to be used by the driver for connection
+     * @param addresses The address(es) of the TypeDB server(s) or translation map from addresses to be used
+     * by the driver for connection to addresses received from the TypeDB server(s) 
      * @param credential The Credential to connect with
      */
     static Driver cloudDriver(const std::vector<std::string>& addresses, const Credential& credential);

cpp/lib/connection/driver.cpp

@@ -47,17 +47,17 @@ Driver Driver::cloudDriver(const std::vector<std::string>& addresses, const Cred
 }
 
 Driver Driver::cloudDriver(const std::unordered_map<std::string, std::string>& addressTranslation, const Credential& credential) {
-    std::vector<const char*> advertisedAddressesNative;
-    std::vector<const char*> translatedAddressesNative;
-    for (auto& [advertised, translated] : addressTranslation) {
-        advertisedAddressesNative.push_back(advertised.c_str());
-        translatedAddressesNative.push_back(translated.c_str());
+    std::vector<const char*> publicAddressesNative;
+    std::vector<const char*> privateAddressesNative;
+    for (auto& [publicAddress, privateAddress] : addressTranslation) {
+        publicAddressesNative.push_back(publicAddress.c_str());
+        privateAddressesNative.push_back(privateAddress.c_str());
     }
-    advertisedAddressesNative.push_back(nullptr);
-    translatedAddressesNative.push_back(nullptr);
+    publicAddressesNative.push_back(nullptr);
+    privateAddressesNative.push_back(nullptr);
     auto p = _native::connection_open_cloud_translated(
-        advertisedAddressesNative.data(),
-        translatedAddressesNative.data(),
+        publicAddressesNative.data(),
+        privateAddressesNative.data(),
         credential.getNative()
     );
     DriverException::check_and_throw();

cpp/test/behaviour/steps/main.cpp

@@ -56,5 +56,4 @@ int main(int argc, char** argv) {
         &TypeDB::BDD::testHooks);
     driver.loadFeature(argv[1]);
     return driver.runAllTests();
-    return 0;
 }

cpp/test/cucumber/include/cucumber_bdd/runner.hpp

@@ -71,6 +71,7 @@ class TestRunner : public TestRunnerBase {
     void afterAllTests() override {
         if (hooks != nullptr) hooks->afterAll();
     }
+
     bool skipScenario(const cucumber::messages::pickle& scenario) override {
         return (hooks != nullptr) ? hooks->skipScenario(scenario) : false;
     }

cpp/test/cucumber/lib/runner.cpp

@@ -51,7 +51,7 @@ void TestRunnerBase::loadFeature(const std::string& path) {
 
     if (doc.feature.has_value()) {
         for (cucumber::messages::pickle scenario : compiler.compile(doc, path)) {
-            if (skipScenario(scenario)) {
+            if (skipScenario(scenario) || scenario.steps.empty()) {
                 DEBUGONLY(std::cout << "Skipping scenario: " << scenario.name << std::endl)
             } else {
                 DEBUGONLY(std::cout << "Registering scenario: " << scenario.name << std::endl)
@@ -64,8 +64,9 @@ void TestRunnerBase::loadFeature(const std::string& path) {
 
 int TestRunnerBase::runAllTests() {
     beforeAllTests();
-    return RUN_ALL_TESTS();
+    int ret = RUN_ALL_TESTS();
     afterAllTests();
+    return ret;
 }
 
 }  // namespace cucumber_bdd

csharp/Connection/TypeDBDriver.cs

@@ -80,16 +80,16 @@ private static Pinvoke.Connection OpenCloud(IDictionary<string, string> addressT
         {
             try
             {
-                string[] advertisedAddresses = new string[addressTranslation.Count];
-                string[] translatedAddresses = new string[addressTranslation.Count];
+                string[] publicAddresses = new string[addressTranslation.Count];
+                string[] privateAddresses = new string[addressTranslation.Count];
                 int index = 0;
                 foreach (KeyValuePair<string, string> translation in addressTranslation)
                 {
-                    advertisedAddresses[index] = translation.Key;
-                    translatedAddresses[index] = translation.Value;
+                    publicAddresses[index] = translation.Key;
+                    privateAddresses[index] = translation.Value;
                     index++;
                 }
-                return Pinvoke.typedb_driver.connection_open_cloud_translated(advertisedAddresses, translatedAddresses, credential.NativeObject);
+                return Pinvoke.typedb_driver.connection_open_cloud_translated(publicAddresses, privateAddresses, credential.NativeObject);
             }
             catch (Pinvoke.Error e)
             {

csharp/Drivers.cs

@@ -71,7 +71,7 @@ public static ITypeDBDriver CloudDriver(string address, TypeDBCredential credent
          * </pre>
          *
          * @param addresses The address(es) of the TypeDB server(s) or translation map from addresses
-         * received from the TypeDB server(s) to addresses to be used by the driver for connection
+         * to be used by the driver for connection to addresses received from the TypeDB server(s)
          * @param credential The credential to connect with
          */
         public static ITypeDBDriver CloudDriver(ICollection<string> addresses, TypeDBCredential credential)