Skip to content

Commit 94d7b4f

Browse files
author
Alex Walker
authored
Fix pip package using wrong Python package names (#117)
## What is the goal of this PR? The Python package names generated for our Cluster proto files were incorrect. We updated our `python_repackage` rules to fix it. ## What are the changes implemented in this PR? Update our `python_repackage` rules that run against Python package targets so that the Cluster proto files use the correct import paths
1 parent bb59512 commit 94d7b4f

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

dependencies/graknlabs/repositories.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,5 +21,5 @@ def graknlabs_dependencies():
2121
git_repository(
2222
name = "graknlabs_dependencies",
2323
remote = "https://github.com/graknlabs/dependencies",
24-
commit = "fcc3a69b8f0cdd2d56c8faccbedea5f39d2a345c", # sync-marker: do not remove this comment, this is used for sync-dependencies by @graknlabs_dependencies
24+
commit = "d8cce4fbec3c059232b9101a0c75422cd2e0ea7a", # sync-marker: do not remove this comment, this is used for sync-dependencies by @graknlabs_dependencies
2525
)

grpc/python/BUILD

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,13 +50,15 @@ python_grpc_compile(
5050
python_repackage(
5151
name = "protocol-pkg",
5252
src = ":protocol-src",
53-
package = "grakn_protocol"
53+
src_package = "protobuf",
54+
py_package_add_prefix = "grakn_protocol",
5455
)
5556

5657
python_repackage(
5758
name = "protocol-cluster-pkg",
5859
src = ":protocol-cluster-src",
59-
package = "grakn_protocol"
60+
src_package = "protobuf.cluster",
61+
py_package_add_prefix = "grakn_protocol",
6062
)
6163

6264
py_library(

0 commit comments

Comments
 (0)