Skip to content

Commit db23637

Browse files
author
Alex Walker
authored
Add 'type' field to Thing (#126)
## What is the goal of this PR? The `Thing` message now contains a new field, `type`, which holds the concept type. As a result of this change, `value_type` is now redundant (equivalent to `type.value_type`) and `encoding` can be inferred from `type.encoding`, so both fields have been deleted. ## What are the changes implemented in this PR? Add 'type' field to Thing message; delete `value_type` and `encoding`
1 parent a9a6d23 commit db23637

File tree

1 file changed

+2
-9
lines changed

1 file changed

+2
-9
lines changed

protobuf/concept.proto

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -105,9 +105,8 @@ message Concept {
105105
message Thing {
106106

107107
bytes iid = 1;
108-
Encoding encoding = 2;
109-
AttributeType.ValueType value_type = 3;
110-
Attribute.Value value = 4;
108+
Type type = 2;
109+
Attribute.Value value = 3;
111110

112111
message Req {
113112
bytes iid = 1;
@@ -156,12 +155,6 @@ message Thing {
156155
}
157156
}
158157

159-
enum Encoding {
160-
ENTITY = 0;
161-
RELATION = 1;
162-
ATTRIBUTE = 2;
163-
}
164-
165158
message Delete {
166159
message Req {}
167160
message Res {}

0 commit comments

Comments
 (0)