Skip to content

Commit 35bd241

Browse files
authored
Fix Field.formfield(), GeometryField.formfield() methods (#1778)
This partially reverts and fixes bugs introduced in 9010b5f.
1 parent a9c56a9 commit 35bd241

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

django-stubs/contrib/gis/db/models/fields.pyi

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,8 +109,13 @@ class GeometryField(BaseSpatialField[_ST, _GT]):
109109
error_messages: _ErrorMessagesMapping | None = ...,
110110
) -> None: ...
111111
def formfield( # type: ignore[override]
112-
self, *, form_class: type[GeometryField] | None = ..., geom_type: str = ..., srid: Any = ..., **kwargs: Any
113-
) -> GeometryField: ...
112+
self,
113+
*,
114+
form_class: type[forms.GeometryField] | None = ...,
115+
geom_type: str = ...,
116+
srid: Any = ...,
117+
**kwargs: Any,
118+
) -> forms.GeometryField: ...
114119
def select_format(self, compiler: Any, sql: Any, params: Any) -> Any: ...
115120

116121
class PointField(GeometryField[_ST, _GT]):

django-stubs/db/models/fields/__init__.pyi

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -205,10 +205,10 @@ class Field(RegisterLookupMixin, Generic[_ST, _GT]):
205205
# TODO: plugin support
206206
def formfield(
207207
self,
208-
form_class: type[Field] | None = ...,
208+
form_class: type[forms.Field] | None = ...,
209209
choices_form_class: type[forms.ChoiceField] | None = ...,
210210
**kwargs: Any,
211-
) -> Field: ...
211+
) -> forms.Field: ...
212212
def save_form_data(self, instance: Model, data: Any) -> None: ...
213213
def contribute_to_class(self, cls: type[Model], name: str, private_only: bool = ...) -> None: ...
214214
def to_python(self, value: Any) -> Any: ...

0 commit comments

Comments
 (0)