New "has no field named" error after upgrading to 5.2.3+ (missing a deferral?)

[asottile-sentry]

Bug report

apologies I haven't been able to narrow this down yet -- but it appears only after upgrading:

src/sentry/models/group.py:87: error: Group has no field named 'short_id'  [misc]

however this model does have this field:

• https://github.com/getsentry/sentry/blob/0fb99c104713410075b9be24d4882f73564cd4aa/src/sentry/models/group.py#L87
• https://github.com/getsentry/sentry/blob/0fb99c104713410075b9be24d4882f73564cd4aa/src/sentry/models/group.py#L634

debugging it looks like the symbol does exist but may need a deferral pass?

around hereish:

django-stubs/mypy_django_plugin/django/context.py

Line 88 in 82c99e8

if not isinstance(field_type, Instance):

((Pdb)) info.get(field_name)
<mypy.nodes.SymbolTableNode object at 0x14a1e0310>
((Pdb)) info.get(field_name).node
<Var 'sentry.models.group.Group.short_id' at 0x14a1cfe20>
((Pdb)) info.get(field_name).node.type  # None
((Pdb)) info.get(field_name).node.is_ready
False

(Var being a not-yet-resolved alias I believe?)

System information

• OS:
• python version: 3.13.1
• django version: modern
• mypy version: 1.17.1
• django-stubs version: 5.2.5 (forked)
• django-stubs-ext version: 5.2.5

[asottile-sentry]

I believe this regressed (?) in ed7b2b6 cc @UnknownPlatypus

though I am having quite the time bisecting due to the fork :S

[UnknownPlatypus]

though I am having quite the time bisecting due to the fork :S

Understandable :s, I've mostly reused an internal helper but I believe you're right with the line 88 that should probably trigger a deferral instead of a simple return None that is mistaken as a "there is no field here"

If you can come up with a yml test reproducing this behavior that would be awesome. I'll give it a shot otherwise when I get some time

[asottile-sentry]

I'm not sure if it's related but this test-only (not installed) model also started erroring:

tests/sentry/db/models/fields/bitfield/test_bitfield.py:192: error: BitFieldTestModel has no field named 'flags'  [misc]