Skip to content

Switch to uv_build build system & cleanup #2848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2025
Merged

Switch to uv_build build system & cleanup #2848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,3 @@ jobs:
run: |
uv build .
uv build ext/
- name: Check package metadata
run: |
uvx twine check --strict dist/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does uv has an alternative with a dry-run?

Copy link
Member

@ngnpope ngnpope Sep 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #2846 (comment) - twine check is only making sure that rST is valid in the long description, but we're using markdown.

uvx twine check --strict ext/dist/*
13 changes: 7 additions & 6 deletions ext/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
[build-system]
build-backend = "hatchling.build"
requires = ["hatchling"]

[project]
name = "django-stubs-ext"
# NB! For clarity, keep version major.minor.patch in sync with django-stubs.
Expand Down Expand Up @@ -43,5 +39,10 @@ Homepage = "https://github.com/typeddjango/django-stubs"
Funding = "https://github.com/sponsors/typeddjango"
"Release notes" = "https://github.com/typeddjango/django-stubs/releases"

[tool.hatch.build]
packages = ["django_stubs_ext"]
[build-system]
requires = ["uv_build>=0.8.22,<0.9.0"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to be this specific? Will "uv_build>=0.8" work?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is recommended by official docs https://docs.astral.sh/uv/concepts/build-backend/#using-the-uv-build-backend

I guess patchlevel versions may contain fixes, I see no reason to allow downgrading to more buggy versions given that we haven't tested with them.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why isn't @dependabot updating this? 🤔

It updated in djangorestframework-stubs:

build-backend = "uv_build"

[tool.uv.build-backend]
module-name = ["django_stubs_ext"]
module-root = ""
13 changes: 7 additions & 6 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
[build-system]
requires = ["hatchling"]
build-backend = "hatchling.build"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never liked that this was at the top of the file; moved to below package metadata.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also lean on https://github.com/tox-dev/pyproject-fmt/ for a consistent sort


[project]
name = "django-stubs"
version = "5.2.5"
Expand Down Expand Up @@ -80,8 +76,13 @@ Funding = "https://github.com/sponsors/typeddjango"
django-stubs = { workspace = true }
django-stubs-ext = { path = "ext", editable = true }

[tool.hatch.build]
packages = ["django-stubs", "mypy_django_plugin"]
[build-system]
requires = ["uv_build>=0.8.22,<0.9.0"]
build-backend = "uv_build"

[tool.uv.build-backend]
module-name = ["django-stubs", "mypy_django_plugin"]
module-root = ""

[tool.codespell]
ignore-words-list = "aadd,acount,nam,asend"
Expand Down
Loading