Accept lazy strings as path in APIRequestFactory and APIClient http methods

[browniebroke]

I have made things!

I received and update for mypy 1.17.1 -> 1.18.1 and started to see some failures pointing at code like this in my tests:

class TestAPIView:
    url = reverse_lazy("api:example")

    def test_ok(self, api_client: APIClient):
        ...
        response = api_client.get(self.url)  # Error here
        ...

The error message was:

error: Argument 1 to "get" of "APIClient" has incompatible type "_StrPromise"; expected "str"  [arg-type]

The code runs fine and the type check was ok with it in previous versions. Therefore we can probably safely accept lazy strings as path.

Note: while running the tests it seems like we also need to update the base client class in django-stubs. I'll try to do that at some point when I have more time EDIT: it was due to a suppression comment being on the wrong place.

Related issues

[intgr]

Thanks! You are correct, paths can be lazy.

[browniebroke]

Thanks for the comments, super helpful!

[browniebroke]

The stubtest failure seems unrelated... AFAIK it happens on other branches. Seems like an easy fix though

[intgr]

Thanks!

[intgr]

djangorestframework-stubs 3.16.3 released just now with this change.

Release notes: https://github.com/typeddjango/djangorestframework-stubs/releases/tag/3.16.3