Skip to content

Commit 194df6f

Browse files
committed
refactor(MongoBinaryDownloadUrl::getFedoraVersionString): change to use "else if" chain
and reduce comparisons
1 parent 31b4696 commit 194df6f

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

packages/mongodb-memory-server-core/src/util/MongoBinaryDownloadUrl.ts

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -349,14 +349,11 @@ export class MongoBinaryDownloadUrl implements MongoBinaryDownloadUrlOpts {
349349
// 34 onward dosnt have "compat-openssl10" anymore, and only build from 4.0.24 are available for "rhel80"
350350
if (fedoraVer >= 34) {
351351
rhelOS.release = '8.0';
352-
}
353-
if (fedoraVer < 34 && fedoraVer >= 19) {
352+
} else if (fedoraVer >= 19) {
354353
rhelOS.release = '7.0';
355-
}
356-
if (fedoraVer < 19 && fedoraVer >= 12) {
354+
} else if (fedoraVer >= 12) {
357355
rhelOS.release = '6.2';
358-
}
359-
if (fedoraVer < 12 && fedoraVer >= 6) {
356+
} else if (fedoraVer >= 6) {
360357
rhelOS.release = '5.5';
361358
}
362359

@@ -412,6 +409,7 @@ export class MongoBinaryDownloadUrl implements MongoBinaryDownloadUrlOpts {
412409
}
413410

414411
if (semver.satisfies(releaseAsSemver, '>=9.0.0')) {
412+
// there are only binaries for rhel90 since 6.0.4
415413
name += '90';
416414
} else if (semver.satisfies(releaseAsSemver, '8.2.0') && this.arch == 'aarch64') {
417415
// Mongodb changed its naming for rhel8 only https://jira.mongodb.org/browse/SERVER-92375

0 commit comments

Comments
 (0)