fix(MongoBinaryUrl): getDownloadUrl: try to create an "URL" to check if the url is valid

Author: hasezoey

docs/api/config-options.md

@@ -49,7 +49,7 @@ Option `DEBUG` is used to enable Debug Output
 
 Option `DOWNLOAD_MIRROR` is used to set which mirror to use
 
-Default / Format: `https://fastdl.mongodb.org`
+Default / Format: `https://fastdl.mongodb.org` (protocol needs to be included)
 
 ### DOWNLOAD_URL
 

packages/mongodb-memory-server-core/src/util/MongoBinaryDownloadUrl.ts

@@ -4,6 +4,7 @@ import debug from 'debug';
 import * as semver from 'semver';
 import { isNullOrUndefined } from './utils';
 import { BaseDryMongoBinaryOptions, DryMongoBinary } from './DryMongoBinary';
+import { URL } from 'url';
 
 const log = debug('MongoMS:MongoBinaryDownloadUrl');
 
@@ -39,7 +40,9 @@ export class MongoBinaryDownloadUrl {
     if (downloadUrl) {
       log(`Using "${downloadUrl}" as the Download-URL`);
 
-      return downloadUrl;
+      const url = new URL(downloadUrl); // check if this is an valid url
+
+      return url.toString();
     }
 
     const archive = await this.getArchiveName();
@@ -49,7 +52,10 @@ export class MongoBinaryDownloadUrl {
       resolveConfig(ResolveConfigVariables.DOWNLOAD_MIRROR) ?? 'https://fastdl.mongodb.org';
     log(`Using "${mirror}" as the mirror`);
 
-    return `${mirror}/${this.platform}/${archive}`;
+    const url = new URL(mirror);
+    url.pathname = `/${this.platform}/${archive}`;
+
+    return url.toString();
   }
 
   /**