fix: drop fs-extra dependency to avoid memory leak on jest tests

Closes #68

Author: nodkz

package.json

@@ -51,7 +51,6 @@
     "babel-runtime": "^6.26.0",
     "debug": "^3.1.0",
     "decompress": "^4.2.0",
-    "fs-extra": "^6.0.1",
     "get-port": "^3.2.0",
     "getos": "^3.1.0",
     "https-proxy-agent": "^2.2.1",

src/util/MongoBinaryDownload.js

@@ -4,7 +4,7 @@
 import os from 'os';
 import url from 'url';
 import path from 'path';
-import fs from 'fs-extra';
+import fs from 'fs';
 import md5File from 'md5-file';
 import https from 'https';
 import HttpsProxyAgent from 'https-proxy-agent';
@@ -83,7 +83,9 @@ export default class MongoBinaryDownload {
       version: this.version,
     });
 
-    await fs.ensureDir(this.downloadDir);
+    if (!fs.existsSync(this.downloadDir)) {
+      fs.mkdirSync(this.downloadDir);
+    }
 
     const downloadUrl = await mbdUrl.getDownloadUrl();
     const mongoDBArchive = await this.download(downloadUrl);
@@ -95,8 +97,9 @@ export default class MongoBinaryDownload {
   }
 
   async checkMd5(mongoDBArchiveMd5: string, mongoDBArchive: string) {
-    const signatureContent = (await fs.readFile(mongoDBArchiveMd5)).toString('UTF-8');
-    const md5Remote = signatureContent.match(/(.*?)\s/)[1];
+    const signatureContent = fs.readFileSync(mongoDBArchiveMd5).toString('UTF-8');
+    const m = signatureContent.match(/(.*?)\s/);
+    const md5Remote = m ? m[1] : null;
     const md5Local = md5File.sync(mongoDBArchive);
     if (md5Remote !== md5Local) {
       throw new Error('MongoBinaryDownload: md5 check is failed');
@@ -142,7 +145,10 @@ export default class MongoBinaryDownload {
     const binaryName = this.platform === 'win32' ? 'mongod.exe' : 'mongod';
     const extractDir = path.resolve(this.downloadDir, this.version);
     this.debug(`extract(): ${extractDir}`);
-    await fs.ensureDir(extractDir);
+
+    if (!fs.existsSync(extractDir)) {
+      fs.mkdirSync(extractDir);
+    }
 
     let filter;
     if (this.platform === 'win32') {
@@ -185,11 +191,10 @@ export default class MongoBinaryDownload {
         response.pipe(fileStream);
 
         fileStream.on('finish', () => {
-          fileStream.close(() => {
-            fs.renameSync(tempDownloadLocation, downloadLocation);
-            this.debug(`renamed ${tempDownloadLocation} to ${downloadLocation}`);
-            resolve(downloadLocation);
-          });
+          fileStream.close();
+          fs.renameSync(tempDownloadLocation, downloadLocation);
+          this.debug(`renamed ${tempDownloadLocation} to ${downloadLocation}`);
+          resolve(downloadLocation);
         });
 
         response.on('data', (chunk: any) => {

yarn.lock

@@ -2360,7 +2360,7 @@ fs-copy-file-sync@^1.1.1:
   version "1.1.1"
   resolved "https://registry.yarnpkg.com/fs-copy-file-sync/-/fs-copy-file-sync-1.1.1.tgz#11bf32c096c10d126e5f6b36d06eece776062918"
 
-fs-extra@^6.0.0, fs-extra@^6.0.1:
+fs-extra@^6.0.0:
   version "6.0.1"
   resolved "https://registry.yarnpkg.com/fs-extra/-/fs-extra-6.0.1.tgz#8abc128f7946e310135ddc93b98bddb410e7a34b"
   dependencies: