fix: resolve "Invalid Semver version" problem #345 #335 (#346)

* fix: fix "Invalid Semver version"

- add tests for "latest" for macos & windows
- fix "Invalid Version: latest" for macos & windows

closes #345

* fix: remove dedent

- replace all occurences with "dedent" with proper strings

closes #335

Author: hasezoey

packages/mongodb-memory-server-core/package.json

@@ -63,7 +63,6 @@
     "camelcase": "^6.0.0",
     "cross-spawn": "^7.0.3",
     "debug": "^4.1.1",
-    "dedent": "^0.7.0",
     "find-cache-dir": "^3.3.1",
     "find-package-json": "^1.2.0",
     "get-port": "^5.1.1",

packages/mongodb-memory-server-core/src/util/MongoBinary.ts

@@ -5,7 +5,6 @@ import LockFile from 'lockfile';
 import mkdirp from 'mkdirp';
 import findCacheDir from 'find-cache-dir';
 import { execSync } from 'child_process';
-import dedent from 'dedent';
 import { promisify } from 'util';
 import MongoBinaryDownload from './MongoBinaryDownload';
 import resolveConfig, { envToBool } from './resolve-config';
@@ -147,13 +146,12 @@ export default class MongoBinary {
 
         if (version !== LATEST_VERSION && version !== binaryVersion) {
           // we will log the version number of the system binary and the version requested so the user can see the difference
-          log(dedent`
-            MongoMemoryServer: Possible version conflict
-              SystemBinary version: ${binaryVersion}
-              Requested version:    ${version}
-
-              Using SystemBinary!
-          `);
+          log(
+            'MongoMemoryServer: Possible version conflict\n' +
+              `  SystemBinary version: ${binaryVersion}\n` +
+              `  Requested version:    ${version}\n\n` +
+              '  Using SystemBinary!'
+          );
         }
       }
     }

packages/mongodb-memory-server-core/src/util/MongoBinaryDownload.ts

@@ -14,7 +14,6 @@ import { HttpsProxyAgent } from 'https-proxy-agent';
 import { promisify } from 'util';
 import resolveConfig, { envToBool } from './resolve-config';
 import debug from 'debug';
-import dedent from 'dedent';
 
 const log = debug('MongoMS:MongoBinaryDownload');
 
@@ -324,10 +323,10 @@ export default class MongoBinaryDownload {
           if (response.statusCode != 200) {
             if (response.statusCode === 403) {
               reject(
-                new Error(dedent`
-                  Status Code is 403 (MongoDB's 404)\n
-                  This means that the requested version-platform combination dosnt exist
-                `)
+                new Error(
+                  "Status Code is 403 (MongoDB's 404)\n" +
+                    "This means that the requested version-platform combination doesn't exist"
+                )
               );
               return;
             }

packages/mongodb-memory-server-core/src/util/MongoBinaryDownloadUrl.ts

@@ -3,6 +3,7 @@ import { execSync } from 'child_process';
 import resolveConfig from './resolve-config';
 import debug from 'debug';
 import * as semver from 'semver';
+import { isNullOrUndefined } from 'util';
 
 const log = debug('MongoMS:MongoBinaryDownloadUrl');
 
@@ -73,10 +74,12 @@ export default class MongoBinaryDownloadUrl {
   async getArchiveNameWin(): Promise<string> {
     let name = `mongodb-${this.platform}`;
     name += `-${this.arch}`;
-    if (semver.satisfies(this.version, '4.2.x')) {
-      name += '-2012plus';
-    } else if (semver.lt(this.version, '4.0.0')) {
-      name += '-2008plus-ssl';
+    if (!isNullOrUndefined(semver.coerce(this.version))) {
+      if (semver.satisfies(this.version, '4.2.x')) {
+        name += '-2012plus';
+      } else if (semver.lt(this.version, '4.0.0')) {
+        name += '-2008plus-ssl';
+      }
     }
     name += `-${this.version}.zip`;
     return name;
@@ -88,10 +91,11 @@ export default class MongoBinaryDownloadUrl {
    */
   async getArchiveNameOsx(): Promise<string> {
     let name = `mongodb-osx`;
-    if (semver.gte(this.version, '3.2.0')) {
+    const version = semver.coerce(this.version);
+    if (!isNullOrUndefined(version) && semver.gte(version, '3.2.0')) {
       name += '-ssl';
     }
-    if (semver.gte(this.version, '4.2.0')) {
+    if (isNullOrUndefined(version) || semver.gte(version, '4.2.0')) {
       name = `mongodb-macos`; // somehow these files are not listed in https://www.mongodb.org/dl/osx
     }
     name += `-${this.arch}`;
@@ -332,7 +336,9 @@ export default class MongoBinaryDownloadUrl {
       case 'darwin':
         return 'osx';
       case 'win32':
-        return semver.gte(this.version, '4.3.0') ? 'windows' : 'win32';
+        const version = semver.coerce(this.version);
+        if (isNullOrUndefined(version)) return 'windows';
+        return semver.gte(version, '4.3.0') ? 'windows' : 'win32';
       case 'linux':
       case 'elementary OS':
         return 'linux';

packages/mongodb-memory-server-core/src/util/__tests__/MongoBinaryDownloadUrl-test.ts

@@ -3,6 +3,17 @@ import MongoBinaryDownloadUrl from '../MongoBinaryDownloadUrl';
 describe('MongoBinaryDownloadUrl', () => {
   describe('getDownloadUrl()', () => {
     describe('for mac', () => {
+      it('latest', async () => {
+        const du = new MongoBinaryDownloadUrl({
+          platform: 'darwin',
+          arch: 'x64',
+          version: 'latest',
+        });
+        expect(await du.getDownloadUrl()).toBe(
+          'https://fastdl.mongodb.org/osx/mongodb-macos-x86_64-latest.tgz'
+        );
+      });
+
       it('4.4', async () => {
         const du = new MongoBinaryDownloadUrl({
           platform: 'darwin',
@@ -102,6 +113,17 @@ describe('MongoBinaryDownloadUrl', () => {
           'https://fastdl.mongodb.org/windows/mongodb-windows-x86_64-4.4.0.zip'
         );
       });
+
+      it('latest (windows)', async () => {
+        const du = new MongoBinaryDownloadUrl({
+          platform: 'win32',
+          arch: 'x64',
+          version: 'latest',
+        });
+        expect(await du.getDownloadUrl()).toBe(
+          'https://fastdl.mongodb.org/windows/mongodb-windows-x86_64-latest.zip'
+        );
+      });
     });
 
     it('fallback', async () => {