test(MongoInstance): change "closeHandler" event tests to be in a describe block

Author: hasezoey

packages/mongodb-memory-server-core/src/util/__tests__/MongoInstance.test.ts

@@ -307,79 +307,88 @@ describe('MongodbInstance', () => {
       expect(events.get(MongoInstanceEvents.instanceSTDERR)).toEqual(['hello']);
     });
 
-    it('"closeHandler" should emit "instanceClosed"', () => {
-      // test both code and signal
-      {
-        events.clear();
-        mongod.closeHandler(0, 'SIG');
-
-        expect(events.size).toEqual(1);
-        expect(events.get(MongoInstanceEvents.instanceClosed)).toEqual([0, 'SIG']);
-      }
-      // test only code
-      {
-        events.clear();
-        mongod.closeHandler(0, null);
-
-        expect(events.size).toEqual(1);
-        expect(events.get(MongoInstanceEvents.instanceClosed)).toEqual([0, null]);
-      }
-      // test only Signal
-      {
-        events.clear();
-        mongod.closeHandler(null, 'SIG');
+    describe('closeHandler()', () => {
+      const origPlatform = process.platform;
+      beforeEach(() => {
+        Object.defineProperty(process, 'platform', {
+          value: origPlatform,
+        });
+      });
 
-        expect(events.size).toEqual(2);
-        expect(events.get(MongoInstanceEvents.instanceClosed)).toEqual([null, 'SIG']);
+      it('should emit "instanceClosed"', () => {
+        // test both code and signal
+        {
+          events.clear();
+          mongod.closeHandler(0, 'SIG');
 
-        const event = events.get(MongoInstanceEvents.instanceError)?.[0];
-        expect(event).toBeInstanceOf(UnexpectedCloseError);
-        assertIsError(event); // has to be used, because there is not typeguard from "expect(variable).toBeInstanceOf"
-        expect(event.message).toMatchSnapshot();
-      }
-    });
+          expect(events.size).toEqual(1);
+          expect(events.get(MongoInstanceEvents.instanceClosed)).toEqual([0, 'SIG']);
+        }
+        // test only code
+        {
+          events.clear();
+          mongod.closeHandler(0, null);
 
-    it('"closeHandler" should emit "instanceError" with extra information on "SIGILL"', () => {
-      // test SIGILL
-      mongod.closeHandler(null, 'SIGILL');
+          expect(events.size).toEqual(1);
+          expect(events.get(MongoInstanceEvents.instanceClosed)).toEqual([0, null]);
+        }
+        // test only Signal
+        {
+          events.clear();
+          mongod.closeHandler(null, 'SIG');
 
-      expect(events.size).toEqual(2);
-      expect(events.get(MongoInstanceEvents.instanceClosed)).toEqual([null, 'SIGILL']);
+          expect(events.size).toEqual(2);
+          expect(events.get(MongoInstanceEvents.instanceClosed)).toEqual([null, 'SIG']);
 
-      const event = events.get(MongoInstanceEvents.instanceError)?.[0];
-      expect(event).toBeInstanceOf(UnexpectedCloseError);
-      assertIsError(event); // has to be used, because there is not typeguard from "expect(variable).toBeInstanceOf"
-      expect(event.message).toMatchSnapshot();
-    });
+          const event = events.get(MongoInstanceEvents.instanceError)?.[0];
+          expect(event).toBeInstanceOf(UnexpectedCloseError);
+          assertIsError(event); // has to be used, because there is not typeguard from "expect(variable).toBeInstanceOf"
+          expect(event.message).toMatchSnapshot();
+        }
+      });
 
-    it('"closeHandler" should emit "instanceError" with non-0 or non-12 code', () => {
-      // test code non-0
-      {
-        events.clear();
-        mongod.closeHandler(1, null);
+      it('should emit "instanceError" with extra information on "SIGILL"', () => {
+        // test SIGILL
+        mongod.closeHandler(null, 'SIGILL');
 
         expect(events.size).toEqual(2);
-        expect(events.get(MongoInstanceEvents.instanceClosed)).toEqual([1, null]);
+        expect(events.get(MongoInstanceEvents.instanceClosed)).toEqual([null, 'SIGILL']);
 
         const event = events.get(MongoInstanceEvents.instanceError)?.[0];
         expect(event).toBeInstanceOf(UnexpectedCloseError);
         assertIsError(event); // has to be used, because there is not typeguard from "expect(variable).toBeInstanceOf"
         expect(event.message).toMatchSnapshot();
-      }
+      });
 
-      // test signal
-      {
-        events.clear();
-        mongod.closeHandler(null, 'SIG');
+      it('should emit "instanceError" with non-0 or non-12 code', () => {
+        // test code non-0
+        {
+          events.clear();
+          mongod.closeHandler(1, null);
 
-        expect(events.size).toEqual(2);
-        expect(events.get(MongoInstanceEvents.instanceClosed)).toEqual([null, 'SIG']);
+          expect(events.size).toEqual(2);
+          expect(events.get(MongoInstanceEvents.instanceClosed)).toEqual([1, null]);
 
-        const event = events.get(MongoInstanceEvents.instanceError)?.[0];
-        expect(event).toBeInstanceOf(UnexpectedCloseError);
-        assertIsError(event); // has to be used, because there is not typeguard from "expect(variable).toBeInstanceOf"
-        expect(event.message).toMatchSnapshot();
-      }
+          const event = events.get(MongoInstanceEvents.instanceError)?.[0];
+          expect(event).toBeInstanceOf(UnexpectedCloseError);
+          assertIsError(event); // has to be used, because there is not typeguard from "expect(variable).toBeInstanceOf"
+          expect(event.message).toMatchSnapshot();
+        }
+
+        // test signal
+        {
+          events.clear();
+          mongod.closeHandler(null, 'SIG');
+
+          expect(events.size).toEqual(2);
+          expect(events.get(MongoInstanceEvents.instanceClosed)).toEqual([null, 'SIG']);
+
+          const event = events.get(MongoInstanceEvents.instanceError)?.[0];
+          expect(event).toBeInstanceOf(UnexpectedCloseError);
+          assertIsError(event); // has to be used, because there is not typeguard from "expect(variable).toBeInstanceOf"
+          expect(event.message).toMatchSnapshot();
+        }
+      });
     });
 
     describe('stdoutHandler()', () => {

packages/mongodb-memory-server-core/src/util/__tests__/__snapshots__/MongoInstance.test.ts.snap

@@ -6,20 +6,20 @@ exports[`MongodbInstance prepareCommandArgs should throw an error if no dbpath i
 
 exports[`MongodbInstance prepareCommandArgs should throw an error if no port is provided 1`] = `"\\"instanceOpts.port\\" is required to be set!"`;
 
-exports[`MongodbInstance test events "closeHandler" should emit "instanceClosed" 1`] = `"Instance closed unexpectedly with code \\"null\\" and signal \\"SIG\\""`;
+exports[`MongodbInstance test events "start" should emit a "instanceError" when timeout is reached and throw a error 1`] = `"Instance failed to start within 1000ms"`;
+
+exports[`MongodbInstance test events checkErrorInLine() should emit "instanceError" when shared libraries fail to load 1`] = `"Instance failed to start because a library is missing or cannot be opened: \\"libcrypto.so.1.1\\""`;
+
+exports[`MongodbInstance test events closeHandler() should emit "instanceClosed" 1`] = `"Instance closed unexpectedly with code \\"null\\" and signal \\"SIG\\""`;
 
-exports[`MongodbInstance test events "closeHandler" should emit "instanceError" with extra information on "SIGILL" 1`] = `
+exports[`MongodbInstance test events closeHandler() should emit "instanceError" with extra information on "SIGILL" 1`] = `
 "Instance closed unexpectedly with code \\"null\\" and signal \\"SIGILL\\"
 The Process Exited with SIGILL, which mean illegal instruction, which is commonly thrown in mongodb 5.0+ when not having AVX available on the CPU"
 `;
 
-exports[`MongodbInstance test events "closeHandler" should emit "instanceError" with non-0 or non-12 code 1`] = `"Instance closed unexpectedly with code \\"1\\" and signal \\"null\\""`;
+exports[`MongodbInstance test events closeHandler() should emit "instanceError" with non-0 or non-12 code 1`] = `"Instance closed unexpectedly with code \\"1\\" and signal \\"null\\""`;
 
-exports[`MongodbInstance test events "closeHandler" should emit "instanceError" with non-0 or non-12 code 2`] = `"Instance closed unexpectedly with code \\"null\\" and signal \\"SIG\\""`;
-
-exports[`MongodbInstance test events "start" should emit a "instanceError" when timeout is reached and throw a error 1`] = `"Instance failed to start within 1000ms"`;
-
-exports[`MongodbInstance test events checkErrorInLine() should emit "instanceError" when shared libraries fail to load 1`] = `"Instance failed to start because a library is missing or cannot be opened: \\"libcrypto.so.1.1\\""`;
+exports[`MongodbInstance test events closeHandler() should emit "instanceError" with non-0 or non-12 code 2`] = `"Instance closed unexpectedly with code \\"null\\" and signal \\"SIG\\""`;
 
 exports[`MongodbInstance test events stdoutHandler() should emit "instanceError" when "excepetion in initAndListen" is thrown DBException in initAndListen 1`] = `
 "Instance Failed to start with \\"DBException in initAndListen\\". Original Error: