feat(MongoBinaryDownloadUrl): change to throw a error when debian 10 used for versions below 4.2.0

fixes #554
re #448

Author: hasezoey

packages/mongodb-memory-server-core/src/util/MongoBinaryDownloadUrl.ts

@@ -5,7 +5,11 @@ import * as semver from 'semver';
 import { isNullOrUndefined } from './utils';
 import { BaseDryMongoBinaryOptions, DryMongoBinary } from './DryMongoBinary';
 import { URL } from 'url';
-import { UnknownArchitectureError, UnknownPlatformError } from './errors';
+import {
+  KnownVersionIncompatibilityError,
+  UnknownArchitectureError,
+  UnknownPlatformError,
+} from './errors';
 
 const log = debug('MongoMS:MongoBinaryDownloadUrl');
 
@@ -220,14 +224,16 @@ export class MongoBinaryDownloadUrl implements MongoBinaryDownloadUrlOpts {
     const release: number = parseFloat(os.release);
 
     if (release >= 10 || ['unstable', 'testing'].includes(os.release)) {
-      if (semver.lte(this.version, '4.2.0')) {
-        log(
-          `getDebianVersionString: requested version "${this.version}" not available for osrelease "${release}", using "92"`
+      if (semver.lt(this.version, '4.2.1')) {
+        throw new KnownVersionIncompatibilityError(
+          `Debian ${release}`,
+          this.version,
+          '>=4.2.1',
+          'Mongodb does not provide binaries for versions before 4.2.1 for Debian 10+ and also cannot be mapped to a previous Debian release'
         );
-        name += '92';
-      } else {
-        name += '10';
       }
+
+      name += '10';
     } else if (release >= 9) {
       name += '92';
     } else if (release >= 8.1) {

packages/mongodb-memory-server-core/src/util/__tests__/MongoBinaryDownloadUrl.test.ts

@@ -1,5 +1,9 @@
 import { assertIsError } from '../../__tests__/testUtils/test_utils';
-import { UnknownPlatformError, UnknownArchitectureError } from '../errors';
+import {
+  UnknownPlatformError,
+  UnknownArchitectureError,
+  KnownVersionIncompatibilityError,
+} from '../errors';
 import { LinuxOS } from '../getos';
 import MongoBinaryDownloadUrl from '../MongoBinaryDownloadUrl';
 import { envName, ResolveConfigVariables } from '../resolveConfig';
@@ -169,7 +173,7 @@ describe('MongoBinaryDownloadUrl', () => {
           );
         });
 
-        it('for debian 10 for 4.0.25 should use debian 92 [#448]', async () => {
+        it('should throw a Error when requesting a version below 4.2.1 for debian 10+ [#554] [KnownVersionIncompatibilityError]', async () => {
           const du = new MongoBinaryDownloadUrl({
             platform: 'linux',
             arch: 'x64',
@@ -180,9 +184,15 @@ describe('MongoBinaryDownloadUrl', () => {
               release: '10',
             },
           });
-          expect(await du.getDownloadUrl()).toBe(
-            'https://fastdl.mongodb.org/linux/mongodb-linux-x86_64-debian92-4.0.25.tgz'
-          );
+
+          try {
+            await du.getDownloadUrl();
+            fail('Expected to throw a KnownVersionIncompatibilityError');
+          } catch (err) {
+            assertIsError(err);
+            expect(err).toBeInstanceOf(KnownVersionIncompatibilityError);
+            expect(err.message).toMatchSnapshot();
+          }
         });
       });
 

packages/mongodb-memory-server-core/src/util/__tests__/__snapshots__/MongoBinaryDownloadUrl.test.ts.snap

@@ -1,5 +1,10 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
+exports[`MongoBinaryDownloadUrl getDownloadUrl() for linux for debian should throw a Error when requesting a version below 4.2.1 for debian 10+ [#554] [KnownVersionIncompatibilityError] 1`] = `
+"Requested Version \\"4.0.25\\" is not available for \\"Debian 10\\"! Available Versions: \\">=4.2.1\\"
+Mongodb does not provide binaries for versions before 4.2.1 for Debian 10+ and also cannot be mapped to a previous Debian release"
+`;
+
 exports[`MongoBinaryDownloadUrl getDownloadUrl() should throw an error if platform is unknown (getArchiveName) 1`] = `"Unknown Platform: \\"unknown\\""`;
 
 exports[`MongoBinaryDownloadUrl getDownloadUrl() should throw an error if platform is unknown (translatePlatform) 1`] = `"Unknown Platform: \\"unknown\\""`;

packages/mongodb-memory-server-core/src/util/errors.ts

@@ -145,3 +145,17 @@ export class NoRegexMatchError extends Error {
     this.message = `Expected "${name}" to have Regex Matches${addExtra}`;
   }
 }
+
+export class KnownVersionIncompatibilityError extends Error {
+  constructor(
+    public dist: string,
+    public requested_version: string,
+    public available_versions: string,
+    public extra?: string
+  ) {
+    super();
+
+    const addExtra = !!extra ? `\n${extra}` : '';
+    this.message = `Requested Version "${requested_version}" is not available for "${dist}"! Available Versions: "${available_versions}"${addExtra}`;
+  }
+}