feat(MongoBinaryDownloadUrl): remove function "getMintVersionString"

Author: hasezoey

packages/mongodb-memory-server-core/src/util/MongoBinaryDownloadUrl.ts

@@ -1,5 +1,4 @@
 import getOS, { AnyOS, LinuxOS } from './getos';
-import { execSync } from 'child_process';
 import resolveConfig, { ResolveConfigVariables } from './resolveConfig';
 import debug from 'debug';
 import * as semver from 'semver';
@@ -160,8 +159,6 @@ export class MongoBinaryDownloadUrl {
       return this.getFedoraVersionString(os);
     } else if (regexHelper(/debian/i, os)) {
       return this.getDebianVersionString(os);
-    } else if (regexHelper(/^linux\s?mint\s*$/i, os)) {
-      return this.getMintVersionString(os);
     } else if (regexHelper(/alpine/i, os)) {
       console.warn('There is no offical build of MongoDB for Alpine!');
       // Match "arch", "archlinux", "manjaro", "manjarolinux", "arco", "arcolinux"
@@ -253,14 +250,6 @@ export class MongoBinaryDownloadUrl {
     return name;
   }
 
-  /**
-   * Get the version string for Linux Mint
-   * @param os LinuxOS Object
-   */
-  getMintVersionString(os: LinuxOS): string {
-    return this.getUbuntuVersionString(os);
-  }
-
   /**
    * Linux Fallback
    * @param os LinuxOS Object
@@ -304,7 +293,7 @@ export class MongoBinaryDownloadUrl {
           mintToUbuntuRelease[parseInt(os.release.split('.')[0])] || mintToUbuntuRelease[20];
       }
 
-      if (/^elementary\s?OS\s*$/i.test(os.dist)) {
+      if (/^elementary\s?os\s*$/i.test(os.dist)) {
         const elementaryToUbuntuRelease: Record<number, string> = {
           3: '14.04',
           4: '16.04',

packages/mongodb-memory-server-core/src/util/__tests__/MongoBinaryDownloadUrl.test.ts

@@ -1,3 +1,4 @@
+import { LinuxOS } from '../getos';
 import MongoBinaryDownloadUrl from '../MongoBinaryDownloadUrl';
 import { defaultValues, ResolveConfigVariables, setDefaultValue } from '../resolveConfig';
 
@@ -203,6 +204,58 @@ describe('MongoBinaryDownloadUrl', () => {
           );
         });
       });
+
+      describe('for LinuxMint', () => {
+        let downloadUrl: MongoBinaryDownloadUrl;
+        beforeEach(() => {
+          downloadUrl = new MongoBinaryDownloadUrl({
+            platform: 'linux',
+            arch: 'x64',
+            version: '4.0.20',
+            os: {
+              os: 'linux',
+              dist: 'Linux Mint',
+              release: '',
+              id_like: 'ubuntu',
+            },
+          });
+        });
+
+        it('should default to Mint Version 20, if version cannot be found in lookup table', async () => {
+          (downloadUrl.os as LinuxOS).release = '16';
+          expect(await downloadUrl.getDownloadUrl()).toBe(
+            'https://fastdl.mongodb.org/linux/mongodb-linux-x86_64-ubuntu1804-4.0.20.tgz'
+          );
+        });
+
+        it('should return a archive name for Linux Mint 17', async () => {
+          (downloadUrl.os as LinuxOS).release = '17';
+          expect(await downloadUrl.getDownloadUrl()).toBe(
+            'https://fastdl.mongodb.org/linux/mongodb-linux-x86_64-ubuntu1404-4.0.20.tgz'
+          );
+        });
+
+        it('should return a archive name for Linux Mint 18', async () => {
+          (downloadUrl.os as LinuxOS).release = '18';
+          expect(await downloadUrl.getDownloadUrl()).toBe(
+            'https://fastdl.mongodb.org/linux/mongodb-linux-x86_64-ubuntu1604-4.0.20.tgz'
+          );
+        });
+
+        it('should return a archive name for Linux Mint 19', async () => {
+          (downloadUrl.os as LinuxOS).release = '19';
+          expect(await downloadUrl.getDownloadUrl()).toBe(
+            'https://fastdl.mongodb.org/linux/mongodb-linux-x86_64-ubuntu1804-4.0.20.tgz'
+          );
+        });
+
+        it('should return a archive name for Linux Mint 20', async () => {
+          (downloadUrl.os as LinuxOS).release = '20';
+          expect(await downloadUrl.getDownloadUrl()).toBe(
+            'https://fastdl.mongodb.org/linux/mongodb-linux-x86_64-ubuntu1804-4.0.20.tgz'
+          );
+        });
+      });
     });
 
     describe('for win32 & windows', () => {
@@ -451,84 +504,7 @@ describe('MongoBinaryDownloadUrl', () => {
     });
   });
 
-  describe('getMintVersionString', () => {
-    const downloadUrl = new MongoBinaryDownloadUrl({
-      platform: 'linux',
-      arch: 'x64',
-      version: '4.0.20',
-    });
-
-    it('should default to Mint Version 20, if version cannot be found in lookup table', () => {
-      expect(
-        downloadUrl.getMintVersionString({
-          os: 'linux',
-          dist: 'Linux Mint',
-          release: '16',
-        })
-      ).toBe('ubuntu1804');
-    });
-
-    it('should return a archive name for Linux Mint 17', () => {
-      expect(
-        downloadUrl.getMintVersionString({
-          os: 'linux',
-          dist: 'Linux Mint',
-          release: '17',
-        })
-      ).toBe('ubuntu1404');
-    });
-
-    it('should return a archive name for Linux Mint 18', () => {
-      expect(
-        downloadUrl.getMintVersionString({
-          os: 'linux',
-          dist: 'Linux Mint',
-          release: '18',
-        })
-      ).toBe('ubuntu1604');
-    });
-
-    it('should return a archive name for Linux Mint 19', () => {
-      expect(
-        downloadUrl.getMintVersionString({
-          os: 'linux',
-          dist: 'LinuxMint',
-          release: '19',
-        })
-      ).toBe('ubuntu1804');
-    });
-
-    it('should return a archive name for Linux Mint 20', () => {
-      expect(
-        downloadUrl.getMintVersionString({
-          os: 'linux',
-          dist: 'Linux Mint',
-          release: '20',
-        })
-      ).toBe('ubuntu1804');
-    });
-  });
-
-  it('shouldnt detect linux mint when using peppermint', () => {
-    jest.spyOn(console, 'warn').mockImplementation(() => void 0);
-    const downloadUrl = new MongoBinaryDownloadUrl({
-      platform: 'linux',
-      arch: 'x64',
-      version: '3.6.3',
-    });
-
-    expect(
-      downloadUrl.getLinuxOSVersionString({
-        os: 'linux',
-        dist: 'Peppermint',
-        release: '10',
-      })
-    ).toBe('');
-
-    expect(console.warn).toHaveBeenCalledTimes(1);
-  });
-
-  describe('getLegacyVersionString', () => {
+  describe('getLegacyVersionString()', () => {
     const downloadUrl = new MongoBinaryDownloadUrl({
       platform: 'linux',
       arch: 'x64',