refactor: change uses of deprecated ".stop(false)" to explicit object

only occurences not changed are tests testing explicitly for "boolean" argument

Author: hasezoey

packages/mongodb-memory-server-core/src/MongoMemoryReplSet.ts

@@ -364,7 +364,7 @@ export class MongoMemoryReplSet extends EventEmitter implements ManagerAdvanced
 
         log('ensureAsync chain threw a Error: ', err);
 
-        await this.stop(false); // still try to close the instance that was spawned, without cleanup for investigation
+        await this.stop({ doCleanup: false, force: false }); // still try to close the instance that was spawned, without cleanup for investigation
 
         this.stateChange(MongoMemoryReplSetStates.stopped);
 
@@ -503,7 +503,9 @@ export class MongoMemoryReplSet extends EventEmitter implements ManagerAdvanced
       log('stop: state is "stopped", trying to stop / kill anyway');
     }
 
-    const successfullyStopped = await Promise.all(this.servers.map((s) => s.stop(false)))
+    const successfullyStopped = await Promise.all(
+      this.servers.map((s) => s.stop({ doCleanup: false, force: false }))
+    )
       .then(() => {
         this.stateChange(MongoMemoryReplSetStates.stopped);
 
@@ -686,7 +688,7 @@ export class MongoMemoryReplSet extends EventEmitter implements ManagerAdvanced
           if (!isInMemory) {
             log('_initReplSet: closing connection for restart');
             await con.close(); // close connection in preparation for "stop"
-            await this.stop(false); // stop all servers for enabling auth
+            await this.stop({ doCleanup: false, force: false }); // stop all servers for enabling auth
             log('_initReplSet: starting all server again with auth');
             await this.initAllServers(); // start all servers again with "auth" enabled
 

packages/mongodb-memory-server-core/src/MongoMemoryServer.ts

@@ -287,7 +287,7 @@ export class MongoMemoryServer extends EventEmitter implements ManagerAdvanced {
 
       this.debug('_startUpInstance threw a Error: ', err);
 
-      await this.stop(false); // still try to close the instance that was spawned, without cleanup for investigation
+      await this.stop({ doCleanup: false, force: false }); // still try to close the instance that was spawned, without cleanup for investigation
 
       this.stateChange(MongoMemoryServerStates.stopped);
 

packages/mongodb-memory-server-core/src/__tests__/MongoMemoryServer-restart.test.ts

@@ -34,7 +34,7 @@ describe('Restart single MongoMemoryServer instance', () => {
       await connection.close();
     }
 
-    await instance.stop(false);
+    await instance.stop({ doCleanup: false, force: false });
     expect(MongoMemoryServer.prototype.cleanup).not.toHaveBeenCalled();
 
     // there is no need to wait here, because a single instance does not need to be forced to the same port

packages/mongodb-memory-server-core/src/__tests__/MongoMemoryServer.test.ts

@@ -489,7 +489,7 @@ describe('MongoMemoryServer', () => {
       jest.spyOn(utils, 'isNullOrUndefined');
       jest.spyOn(utils, 'assertion');
 
-      expect(await mongoServer.stop(false)).toEqual(true);
+      expect(await mongoServer.stop({ doCleanup: false, force: false })).toEqual(true);
       expect(instanceStopSpy).toHaveBeenCalledTimes(1);
       expect(utils.isNullOrUndefined).toHaveBeenCalledTimes(1);
       expect(utils.assertion).not.toHaveBeenCalled();
@@ -912,12 +912,12 @@ describe('MongoMemoryServer', () => {
   it('should start & stop multiple times without creating new instances & directories', async () => {
     const mongoServer = await MongoMemoryServer.create();
     const dbPath = mongoServer.instanceInfo!.dbPath;
-    await mongoServer.stop(false);
+    await mongoServer.stop({ doCleanup: false, force: false });
     expect(await utils.statPath(dbPath)).toBeTruthy();
     expect(mongoServer.instanceInfo).toBeTruthy();
     await mongoServer.start();
     expect(mongoServer.instanceInfo!.dbPath).toEqual(dbPath);
-    await mongoServer.stop(false);
+    await mongoServer.stop({ doCleanup: false, force: false });
     expect(await utils.statPath(dbPath)).toBeTruthy();
     expect(mongoServer.instanceInfo).toBeTruthy();