dependencies(typescript): upgrade to version 4.4.2

hasezoey · hasezoey · commit e89df5a3ea1e · 2021-08-31T22:33:18.000+02:00
diff --git a/package.json b/package.json
@@ -31,7 +31,7 @@
     "prettier": "2.3.2",
     "semantic-release": "17.4.7",
     "ts-jest": "27.0.5",
-    "typescript": "4.3.5"
+    "typescript": "4.4.2"
   },
   "workspaces": {
     "packages": [
diff --git a/packages/mongodb-memory-server-core/src/__tests__/MongoMemoryReplSet.test.ts b/packages/mongodb-memory-server-core/src/__tests__/MongoMemoryReplSet.test.ts
@@ -8,6 +8,7 @@ import MongoMemoryServer from '../MongoMemoryServer';
 import * as utils from '../util/utils';
 import { MongoMemoryInstanceOpts } from '../util/MongoInstance';
 import { StateError, WaitForPrimaryTimeoutError } from '../util/errors';
+import { assertIsError } from './testUtils/test_utils';
 
 jest.setTimeout(100000); // 10s
 
@@ -77,7 +78,8 @@ describe('single server replset', () => {
       new MongoMemoryReplSet({ replSet: { count: 0 } });
       fail('Expected "new MongoMemoryReplSet" to throw an error');
     } catch (err) {
-      expect(err.message).toEqual('ReplSet Count needs to be 1 or higher!');
+      assertIsError(err);
+      expect(err.message).toMatchSnapshot();
     }
   });
 
@@ -93,6 +95,7 @@ describe('single server replset', () => {
     } catch (err) {
       clearTimeout(timeout);
       expect(err).toBeInstanceOf(StateError);
+      assertIsError(err);
       expect(err.message).toMatchSnapshot();
     }
   });
@@ -118,6 +121,7 @@ describe('single server replset', () => {
     } catch (err) {
       clearTimeout(timeout);
       expect(err).toBeInstanceOf(StateError);
+      assertIsError(err);
       expect(err.message).toMatchSnapshot();
     }
   });
@@ -138,6 +142,7 @@ describe('single server replset', () => {
     } catch (err) {
       clearTimeout(timeout);
       expect(err).toBeInstanceOf(StateError);
+      assertIsError(err);
       expect(err.message).toMatchSnapshot();
     }
   });
@@ -191,6 +196,7 @@ describe('single server replset', () => {
     } catch (err) {
       clearTimeout(timeout);
       expect(err).toBeInstanceOf(StateError);
+      assertIsError(err);
       expect(err.message).toMatchSnapshot();
     }
   });
@@ -210,7 +216,8 @@ describe('single server replset', () => {
       fail('Expected "_initReplSet" to throw');
     } catch (err) {
       clearTimeout(timeout);
-      expect(err.message).toEqual('One or more servers are required.');
+      assertIsError(err);
+      expect(err.message).toMatchSnapshot();
     }
   });
 
@@ -382,6 +389,7 @@ describe('MongoMemoryReplSet', () => {
           fail('Expected assignment of "replSet.binaryOpts" to fail');
         } catch (err) {
           expect(err).toBeInstanceOf(StateError);
+          assertIsError(err);
           expect(err.message).toMatchSnapshot();
         }
       });
@@ -392,6 +400,7 @@ describe('MongoMemoryReplSet', () => {
           fail('Expected assignment of "replSet.instanceOpts" to fail');
         } catch (err) {
           expect(err).toBeInstanceOf(StateError);
+          assertIsError(err);
           expect(err.message).toMatchSnapshot();
         }
       });
@@ -402,6 +411,7 @@ describe('MongoMemoryReplSet', () => {
           fail('Expected assignment of "replSet.instanceOpts" to fail');
         } catch (err) {
           expect(err).toBeInstanceOf(StateError);
+          assertIsError(err);
           expect(err.message).toMatchSnapshot();
         }
       });
@@ -412,7 +422,8 @@ describe('MongoMemoryReplSet', () => {
         replSet.replSetOpts = { count: 0 };
         fail('Expected assignment of "replSet.instanceOpts" to fail');
       } catch (err) {
-        expect(err.message).toEqual('ReplSet Count needs to be 1 or higher!');
+        assertIsError(err);
+        expect(err.message).toMatchSnapshot();
       }
     });
   });
diff --git a/packages/mongodb-memory-server-core/src/__tests__/MongoMemoryServer.test.ts b/packages/mongodb-memory-server-core/src/__tests__/MongoMemoryServer.test.ts
@@ -10,6 +10,7 @@ import MongoInstance from '../util/MongoInstance';
 import * as utils from '../util/utils';
 import * as semver from 'semver';
 import { EnsureInstanceError, StateError } from '../util/errors';
+import { assertIsError } from './testUtils/test_utils';
 
 tmp.setGracefulCleanup();
 jest.setTimeout(100000); // 10s
@@ -253,8 +254,9 @@ describe('MongoMemoryServer', () => {
           usersInfo: 1,
         });
         fail('Expected "db.command" to fail');
-      } catch (err) {
-        expect(err.codeName).toEqual('Unauthorized');
+      } catch (err: any) {
+        // TODO: re-investigate if "codeName" is actually the right property
+        expect(err.codeName).toMatchSnapshot();
       }
       expect(MongoInstance.prototype.start).toHaveBeenCalledTimes(1);
       expect(MongoMemoryServer.prototype.createAuth).not.toHaveBeenCalled();
@@ -274,6 +276,7 @@ describe('MongoMemoryServer', () => {
           fail('Expected "start" to fail');
         } catch (err) {
           expect(err).toBeInstanceOf(StateError);
+          assertIsError(err);
           expect(err.message).toMatchSnapshot();
         }
       }
@@ -287,6 +290,7 @@ describe('MongoMemoryServer', () => {
           fail('Expected "start" to fail');
         } catch (err) {
           expect(err).toBeInstanceOf(StateError);
+          assertIsError(err);
           expect(err.message).toMatchSnapshot();
         }
       }
@@ -355,6 +359,7 @@ describe('MongoMemoryServer', () => {
         fail('Expected "ensureInstance" to throw');
       } catch (err) {
         expect(err).toBeInstanceOf(StateError);
+        assertIsError(err);
         expect(err.message).toMatchSnapshot();
       }
     });
@@ -540,6 +545,7 @@ describe('MongoMemoryServer', () => {
         fail('Expected "cleanup" to fail');
       } catch (err) {
         expect(err).toBeInstanceOf(StateError);
+        assertIsError(err);
         expect(err.message).toMatchSnapshot();
       }
     });
@@ -575,7 +581,8 @@ describe('MongoMemoryServer', () => {
       await mongoServer.createAuth();
       fail('Expected "createAuth" to fail');
     } catch (err) {
-      expect(err.message).toEqual('"createAuth" got called, but "this.auth" is undefined!');
+      assertIsError(err);
+      expect(err.message).toMatchSnapshot();
     }
   });
 
diff --git a/packages/mongodb-memory-server-core/src/__tests__/__snapshots__/MongoMemoryReplSet.test.ts.snap b/packages/mongodb-memory-server-core/src/__tests__/__snapshots__/MongoMemoryReplSet.test.ts.snap
@@ -2,6 +2,8 @@
 
 exports[`MongoMemoryReplSet "_waitForPrimary" should throw an error if timeout is reached 1`] = `"{\\"timeout\\":1}"`;
 
+exports[`MongoMemoryReplSet getters & setters setter of "replSetOpts" should throw an error if count is 1 or above 1`] = `"ReplSet Count needs to be 1 or higher!"`;
+
 exports[`MongoMemoryReplSet getters & setters state errors setter of "binaryOpts" should throw an error if state is not "stopped" 1`] = `
 "Incorrect State for operation: \\"init\\", allowed States: \\"[stopped]\\"
 This may be because of using a v6.x way of calling functions, look at the following guide if anything applies:
@@ -26,12 +28,16 @@ This may be because of using a v6.x way of calling functions, look at the follow
 https://nodkz.github.io/mongodb-memory-server/docs/guides/migrate7#no-function-other-than-start-create-ensureinstance-will-be-starting-anything"
 `;
 
+exports[`single server replset "_initReplSet" should throw if server count is 0 or less 1`] = `"One or more servers are required."`;
+
 exports[`single server replset "getUri" should throw an error if _state is not "running" or "init" 1`] = `
 "Incorrect State for operation: \\"stopped\\", allowed States: \\"[running,init]\\"
 This may be because of using a v6.x way of calling functions, look at the following guide if anything applies:
 https://nodkz.github.io/mongodb-memory-server/docs/guides/migrate7#no-function-other-than-start-create-ensureinstance-will-be-starting-anything"
 `;
 
+exports[`single server replset "new" should throw an error if replSet count is 0 or less 1`] = `"ReplSet Count needs to be 1 or higher!"`;
+
 exports[`single server replset "start" should throw an error if _state is not "stopped" 1`] = `
 "Incorrect State for operation: \\"running\\", allowed States: \\"[stopped]\\"
 This may be because of using a v6.x way of calling functions, look at the following guide if anything applies:
diff --git a/packages/mongodb-memory-server-core/src/__tests__/__snapshots__/MongoMemoryServer.test.ts.snap b/packages/mongodb-memory-server-core/src/__tests__/__snapshots__/MongoMemoryServer.test.ts.snap
@@ -1,5 +1,7 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
+exports[`MongoMemoryServer "createAuth" should throw an error if called without "this.auth" defined 1`] = `"\\"createAuth\\" got called, but \\"this.auth\\" is undefined!"`;
+
 exports[`MongoMemoryServer cleanup() should throw an error if state is not "stopped" 1`] = `
 "Incorrect State for operation: \\"new\\", allowed States: \\"[stopped]\\"
 This may be because of using a v6.x way of calling functions, look at the following guide if anything applies:
@@ -28,6 +30,8 @@ This may be because of using a v6.x way of calling functions, look at the follow
 https://nodkz.github.io/mongodb-memory-server/docs/guides/migrate7#no-function-other-than-start-create-ensureinstance-will-be-starting-anything"
 `;
 
+exports[`MongoMemoryServer start() "createAuth" should not be called if "disabled" is true 1`] = `"Unauthorized"`;
+
 exports[`MongoMemoryServer start() should throw an error if state is not "new" or "stopped" 1`] = `
 "Incorrect State for operation: \\"starting\\", allowed States: \\"[new,stopped]\\"
 This may be because of using a v6.x way of calling functions, look at the following guide if anything applies:
diff --git a/packages/mongodb-memory-server-core/src/__tests__/testUtils/test_utils.ts b/packages/mongodb-memory-server-core/src/__tests__/testUtils/test_utils.ts
@@ -0,0 +1,10 @@
+import { assertion } from '../../util/utils';
+
+/**
+ * This function is just here because "expect(err).toBeInstanceOf(Error)" does not use "asserts", and so stays "unknown" which makes typescript error
+ * Use this function after any "toBeInstanceOf" calls!
+ * @param value The Value to Assert to error
+ */
+export function assertIsError(value: unknown): asserts value is Error {
+  assertion(value instanceof Error, new Error('Expected "value" to be instanceof Error!'));
+}
diff --git a/packages/mongodb-memory-server-core/src/util/DryMongoBinary.ts b/packages/mongodb-memory-server-core/src/util/DryMongoBinary.ts
@@ -156,7 +156,11 @@ export class DryMongoBinary {
 
       return systemBinary; // returns if "access" is successful
     } catch (err) {
-      log(`getSystemPath: can't find system binary at "${systemBinary}".\n${err.message}`);
+      log(
+        `getSystemPath: can't find system binary at "${systemBinary}".\n${
+          err instanceof Error ? err.message : err
+        }`
+      );
     }
 
     return undefined;
diff --git a/packages/mongodb-memory-server-core/src/util/__tests__/MongoBinary.test.ts b/packages/mongodb-memory-server-core/src/util/__tests__/MongoBinary.test.ts
@@ -6,6 +6,7 @@ import resolveConfig, { envName, ResolveConfigVariables } from '../resolveConfig
 import * as utils from '../utils';
 import { DryMongoBinary } from '../DryMongoBinary';
 import * as childProcess from 'child_process';
+import { assertIsError } from '../../__tests__/testUtils/test_utils';
 
 tmp.setGracefulCleanup();
 
@@ -88,9 +89,8 @@ describe('MongoBinary', () => {
         await MongoBinary.getPath();
         fail('Expected "getPath" to fail');
       } catch (err) {
-        expect(err.message).toEqual(
-          'MongoBinary.getPath: could not find an valid binary path! (Got: "undefined", RUNTIME_DOWNLOAD: "false")'
-        );
+        assertIsError(err);
+        expect(err.message).toMatchSnapshot();
         expect(DryMongoBinary.locateBinary).toBeCalledTimes(1);
         expect(MongoBinary.download).not.toHaveBeenCalled();
       }
@@ -209,9 +209,8 @@ build environment:
           await MongoBinary.getPath();
           fail('Expected "getPath" to fail');
         } catch (err) {
-          expect(err.message).toEqual(
-            'Option "SYSTEM_BINARY" was set, but binaryPath was empty! (system binary could not be found?) [This Error should normally not be thrown, please report this]'
-          );
+          assertIsError(err);
+          expect(err.message).toMatchSnapshot();
         }
       });
     });
diff --git a/packages/mongodb-memory-server-core/src/util/__tests__/MongoBinaryDownload.test.ts b/packages/mongodb-memory-server-core/src/util/__tests__/MongoBinaryDownload.test.ts
@@ -1,6 +1,7 @@
 import { promises as fspromises } from 'fs';
 import md5file from 'md5-file';
 import * as mkdirp from 'mkdirp';
+import { assertIsError } from '../../__tests__/testUtils/test_utils';
 import { DryMongoBinary } from '../DryMongoBinary';
 import { Md5CheckFailedError } from '../errors';
 import { MongoBinaryOpts } from '../MongoBinary';
@@ -273,6 +274,7 @@ describe('MongoBinaryDownload', () => {
       await du.startDownload();
       fail('Expected "startDownload" to fail');
     } catch (err) {
+      assertIsError(err);
       expect(err.message).toEqual(customError.message);
       expect(console.error).toHaveBeenCalledTimes(1);
     }
diff --git a/packages/mongodb-memory-server-core/src/util/__tests__/MongoBinaryDownloadUrl.test.ts b/packages/mongodb-memory-server-core/src/util/__tests__/MongoBinaryDownloadUrl.test.ts
@@ -1,3 +1,4 @@
+import { assertIsError } from '../../__tests__/testUtils/test_utils';
 import { UnknownPlatformError, UnknownArchitectureError } from '../errors';
 import { LinuxOS } from '../getos';
 import MongoBinaryDownloadUrl from '../MongoBinaryDownloadUrl';
@@ -573,6 +574,7 @@ describe('MongoBinaryDownloadUrl', () => {
         await du.getArchiveName();
         fail('Expected "getArchiveName" to throw');
       } catch (err) {
+        assertIsError(err);
         expect(err).toBeInstanceOf(UnknownPlatformError);
         expect(err.message).toMatchSnapshot();
       }
@@ -588,6 +590,7 @@ describe('MongoBinaryDownloadUrl', () => {
         });
         fail('Expected "translatePlatform" to throw');
       } catch (err) {
+        assertIsError(err);
         expect(err).toBeInstanceOf(UnknownPlatformError);
         expect(err.message).toMatchSnapshot();
       }
@@ -822,6 +825,7 @@ describe('MongoBinaryDownloadUrl', () => {
         MongoBinaryDownloadUrl.translateArch('ia32', 'darwin');
         fail('Expected "translateArch" to fail');
       } catch (err) {
+        assertIsError(err);
         expect(err).toBeInstanceOf(UnknownArchitectureError);
         expect(err.message).toMatchSnapshot();
       }
@@ -832,6 +836,7 @@ describe('MongoBinaryDownloadUrl', () => {
         MongoBinaryDownloadUrl.translateArch('risc', 'linux');
         fail('Expected "translateArch" to fail');
       } catch (err) {
+        assertIsError(err);
         expect(err).toBeInstanceOf(UnknownArchitectureError);
         expect(err.message).toMatchSnapshot();
       }
diff --git a/packages/mongodb-memory-server-core/src/util/__tests__/MongoInstance.test.ts b/packages/mongodb-memory-server-core/src/util/__tests__/MongoInstance.test.ts
@@ -5,6 +5,7 @@ import MongodbInstance, { MongoInstanceEvents } from '../MongoInstance';
 import resolveConfig, { ResolveConfigVariables } from '../resolveConfig';
 import getPort from 'get-port';
 import { StartBinaryFailedError } from '../errors';
+import { assertIsError } from '../../__tests__/testUtils/test_utils';
 
 jest.setTimeout(100000); // 10s
 tmp.setGracefulCleanup();
@@ -109,7 +110,8 @@ describe('MongodbInstance', () => {
         inst.prepareCommandArgs();
         fail('Expected prepareCommandArgs to throw');
       } catch (err) {
-        expect(err.message).toEqual('"instanceOpts.port" is required to be set!');
+        assertIsError(err);
+        expect(err.message).toMatchSnapshot();
       }
     });
 
@@ -123,7 +125,8 @@ describe('MongodbInstance', () => {
         inst.prepareCommandArgs();
         fail('Expected prepareCommandArgs to throw');
       } catch (err) {
-        expect(err.message).toEqual('"instanceOpts.dbPath" is required to be set!');
+        assertIsError(err);
+        expect(err.message).toMatchSnapshot();
       }
     });
 
diff --git a/packages/mongodb-memory-server-core/src/util/__tests__/__snapshots__/MongoBinary.test.ts.snap b/packages/mongodb-memory-server-core/src/util/__tests__/__snapshots__/MongoBinary.test.ts.snap
@@ -0,0 +1,5 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`MongoBinary getPath should not trigger an download an error if "RUNTIME_DOWNLOAD" is false and no binary is found 1`] = `"MongoBinary.getPath: could not find an valid binary path! (Got: \\"undefined\\", RUNTIME_DOWNLOAD: \\"false\\")"`;
+
+exports[`MongoBinary getPath systemBinary should throw an error if SYSTEM_BINARY is set, but no binary can be found 1`] = `"Option \\"SYSTEM_BINARY\\" was set, but binaryPath was empty! (system binary could not be found?) [This Error should normally not be thrown, please report this]"`;
diff --git a/packages/mongodb-memory-server-core/src/util/__tests__/__snapshots__/MongoInstance.test.ts.snap b/packages/mongodb-memory-server-core/src/util/__tests__/__snapshots__/MongoInstance.test.ts.snap
@@ -1,3 +1,7 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
 exports[`MongodbInstance "_launchMongod" should throw an error if "mongodProcess.pid" is undefined 1`] = `"{\\"binary\\":\\"/tmp/thisShouldNotExist\\"}"`;
+
+exports[`MongodbInstance prepareCommandArgs should throw an error if no dbpath is provided 1`] = `"\\"instanceOpts.dbPath\\" is required to be set!"`;
+
+exports[`MongodbInstance prepareCommandArgs should throw an error if no port is provided 1`] = `"\\"instanceOpts.port\\" is required to be set!"`;
diff --git a/packages/mongodb-memory-server-core/src/util/__tests__/__snapshots__/utils.test.ts.snap b/packages/mongodb-memory-server-core/src/util/__tests__/__snapshots__/utils.test.ts.snap
@@ -0,0 +1,3 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`utils assertion should throw default error if none provided 1`] = `"Assert failed - no custom error"`;
diff --git a/packages/mongodb-memory-server-core/src/util/__tests__/lockfile.test.ts b/packages/mongodb-memory-server-core/src/util/__tests__/lockfile.test.ts
@@ -4,6 +4,7 @@ import * as path from 'path';
 import { pathExists } from '../utils';
 import { promises as fspromises } from 'fs';
 import { UnknownLockfileStatusError } from '../errors';
+import { assertIsError } from '../../__tests__/testUtils/test_utils';
 
 let tmpDir: tmp.DirResult;
 beforeAll(() => {
@@ -106,6 +107,7 @@ describe('LockFile', () => {
         fail('Expected "lock" to fail');
       } catch (err) {
         expect(err).toBeInstanceOf(UnknownLockfileStatusError);
+        assertIsError(err);
         expect(err.message).toMatchSnapshot();
       }
     });
@@ -136,6 +138,7 @@ describe('LockFile', () => {
         fail('Expected "waitForLock" to fail');
       } catch (err) {
         expect(err).toBeInstanceOf(UnknownLockfileStatusError);
+        assertIsError(err);
         expect(err.message).toMatchSnapshot();
       }
     });
diff --git a/packages/mongodb-memory-server-core/src/util/__tests__/utils.test.ts b/packages/mongodb-memory-server-core/src/util/__tests__/utils.test.ts
diff --git a/packages/mongodb-memory-server-core/src/util/lockfile.ts b/packages/mongodb-memory-server-core/src/util/lockfile.ts
diff --git a/packages/mongodb-memory-server-core/src/util/utils.ts b/packages/mongodb-memory-server-core/src/util/utils.ts
diff --git a/yarn.lock b/yarn.lock
