address PR comments

Author: bpholt

build.sbt

@@ -101,8 +101,15 @@ lazy val lambda = crossProject(JSPlatform, JVMPlatform)
       "io.circe" %%% "circe-literal" % circeVersion % Test
     ),
     mimaBinaryIssueFilters ++= Seq(
-      ProblemFilters.exclude[IncompatibleMethTypeProblem]("feral.lambda.ClientContext#Impl.*"),
-      ProblemFilters.exclude[IncompatibleResultTypeProblem]("feral.lambda.ClientContext#Impl.*")
+      ProblemFilters.exclude[ReversedMissingMethodProblem](
+        "feral.lambda.ClientContext.clientOption"
+      ), // ClientContext is sealed
+      ProblemFilters.exclude[IncompatibleMethTypeProblem](
+        "feral.lambda.ClientContext#Impl.*"
+      ), // ClientContext#Impl is private
+      ProblemFilters.exclude[IncompatibleResultTypeProblem](
+        "feral.lambda.ClientContext#Impl.*"
+      ) // ClientContext#Impl is private
     )
   )
   .settings(commonSettings)

lambda/js/src/test/scala/feral/lambda/ContextPlatformSuite.scala

@@ -32,8 +32,6 @@ import scala.scalajs.js.JSConverters._
 
 class ContextPlatformSuite extends CatsEffectSuite with ScalaCheckEffectSuite {
 
-  override def scalaCheckInitialSeed = "Knv3rf_mveQ7dlnyIzRvKi0xdjT6D--8sOcl_v2-1uH="
-
   private val genCognitoIdentity: Gen[facade.CognitoIdentity] =
     for {
       identityId <- Gen.alphaNumStr
@@ -191,9 +189,9 @@ class ContextPlatformSuite extends CatsEffectSuite with ScalaCheckEffectSuite {
   private implicit val compareClientContext: Compare[ClientContext, facade.ClientContext] =
     new Compare[ClientContext, facade.ClientContext] {
       override def isEqual(obtained: ClientContext, expected: facade.ClientContext): Boolean =
-        (obtained.maybeClient, expected.client.toOption)
+        (obtained.clientOption, expected.client.toOption)
           .mapN(implicitly[Compare[ClientContextClient, facade.ClientContextClient]].isEqual)
-          .getOrElse(obtained.maybeClient.isEmpty && expected.client.isEmpty) &&
+          .getOrElse(obtained.clientOption.isEmpty && expected.client.isEmpty) &&
           implicitly[Compare[ClientContextEnv, facade.ClientContextEnv]]
             .isEqual(obtained.env, expected.env) &&
           implicitly[Compare[JsonObject, js.UndefOr[js.Any]]]

lambda/jvm/src/test/scala/feral/lambda/ContextPlatformSuite.scala

@@ -214,9 +214,9 @@ class ContextPlatformSuite extends CatsEffectSuite with ScalaCheckEffectSuite {
   private implicit val compareClientContext: Compare[ClientContext, runtime.ClientContext] =
     new Compare[ClientContext, runtime.ClientContext] {
       override def isEqual(obtained: ClientContext, expected: runtime.ClientContext): Boolean =
-        (obtained.maybeClient, Option(expected.getClient))
+        (obtained.clientOption, Option(expected.getClient))
           .mapN(implicitly[Compare[ClientContextClient, runtime.Client]].isEqual)
-          .getOrElse(obtained.maybeClient.isEmpty && expected.getClient == null) &&
+          .getOrElse(obtained.clientOption.isEmpty && expected.getClient == null) &&
           implicitly[Compare[ClientContextEnv, util.Map[String, String]]]
             .isEqual(obtained.env, expected.getEnvironment) &&
           implicitly[Compare[JsonObject, util.Map[String, String]]]

lambda/shared/src/main/scala/feral/lambda/Context.scala

@@ -19,7 +19,6 @@ package feral.lambda
 import cats.Applicative
 import cats.~>
 import io.circe.JsonObject
-import org.typelevel.scalaccompat.annotation.nowarn
 
 import scala.concurrent.duration.FiniteDuration
 
@@ -113,11 +112,11 @@ object CognitoIdentity {
 
 sealed abstract class ClientContext {
   @deprecated(
-    "Use maybeClient, because it's possible this will be populated with empty strings if no client context was received",
+    "Use clientOption, because this will be populated with empty strings if no client context was received",
     "0.3.2")
-  def client: ClientContextClient
-  @nowarn("cat=deprecation")
-  def maybeClient: Option[ClientContextClient] = Option(client)
+  def client: ClientContextClient =
+    clientOption.getOrElse(ClientContextClient("", "", "", "", ""))
+  def clientOption: Option[ClientContextClient]
   def env: ClientContextEnv
   def custom: JsonObject
 }
@@ -144,13 +143,10 @@ object ClientContext {
     Impl(client, env, custom)
 
   private final case class Impl(
-      override val maybeClient: Option[ClientContextClient],
+      override val clientOption: Option[ClientContextClient],
       env: ClientContextEnv,
       custom: JsonObject
   ) extends ClientContext {
-    override def client: ClientContextClient =
-      maybeClient.getOrElse(ClientContextClient("", "", "", "", ""))
-
     override def productPrefix = "ClientContext"
   }
 }