Scalafix test failing on Windows due to CRLF line endings? #630
Unanswered
Piyush-t24
asked this question in
Q&A
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Hi! I'm exploring the Feral repo.
While running the tests on Windows, I noticed one scalafix rewrite test failing (RuleSuite / V0_3_0Rewrites.scala). After digging a bit, it seems related to line endings: the repo currently doesn’t have a
.gitattributesfile, and withcore.autocrlf=trueGit checks files out as CRLF on Windows. Since scalafix rewrite tests compare snapshots, the mix of CRLF input and LF output can introduce extra blank lines in the obtained result.I also noticed that several Typelevel repos don’t have a
.gitattributesfile, so contributors working on Windows might run into similar issues.Do you think adding a
.gitattributes(e.g. enforcing LF for Scala/sbt sources) would be a good approach for cross-platform compatibility, or is there another recommended way to handle this?@armanbilge @bpholt
Beta Was this translation helpful? Give feedback.
All reactions