Skip to content

Commit 7ed2485

Browse files
committed
Cleanup
1 parent 3937918 commit 7ed2485

File tree

4 files changed

+9
-18
lines changed

4 files changed

+9
-18
lines changed

codegen/src/main/scala/fs2/grpc/codegen/Fs2CodeGenerator.scala

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -140,15 +140,14 @@ object Fs2CodeGenerator extends CodeGenApp {
140140
paramsAndUnparsed <- GeneratorParams.fromStringCollectUnrecognized(params)
141141
params = paramsAndUnparsed._1
142142
unparsed = paramsAndUnparsed._2
143-
suffix <- unparsed
144-
.map(_.split("=", 2).toList)
145-
.foldLeft[Either[String, Fs2Params]](Right(Fs2Params.default.withScala3Sources(params.scala3Sources))) {
146-
case (Right(params), ServiceSuffix :: suffix :: Nil) => Right(params.withServiceSuffix(suffix))
147-
case (Right(params), DisableTrailers :: Nil) => Right(params.withDisableTrailers(true))
148-
case (Right(params), RenderContextAsImplicit :: Nil) => Right(params.withRenderContextAsImplicit(true))
149-
case (Right(_), xs) => Left(s"Unrecognized parameter: $xs")
150-
case (Left(e), _) => Left(e)
151-
}
143+
initial = Fs2Params.default.withScala3Sources(params.scala3Sources)
144+
suffix <- unparsed.map(_.split("=", 2).toList).foldLeft[Either[String, Fs2Params]](Right(initial)) {
145+
case (Right(params), ServiceSuffix :: suffix :: Nil) => Right(params.withServiceSuffix(suffix))
146+
case (Right(params), DisableTrailers :: Nil) => Right(params.withDisableTrailers(true))
147+
case (Right(params), RenderContextAsImplicit :: Nil) => Right(params.withRenderContextAsImplicit(true))
148+
case (Right(_), xs) => Left(s"Unrecognized parameter: $xs")
149+
case (Left(e), _) => Left(e)
150+
}
152151
} yield (params, suffix)
153152

154153
def process(request: CodeGenRequest): CodeGenResponse = {

codegen/src/main/scala/fs2/grpc/codegen/Fs2GrpcExhaustiveTrailersServicePrinter.scala

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,6 @@ class Fs2GrpcExhaustiveTrailersServicePrinter(
3434
import fs2.grpc.codegen.Fs2AbstractServicePrinter.constants._
3535
import di._
3636

37-
// for binary compatibility
38-
def this(service: ServiceDescriptor, serviceSuffix: String, di: DescriptorImplicits) =
39-
this(service, serviceSuffix, false, false, di)
40-
4137
override protected def serviceMethodSignature(method: MethodDescriptor): String = {
4238

4339
val scalaInType = method.inputType.scalaType

codegen/src/main/scala/fs2/grpc/codegen/Fs2GrpcServicePrinter.scala

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,6 @@ class Fs2GrpcServicePrinter(
3434
import fs2.grpc.codegen.Fs2AbstractServicePrinter.constants._
3535
import di._
3636

37-
// for binary compatibility
38-
def this(service: ServiceDescriptor, serviceSuffix: String, di: DescriptorImplicits) =
39-
this(service, serviceSuffix, false, false, di)
40-
4137
override protected def serviceMethodSignature(method: MethodDescriptor): String = {
4238

4339
val scalaInType = method.inputType.scalaType

plugin/src/main/scala/fs2/grpc/codegen/Fs2GrpcPlugin.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ object Fs2GrpcPlugin extends AutoPlugin {
8888
* }}}
8989
*/
9090
case object Fs2GrpcRenderContextAsImplicit extends CodeGeneratorOption {
91-
override def toString: String = "fs2_grpc:disable_trailers"
91+
override def toString: String = "fs2_grpc:render_context_as_implicit"
9292
}
9393
}
9494

0 commit comments

Comments
 (0)