Merge pull request #3312 from armanbilge/fix/js-tmp-file

Fix temporary file name generation on Node.js

Author: mpilquist

io/js/src/main/scala/fs2/io/file/FilesPlatform.scala

@@ -123,8 +123,8 @@ private[fs2] trait FilesCompanionPlatform {
         permissions: Option[Permissions]
     ): F[Path] =
       for {
-        dir <- createTempDirectory(dir, prefix, permissions)
-        path = dir / Option(suffix).filter(_.nonEmpty).getOrElse(".tmp")
+        dir <- createTempDirectory(dir, "", permissions)
+        path = dir / (prefix + suffix)
         _ <- open(path, Flags.Write).use_
         _ <- permissions
           .collect { case posix @ PosixPermissions(_) =>

io/shared/src/test/scala/fs2/io/file/FilesSuite.scala

@@ -374,7 +374,7 @@ class FilesSuite extends Fs2IoSuite with BaseFileSuite {
         .use { tempDir =>
           val files = Files[IO]
           files
-            .tempFile(Some(tempDir), "", "", None)
+            .tempFile(Some(tempDir), "tmp", "", None)
             .use { file =>
               // files.exists(tempDir / file.fileName)
               IO.pure(file.startsWith(tempDir))
@@ -396,6 +396,16 @@ class FilesSuite extends Fs2IoSuite with BaseFileSuite {
         }
         .assertEquals(true)
     }
+
+    test("filename should begin with prefix and end with suffix") {
+      Files[IO].tempFile(None, "prefix", "suffix", None).use { path =>
+        IO {
+          val fn = path.fileName.toString
+          assert(clue(fn).startsWith("prefix"))
+          assert(clue(fn).endsWith("suffix"))
+        }
+      }
+    }
   }
 
   group("tempDirectoryStream") {