Skip to content

Commit 5906fa9

Browse files
authored
Merge pull request #3145 from typelevel/pr/js-disable-old-tls-tests
Don't test TLSv1, v1.1 on Node.js, fix JVM TLS error test
2 parents e7241a7 + 84fe1a9 commit 5906fa9

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

io/js/src/test/scala/fs2/io/net/tls/TLSSocketSuite.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ class TLSSocketSuite extends TLSSuite {
9797
.assertEquals(httpOk)
9898
}
9999

100-
List(TLSv1, `TLSv1.1`, `TLSv1.2`, `TLSv1.3`).foreach { protocol =>
100+
List(`TLSv1.2`, `TLSv1.3`).foreach { protocol =>
101101
writesBeforeReading(protocol)
102102
readsBeforeWriting(protocol)
103103
}
@@ -231,7 +231,7 @@ class TLSSocketSuite extends TLSSuite {
231231
.intercept[SSLException]
232232
}
233233

234-
List(TLSv1, `TLSv1.1`, `TLSv1.2`, `TLSv1.3`).foreach { protocol =>
234+
List(`TLSv1.2`, `TLSv1.3`).foreach { protocol =>
235235
test(s"$protocol - applicationProtocol and session") {
236236
val msg = Chunk.array(("Hello, world! " * 20000).getBytes)
237237

io/jvm/src/test/scala/fs2/io/net/tls/TLSSocketSuite.scala

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,8 @@ class TLSSocketSuite extends TLSSuite {
172172
Stream.exec(clientSocket.write(msg)).onFinalize(clientSocket.endOfOutput) ++
173173
clientSocket.reads.take(msg.size.toLong)
174174

175-
client.concurrently(echoServer)
175+
// client gets closed pipe error when server gets handshake ex
176+
client.mask.concurrently(echoServer)
176177
}
177178
.compile
178179
.to(Chunk)

0 commit comments

Comments
 (0)