Skip to content

Commit 8687fdc

Browse files
authored
Merge pull request #3137 from danicheg/scope-tweaks
Tweak `Scope#close` for a bit better performance
2 parents 15412d6 + 27d9088 commit 8687fdc

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

core/shared/src/main/scala/fs2/internal/Scope.scala

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -266,13 +266,7 @@ private[fs2] final class Scope[F[_]] private (
266266
resultResources <- traverseError[ScopedResource[F]](previous.resources, _.release(ec))
267267
_ <- self.interruptible.map(_.cancelParent).getOrElse(F.unit)
268268
_ <- self.parent.fold(F.unit)(_.releaseChildScope(self.id))
269-
} yield {
270-
val results = resultChildren.fold(List(_), _ => Nil) ++ resultResources.fold(
271-
List(_),
272-
_ => Nil
273-
)
274-
CompositeFailure.fromList(results.toList).toLeft(())
275-
}
269+
} yield CompositeFailure.fromResults(resultChildren, resultResources)
276270
case _: Scope.State.Closed[F] => F.pure(Right(()))
277271
}
278272

0 commit comments

Comments
 (0)