fix: validate some more bad cases in typings (#290)

Author: Vampire

src/jvmMain/kotlin/it/krzeminski/githubactionstyping/parsing/TypesManifestParsing.kt

@@ -29,6 +29,10 @@ fun parseTypesManifest(manifestString: String): Result<TypesManifest> =
             null -> TypesManifest()
 
             is Map<*, *> -> {
+                val excessKeys = loadedTypesManifest.keys - listOf("inputs", "outputs")
+                if (excessKeys.isNotEmpty()) {
+                    throw ValidationException(excessKeys.joinToString(prefix = "Excess keys: ", postfix = "."))
+                }
                 TypesManifest(
                     inputs = loadedTypesManifest.toInputsOrOutputs("inputs"),
                     outputs = loadedTypesManifest.toInputsOrOutputs("outputs"),
@@ -55,19 +59,40 @@ private fun Any?.toApiItem(key: String): ApiItem =
         null -> ApiItem()
 
         is Map<*, *> -> {
+            val excessKeys = keys - listOf(
+                "type",
+                "name",
+                "allowed-values",
+                "separator",
+                "named-values",
+                "list-item",
+            )
+            if (excessKeys.isNotEmpty()) {
+                throw ValidationException(excessKeys.joinToString(prefix = "Excess keys: ", postfix = "."))
+            }
+
             ApiItem(
                 type = get("type")?.let {
-                    "$it"
+                    if (it !is String) {
+                        throw ValidationException("type must be a string.")
+                    }
+                    it
                 },
                 name = get("name")?.let {
-                    "$it"
+                    if (it !is String) {
+                        throw ValidationException("name must be a string.")
+                    }
+                    it
                 },
                 allowedValues = get("allowed-values")?.let {
                     if (it !is List<*>) {
                         throw ValidationException("allowed-values must be a sequence.")
                     }
                     it.map {
-                        "$it"
+                        if (it !is String) {
+                            throw ValidationException("Allowed Value must be string.")
+                        }
+                        it
                     }
                 },
                 separator = get("separator")?.let {

src/test/resources/bad-typings/excess_input_keys.yml

@@ -0,0 +1,12 @@
+# yaml-language-server: $schema=../../../../github-actions-typing.schema.json
+# See https://github.com/typesafegithub/github-actions-typing
+inputs:
+  foo:
+    type: string
+    bar:
+    baz:
+
+# Expected validation error
+#
+#Excess keys: bar, baz.
+#

src/test/resources/bad-typings/excess_output_keys.yml

@@ -0,0 +1,12 @@
+# yaml-language-server: $schema=../../../../github-actions-typing.schema.json
+# See https://github.com/typesafegithub/github-actions-typing
+outputs:
+  foo:
+    type: string
+    bar:
+    baz:
+
+# Expected validation error
+#
+#Excess keys: bar, baz.
+#

src/test/resources/bad-typings/excess_top_level_keys.yml

@@ -0,0 +1,9 @@
+# yaml-language-server: $schema=../../../../github-actions-typing.schema.json
+# See https://github.com/typesafegithub/github-actions-typing
+foo:
+bar:
+
+# Expected validation error
+#
+#Excess keys: foo, bar.
+#

src/test/resources/bad-typings/inputs_enum_list_item_with_non_string_allowed_value.yml

@@ -0,0 +1,15 @@
+# yaml-language-server: $schema=../../../../github-actions-typing.schema.json
+# See https://github.com/typesafegithub/github-actions-typing
+inputs:
+  granted-scopes:
+    type: list
+    separator: ','
+    list-item:
+      type: enum
+      allowed-values:
+        - 0x0
+
+# Expected validation error
+#
+#Allowed Value must be string.
+#

src/test/resources/bad-typings/inputs_enum_list_item_with_non_string_name.yml

@@ -0,0 +1,17 @@
+# yaml-language-server: $schema=../../../../github-actions-typing.schema.json
+# See https://github.com/typesafegithub/github-actions-typing
+inputs:
+  granted-scopes:
+    type: list
+    separator: ','
+    list-item:
+      type: enum
+      name: 0x0
+      allowed-values:
+        - read
+        - write
+
+# Expected validation error
+#
+#name must be a string.
+#

src/test/resources/bad-typings/inputs_enum_with_non_string_allowed_value.yml

@@ -0,0 +1,12 @@
+# yaml-language-server: $schema=../../../../github-actions-typing.schema.json
+# See https://github.com/typesafegithub/github-actions-typing
+inputs:
+  permissions:
+    type: enum
+    allowed-values:
+      - 0o0
+
+# Expected validation error
+#
+#Allowed Value must be string.
+#

src/test/resources/bad-typings/inputs_enum_with_non_string_name.yml

@@ -0,0 +1,15 @@
+# yaml-language-server: $schema=../../../../github-actions-typing.schema.json
+# See https://github.com/typesafegithub/github-actions-typing
+inputs:
+  permissions:
+    type: enum
+    name: 0o0
+    allowed-values:
+      - user
+      - admin
+      - guest
+
+# Expected validation error
+#
+#name must be a string.
+#

src/test/resources/bad-typings/inputs_integer_list_item_with_non_string_name.yml

@@ -0,0 +1,16 @@
+# yaml-language-server: $schema=../../../../github-actions-typing.schema.json
+# See https://github.com/typesafegithub/github-actions-typing
+inputs:
+  list-of-integer:
+    type: list
+    separator: ','
+    list-item:
+      type: integer
+      name: 0x0
+      named-values:
+        foo: 0
+
+# Expected validation error
+#
+#name must be a string.
+#

src/test/resources/bad-typings/inputs_integer_with_non_string_name.yml

@@ -0,0 +1,13 @@
+# yaml-language-server: $schema=../../../../github-actions-typing.schema.json
+# See https://github.com/typesafegithub/github-actions-typing
+inputs:
+  retries:
+    type: integer
+    name: 0o0
+    named-values:
+      foo: 0
+
+# Expected validation error
+#
+#name must be a string.
+#