fix(abg): strip off all non-Java identifier chars when building identifiers (#1926)

Author: Vampire

action-binding-generator/src/main/kotlin/io/github/typesafegithub/workflows/actionbindinggenerator/utils/TextUtils.kt

@@ -2,12 +2,14 @@ package io.github.typesafegithub.workflows.actionbindinggenerator.utils
 
 import java.util.Locale
 
+private val normalizationSplitRegex = """[^\p{javaJavaIdentifierStart}\p{javaJavaIdentifierPart}&&[^_]]++""".toRegex()
+
 internal fun String.toPascalCase(): String {
     val hasOnlyUppercases = none { it in 'a'..'z' }
     val normalizedString = if (hasOnlyUppercases) lowercase() else this
     return normalizedString
         .replace("+", "-plus-")
-        .split("-", "_", " ", ".", "/")
+        .split(normalizationSplitRegex)
         .joinToString("") {
             it.replaceFirstChar { if (it.isLowerCase()) it.titlecase(Locale.getDefault()) else it.toString() }
         }

action-binding-generator/src/test/kotlin/io/github/typesafegithub/workflows/actionbindinggenerator/bindingsfromunittests/ActionWithAllTypesOfInputs.kt

@@ -307,6 +307,8 @@ public data class ActionWithAllTypesOfInputs private constructor(
 
         public object Baz123 : ActionWithAllTypesOfInputs.Bin("baz123")
 
+        public object Bam123 : ActionWithAllTypesOfInputs.Bin("bam:123")
+
         public class Custom(
             customStringValue: String,
         ) : ActionWithAllTypesOfInputs.Bin(customStringValue)

action-binding-generator/src/test/kotlin/io/github/typesafegithub/workflows/actionbindinggenerator/generation/GenerationTest.kt

@@ -96,7 +96,7 @@ class GenerationTest :
                 "bin-kin" to BooleanTyping,
                 "int-pint" to IntegerTyping,
                 "flo-pint" to FloatTyping,
-                "fin-bin" to EnumTyping("Bin", listOf("foo", "boo-bar", "baz123")),
+                "fin-bin" to EnumTyping("Bin", listOf("foo", "boo-bar", "baz123", "bam:123")),
                 "goo-zen" to IntegerWithSpecialValueTyping("Zen", mapOf("Special1" to 3, "Special2" to -1)),
                 "bah-enum" to EnumTyping(null, listOf("helloworld"), listOf("HelloWorld")),
                 "list-strings" to ListOfTypings(",", StringTyping),