Use Optional

Author: krzema12

jit-binding-server/src/main/kotlin/io/github/typesafegithub/workflows/jitbindingserver/ArtifactRoutes.kt

@@ -25,9 +25,13 @@ import io.micrometer.prometheusmetrics.PrometheusMeterRegistry
 import kotlinx.coroutines.CoroutineScope
 import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.launch
+import java.util.Optional
+import kotlin.jvm.optionals.getOrNull
 
 private val logger = logger { }
 
+typealias CachedVersionArtifact = Optional<VersionArtifacts>
+
 private val prefetchScope = CoroutineScope(Dispatchers.IO)
 
 fun Routing.artifactRoutes(
@@ -118,7 +122,7 @@ private suspend fun ApplicationCall.toBindingArtifacts(
     if (refresh) {
         bindingsCache.invalidate(actionCoords)
     }
-    return bindingsCache.get(actionCoords).toNullableVersionArtifacts()
+    return bindingsCache.get(actionCoords).getOrNull()
 }
 
 private fun PrometheusMeterRegistry.incrementArtifactCounter(

jit-binding-server/src/main/kotlin/io/github/typesafegithub/workflows/jitbindingserver/CachedVersionArtifact.kt

@@ -26,6 +26,7 @@ import io.micrometer.core.instrument.Tag
 import io.micrometer.prometheusmetrics.PrometheusConfig
 import io.micrometer.prometheusmetrics.PrometheusMeterRegistry
 import java.time.Duration
+import java.util.Optional
 import kotlin.time.Duration.Companion.hours
 
 private val logger =
@@ -109,7 +110,7 @@ private fun buildBindingsCache(
         .newBuilder()
         .refreshAfterWrite(1.hours)
         .recordStats()
-        .asLoadingCache { buildVersionArtifacts(it, httpClient).toCachedVersionArtifact() }
+        .asLoadingCache { Optional.ofNullable(buildVersionArtifacts(it, httpClient)) }
 
 @Suppress("ktlint:standard:function-signature") // Conflict with detekt.
 private fun buildMetadataCache(