fix(server): treat failed binding generation as internal server error (#1924)

Before this PR, it was treated equally if a binding could not be found,
and if some exception happened during initial creating of the binding.
The exceptions were swallowed and the client received a 404 response.
If there was for example a compile error you already got internal server
error.
But if for example Kotlin Poet throws an illegal argument exception,
then this did not propagate properly

Now exceptions are logged and the client gets an internal server error
if some exception happened and only a 404 if indeed the action was not
found.

One such example is, if a typing has an `enum` with some option that
contains a colon.
This resulted in an identifier generated that contains a colon which
then produces an
exception due to the illegal identifier character.

---------

Co-authored-by: Piotr Krzemiński <[email protected]>
Co-authored-by: Piotr Krzeminski <[email protected]>

Author: Vampire

jit-binding-server/src/main/kotlin/io/github/typesafegithub/workflows/jitbindingserver/ArtifactRoutes.kt

@@ -32,7 +32,7 @@ import kotlin.time.Duration.Companion.hours
 
 private val logger = logger { }
 
-typealias ArtifactResult = Result<Map<String, Artifact>>
+typealias ArtifactResult = Result<Map<String, Artifact>?>
 
 private val prefetchScope = CoroutineScope(Dispatchers.IO)
 
@@ -43,7 +43,7 @@ internal fun buildBindingsCache(
         .newBuilder()
         .refreshAfterWrite(1.hours)
         .recordStats()
-        .asLoadingCache<ActionCoords, ArtifactResult> { runCatching { buildVersionArtifacts(it)!! } }
+        .asLoadingCache<ActionCoords, ArtifactResult> { runCatching { buildVersionArtifacts(it) } }
 
 fun Routing.artifactRoutes(
     bindingsCache: LoadingCache<ActionCoords, ArtifactResult>,
@@ -133,7 +133,7 @@ private suspend fun ApplicationCall.toBindingArtifacts(
     if (refresh) {
         bindingsCache.invalidate(actionCoords)
     }
-    return bindingsCache.get(actionCoords).getOrNull()
+    return bindingsCache.get(actionCoords).getOrThrow()
 }
 
 private fun PrometheusMeterRegistry.incrementArtifactCounter(call: ApplicationCall) {

jit-binding-server/src/test/kotlin/io/github/typesafegithub/workflows/jitbindingserver/ArtifactRoutesTest.kt

@@ -27,9 +27,7 @@ class ArtifactRoutesTest :
                     val response = client.get("some-owner/some-action/v4/some-action-v4.pom")
 
                     // Then
-                    // This is incorrect, and will be fixed in
-                    //  https://github.com/typesafegithub/github-workflows-kt/pull/1924/
-                    response.status shouldBe HttpStatusCode.NotFound
+                    response.status shouldBe HttpStatusCode.InternalServerError
                 }
             }
         }