test(abg): exercise JAR mode for all typings (#1335)

krzema12 · web-flow · commit 92f9b6416fe4 · 2024-03-30T23:26:32.000+01:00
To ensure the code compiles fine.
diff --git a/action-binding-generator/src/test/kotlin/io/github/typesafegithub/workflows/actionbindinggenerator/bindingsfromunittests/ActionForGeneratedJar.kt b/action-binding-generator/src/test/kotlin/io/github/typesafegithub/workflows/actionbindinggenerator/bindingsfromunittests/ActionForGeneratedJar.kt
@@ -4,33 +4,43 @@
 @file:Suppress(
     "DataClassPrivateConstructor",
     "UNUSED_PARAMETER",
-    "DEPRECATION",
 )
 
 package io.github.typesafegithub.workflows.actions.johnsmith
 
 import io.github.typesafegithub.workflows.domain.actions.Action
 import io.github.typesafegithub.workflows.domain.actions.RegularAction
 import java.util.LinkedHashMap
-import kotlin.Deprecated
+import kotlin.Boolean
+import kotlin.Float
+import kotlin.Int
 import kotlin.String
 import kotlin.Suppress
 import kotlin.Unit
+import kotlin.collections.List
 import kotlin.collections.Map
 import kotlin.collections.toList
 import kotlin.collections.toTypedArray
 
 /**
  * Action: Do something cool
- * and describe it in multiple lines
  *
  * This is a test description that should be put in the KDoc comment for a class
  *
  * [Action on GitHub](https://github.com/john-smith/action-for-generated-jar)
  *
  * @param fooBar Short description
- * @param bazGoo Just another input
- * with multiline description
+ * @param bazGoo First boolean input!
+ * @param binKin Boolean and nullable
+ * @param intPint Integer
+ * @param floPint Float
+ * @param finBin Enumeration
+ * @param gooZen Integer with special value
+ * @param bahEnum Enum with custom naming
+ * @param listStrings List of strings
+ * @param listInts List of integers
+ * @param listEnums List of enums
+ * @param listIntSpecial List of integer with special values
  * @param _customInputs Type-unsafe map where you can put any inputs that are not yet supported by
  * the binding
  * @param _customVersion Allows overriding action's version, for example to use a specific minor
@@ -42,11 +52,49 @@ public data class ActionForGeneratedJar private constructor(
      */
     public val fooBar: String,
     /**
-     * Just another input
-     * with multiline description
+     * First boolean input!
      */
-    @Deprecated("this is deprecated")
-    public val bazGoo: ActionForGeneratedJar.BazGoo,
+    public val bazGoo: Boolean,
+    /**
+     * Boolean and nullable
+     */
+    public val binKin: Boolean? = null,
+    /**
+     * Integer
+     */
+    public val intPint: Int,
+    /**
+     * Float
+     */
+    public val floPint: Float,
+    /**
+     * Enumeration
+     */
+    public val finBin: ActionForGeneratedJar.Bin,
+    /**
+     * Integer with special value
+     */
+    public val gooZen: ActionForGeneratedJar.Zen,
+    /**
+     * Enum with custom naming
+     */
+    public val bahEnum: ActionForGeneratedJar.BahEnum,
+    /**
+     * List of strings
+     */
+    public val listStrings: List<String>? = null,
+    /**
+     * List of integers
+     */
+    public val listInts: List<Int>? = null,
+    /**
+     * List of enums
+     */
+    public val listEnums: List<ActionForGeneratedJar.MyEnum>? = null,
+    /**
+     * List of integer with special values
+     */
+    public val listIntSpecial: List<ActionForGeneratedJar.MyInt>? = null,
     /**
      * Type-unsafe map where you can put any inputs that are not yet supported by the binding
      */
@@ -61,30 +109,103 @@ public data class ActionForGeneratedJar private constructor(
     public constructor(
         vararg pleaseUseNamedArguments: Unit,
         fooBar: String,
-        bazGoo: ActionForGeneratedJar.BazGoo,
+        bazGoo: Boolean,
+        binKin: Boolean? = null,
+        intPint: Int,
+        floPint: Float,
+        finBin: ActionForGeneratedJar.Bin,
+        gooZen: ActionForGeneratedJar.Zen,
+        bahEnum: ActionForGeneratedJar.BahEnum,
+        listStrings: List<String>? = null,
+        listInts: List<Int>? = null,
+        listEnums: List<ActionForGeneratedJar.MyEnum>? = null,
+        listIntSpecial: List<ActionForGeneratedJar.MyInt>? = null,
         _customInputs: Map<String, String> = mapOf(),
         _customVersion: String? = null,
-    ) : this(fooBar=fooBar, bazGoo=bazGoo, _customInputs=_customInputs,
-            _customVersion=_customVersion)
+    ) : this(fooBar=fooBar, bazGoo=bazGoo, binKin=binKin, intPint=intPint, floPint=floPint,
+            finBin=finBin, gooZen=gooZen, bahEnum=bahEnum, listStrings=listStrings,
+            listInts=listInts, listEnums=listEnums, listIntSpecial=listIntSpecial,
+            _customInputs=_customInputs, _customVersion=_customVersion)
 
     @Suppress("SpreadOperator")
     override fun toYamlArguments(): LinkedHashMap<String, String> = linkedMapOf(
         *listOfNotNull(
             "foo-bar" to fooBar,
-            "baz-goo" to bazGoo.stringValue,
+            "baz-goo" to bazGoo.toString(),
+            binKin?.let { "bin-kin" to it.toString() },
+            "int-pint" to intPint.toString(),
+            "flo-pint" to floPint.toString(),
+            "fin-bin" to finBin.stringValue,
+            "goo-zen" to gooZen.integerValue.toString(),
+            "bah-enum" to bahEnum.stringValue,
+            listStrings?.let { "list-strings" to it.joinToString(",") },
+            listInts?.let { "list-ints" to it.joinToString(",") { it.toString() } },
+            listEnums?.let { "list-enums" to it.joinToString(",") { it.stringValue } },
+            listIntSpecial?.let { "list-int-special" to it.joinToString(",") {
+                    it.integerValue.toString() } },
             *_customInputs.toList().toTypedArray(),
         ).toTypedArray()
     )
 
     override fun buildOutputObject(stepId: String): Action.Outputs = Outputs(stepId)
 
-    public sealed class BazGoo(
+    public sealed class Bin(
         public val stringValue: String,
     ) {
-        public object HelloWorld : ActionForGeneratedJar.BazGoo("helloworld")
+        public object Foo : ActionForGeneratedJar.Bin("foo")
+
+        public object BooBar : ActionForGeneratedJar.Bin("boo-bar")
+
+        public object Baz123 : ActionForGeneratedJar.Bin("baz123")
 
         public class Custom(
             customStringValue: String,
-        ) : ActionForGeneratedJar.BazGoo(customStringValue)
+        ) : ActionForGeneratedJar.Bin(customStringValue)
+    }
+
+    public sealed class Zen(
+        public val integerValue: Int,
+    ) {
+        public class Value(
+            requestedValue: Int,
+        ) : ActionForGeneratedJar.Zen(requestedValue)
+
+        public object Special1 : ActionForGeneratedJar.Zen(3)
+
+        public object Special2 : ActionForGeneratedJar.Zen(-1)
+    }
+
+    public sealed class BahEnum(
+        public val stringValue: String,
+    ) {
+        public object HelloWorld : ActionForGeneratedJar.BahEnum("helloworld")
+
+        public class Custom(
+            customStringValue: String,
+        ) : ActionForGeneratedJar.BahEnum(customStringValue)
+    }
+
+    public sealed class MyEnum(
+        public val stringValue: String,
+    ) {
+        public object One : ActionForGeneratedJar.MyEnum("one")
+
+        public object Two : ActionForGeneratedJar.MyEnum("two")
+
+        public object Three : ActionForGeneratedJar.MyEnum("three")
+
+        public class Custom(
+            customStringValue: String,
+        ) : ActionForGeneratedJar.MyEnum(customStringValue)
+    }
+
+    public sealed class MyInt(
+        public val integerValue: Int,
+    ) {
+        public class Value(
+            requestedValue: Int,
+        ) : ActionForGeneratedJar.MyInt(requestedValue)
+
+        public object TheAnswer : ActionForGeneratedJar.MyInt(42)
     }
 }
diff --git a/action-binding-generator/src/test/kotlin/io/github/typesafegithub/workflows/actionbindinggenerator/generation/GenerationTest.kt b/action-binding-generator/src/test/kotlin/io/github/typesafegithub/workflows/actionbindinggenerator/generation/GenerationTest.kt
@@ -501,48 +501,17 @@ class GenerationTest : FunSpec({
 
     test("action binding generated for the versioned JAR") {
         // given
-        val actionManifest =
-            Metadata(
-                name =
-                    """
-                    Do something cool
-                    and describe it in multiple lines
-                    """.trimIndent(),
-                description = "This is a test description that should be put in the KDoc comment for a class",
-                inputs =
-                    mapOf(
-                        "foo-bar" to
-                            Input(
-                                description = "Short description",
-                                required = true,
-                                default = null,
-                            ),
-                        "baz-goo" to
-                            Input(
-                                description =
-                                    """
-                                    Just another input
-                                    with multiline description
-                                    """.trimIndent(),
-                                deprecationMessage = "this is deprecated",
-                                required = true,
-                                default = null,
-                            ),
-                    ),
-            )
         val coords = ActionCoords("john-smith", "action-for-generated-jar", "v3")
 
         // when
         val binding =
             coords.generateBinding(
                 metadataRevision = FromLockfile,
-                metadata = actionManifest,
+                metadata = actionManifestWithAllTypesOfInputs,
                 clientType = ClientType.VERSIONED_JAR,
                 inputTypings =
                     Pair(
-                        mapOf(
-                            "baz-goo" to EnumTyping(null, listOf("helloworld"), listOf("HelloWorld")),
-                        ),
+                        typingsForAllTypesOfInputs,
                         ACTION,
                     ),
             )
