Skip to content

Commit b815b78

Browse files
authored
chore(abg): remove typing suggestion (#1379)
It adds some noise, and I'd like the action users to catch such issues since fixing them by a single person doesn't scale. It's a step towards user-driven action requesting.
1 parent c207bac commit b815b78

File tree

3 files changed

+0
-116
lines changed

3 files changed

+0
-116
lines changed

action-binding-generator/src/main/kotlin/io/github/typesafegithub/workflows/actionbindinggenerator/generation/Generation.kt

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ import com.squareup.kotlinpoet.asTypeName
1717
import io.github.typesafegithub.workflows.actionbindinggenerator.domain.ActionCoords
1818
import io.github.typesafegithub.workflows.actionbindinggenerator.domain.MetadataRevision
1919
import io.github.typesafegithub.workflows.actionbindinggenerator.domain.TypingActualSource
20-
import io.github.typesafegithub.workflows.actionbindinggenerator.domain.prettyPrint
2120
import io.github.typesafegithub.workflows.actionbindinggenerator.generation.Properties.CUSTOM_INPUTS
2221
import io.github.typesafegithub.workflows.actionbindinggenerator.generation.Properties.CUSTOM_VERSION
2322
import io.github.typesafegithub.workflows.actionbindinggenerator.metadata.Input
@@ -30,7 +29,6 @@ import io.github.typesafegithub.workflows.actionbindinggenerator.typing.asString
3029
import io.github.typesafegithub.workflows.actionbindinggenerator.typing.buildCustomType
3130
import io.github.typesafegithub.workflows.actionbindinggenerator.typing.getClassName
3231
import io.github.typesafegithub.workflows.actionbindinggenerator.typing.provideTypes
33-
import io.github.typesafegithub.workflows.actionbindinggenerator.typing.suggestAdditionalTypings
3432
import io.github.typesafegithub.workflows.actionbindinggenerator.utils.removeTrailingWhitespacesForEachLine
3533
import io.github.typesafegithub.workflows.actionbindinggenerator.utils.toCamelCase
3634
import io.github.typesafegithub.workflows.actionbindinggenerator.utils.toKotlinPackageName
@@ -79,9 +77,6 @@ public fun ActionCoords.generateBinding(
7977
}
8078

8179
val metadataProcessed = metadata.removeDeprecatedInputsIfNameClash()
82-
metadataProcessed.suggestAdditionalTypings(inputTypings.first.keys)?.let { formatSuggestions ->
83-
println("$prettyPrint I suggest the following typings:\n$formatSuggestions")
84-
}
8580

8681
val className = this.buildActionClassName(includeVersion = clientType == ClientType.BUNDLED_WITH_LIB)
8782
val actionBindingSourceCode =

action-binding-generator/src/main/kotlin/io/github/typesafegithub/workflows/actionbindinggenerator/typing/TypingSuggestions.kt

Lines changed: 0 additions & 48 deletions
This file was deleted.

action-binding-generator/src/test/kotlin/io/github/typesafegithub/workflows/actionbindinggenerator/typing/TypingSuggestionsTest.kt

Lines changed: 0 additions & 63 deletions
This file was deleted.

0 commit comments

Comments
 (0)