Skip to content

Commit db3c8f8

Browse files
authored
chore: use JDK 22 for building (#2075)
Part of #1699. 24 is the newest one, but detekt supports up to 22.
1 parent 1e92c23 commit db3c8f8

File tree

9 files changed

+30
-57
lines changed

9 files changed

+30
-57
lines changed

.github/workflows/build.main.kts

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414

1515
import io.github.typesafegithub.workflows.actions.actions.Cache
1616
import io.github.typesafegithub.workflows.actions.actions.Checkout
17-
import io.github.typesafegithub.workflows.actions.actions.SetupJava
1817
import io.github.typesafegithub.workflows.actions.gradle.ActionsSetupGradle
1918
import io.github.typesafegithub.workflows.domain.RunnerType.UbuntuLatest
2019
import io.github.typesafegithub.workflows.domain.RunnerType.WindowsLatest
@@ -133,14 +132,7 @@ workflow(
133132
runsOn = UbuntuLatest,
134133
) {
135134
uses(action = Checkout())
136-
uses(
137-
name = "Set up Java in proper version",
138-
action = SetupJava(
139-
javaVersion = "17",
140-
distribution = SetupJava.Distribution.Zulu,
141-
cache = SetupJava.BuildPlatform.Gradle,
142-
),
143-
)
135+
setupJava()
144136
run(command = "cd .github/workflows")
145137
run(
146138
name = "Regenerate all workflow YAMLs",

.github/workflows/build.yaml

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,9 @@ jobs:
5555
name: 'Set up JDK'
5656
uses: 'actions/setup-java@v4'
5757
with:
58-
java-version: '11'
58+
java-version: '22'
5959
distribution: 'zulu'
60+
cache: 'gradle'
6061
- id: 'step-3'
6162
uses: 'gradle/actions/setup-gradle@v4'
6263
with:
@@ -82,8 +83,9 @@ jobs:
8283
name: 'Set up JDK'
8384
uses: 'actions/setup-java@v4'
8485
with:
85-
java-version: '11'
86+
java-version: '22'
8687
distribution: 'zulu'
88+
cache: 'gradle'
8789
- id: 'step-3'
8890
uses: 'gradle/actions/setup-gradle@v4'
8991
with:
@@ -109,8 +111,9 @@ jobs:
109111
name: 'Set up JDK'
110112
uses: 'actions/setup-java@v4'
111113
with:
112-
java-version: '11'
114+
java-version: '22'
113115
distribution: 'zulu'
116+
cache: 'gradle'
114117
- id: 'step-2'
115118
uses: 'gradle/actions/setup-gradle@v4'
116119
- id: 'step-3'
@@ -178,10 +181,10 @@ jobs:
178181
- id: 'step-0'
179182
uses: 'actions/checkout@v5'
180183
- id: 'step-1'
181-
name: 'Set up Java in proper version'
184+
name: 'Set up JDK'
182185
uses: 'actions/setup-java@v4'
183186
with:
184-
java-version: '17'
187+
java-version: '22'
185188
distribution: 'zulu'
186189
cache: 'gradle'
187190
- id: 'step-2'

.github/workflows/end-to-end-tests-2nd-workflow.yaml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,9 @@ jobs:
2020
name: 'Set up JDK'
2121
uses: 'actions/setup-java@v4'
2222
with:
23-
java-version: '11'
23+
java-version: '22'
2424
distribution: 'zulu'
25+
cache: 'gradle'
2526
- id: 'step-2'
2627
uses: 'gradle/actions/setup-gradle@v4'
2728
- id: 'step-3'
@@ -45,8 +46,9 @@ jobs:
4546
name: 'Set up JDK'
4647
uses: 'actions/setup-java@v4'
4748
with:
48-
java-version: '11'
49+
java-version: '22'
4950
distribution: 'zulu'
51+
cache: 'gradle'
5052
- id: 'step-2'
5153
uses: 'gradle/actions/setup-gradle@v4'
5254
- id: 'step-3'

.github/workflows/end-to-end-tests.main.kts

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@
1111
@file:DependsOn("Wandalen:wretry.action:v3")
1212
@file:OptIn(ExperimentalKotlinLogicStep::class)
1313

14+
@file:Import("setup-java.main.kts")
15+
1416
import io.github.typesafegithub.workflows.actions.actions.*
1517
import io.github.typesafegithub.workflows.actions.gradle.ActionsSetupGradle
1618
import io.github.typesafegithub.workflows.actions.wandalen.WretryAction
@@ -31,13 +33,7 @@ import io.github.typesafegithub.workflows.updates.reportAvailableUpdates
3133
import java.time.Instant
3234

3335
fun JobBuilder<*>.publishToMavenLocal() {
34-
uses(
35-
name = "Set up JDK",
36-
action = SetupJava(
37-
javaVersion = "11",
38-
distribution = SetupJava.Distribution.Zulu,
39-
),
40-
)
36+
setupJava()
4137
uses(action = ActionsSetupGradle())
4238
run(
4339
name = "Publish to Maven local",

.github/workflows/end-to-end-tests.yaml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,9 @@ jobs:
2222
name: 'Set up JDK'
2323
uses: 'actions/setup-java@v4'
2424
with:
25-
java-version: '11'
25+
java-version: '22'
2626
distribution: 'zulu'
27+
cache: 'gradle'
2728
- id: 'step-2'
2829
uses: 'gradle/actions/setup-gradle@v4'
2930
- id: 'step-3'
@@ -129,8 +130,9 @@ jobs:
129130
name: 'Set up JDK'
130131
uses: 'actions/setup-java@v4'
131132
with:
132-
java-version: '11'
133+
java-version: '22'
133134
distribution: 'zulu'
135+
cache: 'gradle'
134136
- id: 'step-16'
135137
uses: 'gradle/actions/setup-gradle@v4'
136138
- id: 'step-17'

.github/workflows/release.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,9 @@ jobs:
5454
name: 'Set up JDK'
5555
uses: 'actions/setup-java@v4'
5656
with:
57-
java-version: '11'
57+
java-version: '22'
5858
distribution: 'zulu'
59+
cache: 'gradle'
5960
- id: 'step-2'
6061
uses: 'gradle/actions/setup-gradle@v4'
6162
- id: 'step-3'

.github/workflows/setup-java.main.kts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@ fun JobBuilder<*>.setupJava() =
1212
uses(
1313
name = "Set up JDK",
1414
action = SetupJava(
15-
javaVersion = "11",
15+
javaVersion = "22",
1616
distribution = SetupJava.Distribution.Zulu,
17+
cache = SetupJava.BuildPlatform.Gradle,
1718
)
1819
)

buildSrc/src/main/kotlin/buildsrc/convention/kotlin-jvm-server.gradle.kts

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -20,26 +20,10 @@ dependencies {
2020
java {
2121
withJavadocJar()
2222
withSourcesJar()
23-
24-
toolchain {
25-
requiredJdkVersion()
26-
}
27-
}
28-
29-
kotlin {
30-
jvmToolchain {
31-
requiredJdkVersion()
32-
}
33-
}
34-
35-
fun JavaToolchainSpec.requiredJdkVersion() {
36-
languageVersion.set(JavaLanguageVersion.of(17))
3723
}
3824

3925
tasks.withType<KotlinCompile> {
4026
compilerOptions {
41-
jvmTarget.set(JvmTarget.JVM_17)
42-
4327
allWarningsAsErrors.set(true)
4428

4529
freeCompilerArgs.addAll(

buildSrc/src/main/kotlin/buildsrc/convention/kotlin-jvm.gradle.kts

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -18,22 +18,12 @@ dependencies {
1818
}
1919

2020
java {
21+
// It's available without extra setup on GitHub Actions runners.
22+
sourceCompatibility = JavaVersion.VERSION_11
23+
targetCompatibility = JavaVersion.VERSION_11
24+
2125
withJavadocJar()
2226
withSourcesJar()
23-
24-
toolchain {
25-
requiredJdkVersion()
26-
}
27-
}
28-
29-
kotlin {
30-
jvmToolchain {
31-
requiredJdkVersion()
32-
}
33-
}
34-
35-
fun JavaToolchainSpec.requiredJdkVersion() {
36-
languageVersion.set(JavaLanguageVersion.of(11))
3727
}
3828

3929
tasks.withType<KotlinCompile> {
@@ -50,6 +40,8 @@ tasks.withType<KotlinCompile> {
5040
}
5141
}
5242

43+
44+
5345
tasks.withType<Test>().configureEach {
5446
useJUnitPlatform()
5547
}

0 commit comments

Comments
 (0)