Skip to content

Commit eab1aa8

Browse files
VampireVampire
committed
feat(abg)!: allow to wire typed outputs to matching typed inputs
1 parent 62d0334 commit eab1aa8

File tree

47 files changed

+1712
-538
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

47 files changed

+1712
-538
lines changed

‎.github/workflows/bindings-server.main.kts‎

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -105,15 +105,16 @@ workflow(
105105
""".trimIndent(),
106106
)
107107

108-
cleanMavenLocal()
109-
110-
run(
111-
name = "Execute the script using the bindings from the server with v2 route",
112-
command = """
113-
mv .github/workflows/test-script-consuming-jit-bindings-v2.main.do-not-compile.kts .github/workflows/test-script-consuming-jit-bindings-v2.main.kts
114-
.github/workflows/test-script-consuming-jit-bindings-v2.main.kts
115-
""".trimIndent(),
116-
)
108+
// TODO: Reenable after release, currently, new class "Expression" cannot be found
109+
//cleanMavenLocal()
110+
111+
//run(
112+
// name = "Execute the script using the bindings from the server with v2 route",
113+
// command = """
114+
// mv .github/workflows/test-script-consuming-jit-bindings-v2.main.do-not-compile.kts .github/workflows/test-script-consuming-jit-bindings-v2.main.kts
115+
// .github/workflows/test-script-consuming-jit-bindings-v2.main.kts
116+
// """.trimIndent(),
117+
//)
117118

118119
cleanMavenLocal()
119120

‎.github/workflows/bindings-server.yaml‎

Lines changed: 9 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -82,54 +82,46 @@ jobs:
8282
name: 'Clean Maven Local to fetch required POMs again'
8383
run: 'rm -rf ~/.m2/repository/'
8484
- id: 'step-9'
85-
name: 'Execute the script using the bindings from the server with v2 route'
86-
run: |-
87-
mv .github/workflows/test-script-consuming-jit-bindings-v2.main.do-not-compile.kts .github/workflows/test-script-consuming-jit-bindings-v2.main.kts
88-
.github/workflows/test-script-consuming-jit-bindings-v2.main.kts
89-
- id: 'step-10'
90-
name: 'Clean Maven Local to fetch required POMs again'
91-
run: 'rm -rf ~/.m2/repository/'
92-
- id: 'step-11'
9385
name: 'Execute the script using bindings but without dependency on library'
9486
run: |-
9587
mv .github/workflows/test-served-bindings-depend-on-library.main.do-not-compile.kts .github/workflows/test-served-bindings-depend-on-library.main.kts
9688
.github/workflows/test-served-bindings-depend-on-library.main.kts
97-
- id: 'step-12'
89+
- id: 'step-10'
9890
name: 'Install Kotlin 1.9.0'
9991
uses: 'fwilhe2/setup-kotlin@0.11.0'
10092
with:
10193
version: '1.9.0'
102-
- id: 'step-13'
94+
- id: 'step-11'
10395
name: 'Clean Maven Local to fetch required POMs again'
10496
run: 'rm -rf ~/.m2/repository/'
105-
- id: 'step-14'
97+
- id: 'step-12'
10698
name: 'Execute the script using the bindings from the server, using older Kotlin (1.9.0) as consumer'
10799
run: |2-
108100
cp .github/workflows/test-script-consuming-jit-bindings.main.kts .github/workflows/test-script-consuming-jit-bindings-too-old-kotlin.main.kts
109101
(.github/workflows/test-script-consuming-jit-bindings-too-old-kotlin.main.kts || true) >> output.txt 2>&1
110102
grep "was compiled with an incompatible version of Kotlin" output.txt
111-
- id: 'step-15'
103+
- id: 'step-13'
112104
name: 'Install Kotlin 2.0.0'
113105
uses: 'fwilhe2/setup-kotlin@0.11.0'
114106
with:
115107
version: '2.0.0'
116-
- id: 'step-16'
108+
- id: 'step-14'
117109
name: 'Clean Maven Local to fetch required POMs again'
118110
run: 'rm -rf ~/.m2/repository/'
119-
- id: 'step-17'
111+
- id: 'step-15'
120112
name: 'Execute the script using the bindings from the server, using older Kotlin (2.0.0) as consumer'
121113
run: |-
122114
cp .github/workflows/test-script-consuming-jit-bindings.main.kts .github/workflows/test-script-consuming-jit-bindings-older-kotlin.main.kts
123115
.github/workflows/test-script-consuming-jit-bindings-older-kotlin.main.kts
124-
- id: 'step-18'
116+
- id: 'step-16'
125117
name: 'Compile a Gradle project using the bindings from the server'
126118
run: |-
127119
cd .github/workflows/test-gradle-project-using-bindings-server
128120
./gradlew build
129-
- id: 'step-19'
121+
- id: 'step-17'
130122
name: 'Fetch maven-metadata.xml for top-level action'
131123
run: 'curl --fail http://localhost:8080/actions/checkout/maven-metadata.xml | grep ''<version>v4</version>'''
132-
- id: 'step-20'
124+
- id: 'step-18'
133125
name: 'Fetch maven-metadata.xml for nested action'
134126
run: 'curl --fail http://localhost:8080/actions/cache__save/maven-metadata.xml | grep ''<version>v4</version>'''
135127
deploy:

‎.github/workflows/end-to-end-tests.main.kts‎

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ import io.github.typesafegithub.workflows.actions.actions.*
1515
import io.github.typesafegithub.workflows.actions.gradle.ActionsSetupGradle
1616
import io.github.typesafegithub.workflows.actions.wandalen.WretryAction
1717
import io.github.typesafegithub.workflows.annotations.ExperimentalKotlinLogicStep
18+
import io.github.typesafegithub.workflows.domain.Expression
1819
import io.github.typesafegithub.workflows.domain.JobOutputs
1920
import io.github.typesafegithub.workflows.domain.Mode
2021
import io.github.typesafegithub.workflows.domain.Permission
@@ -81,9 +82,9 @@ workflow(
8182
Permission.Contents to Mode.None,
8283
),
8384
outputs = object : JobOutputs() {
84-
var scriptKey by output()
85-
var scriptKey2 by output()
86-
var scriptResult by output()
85+
var scriptKey by output<String>()
86+
var scriptKey2 by output<String>()
87+
var scriptResult by output<String>()
8788
},
8889
) {
8990
run(
@@ -179,7 +180,7 @@ workflow(
179180
name = "Some step consuming other step's output",
180181
action = Checkout(
181182
sshKey = expr(addAndCommit.outputs.pythonVersion),
182-
path = expr(addAndCommit.outputs["my-unsafe-output"]),
183+
path = addAndCommit.outputs["my-unsafe-output"].expressionString,
183184
),
184185
)
185186

@@ -234,7 +235,7 @@ workflow(
234235
)
235236
jobOutputs.scriptKey = scriptStep.outputs["key"]
236237
jobOutputs.scriptKey2 = scriptStep.outputs["key2"]
237-
jobOutputs.scriptResult = scriptStep.outputs.result
238+
jobOutputs.scriptResult = Expression(scriptStep.outputs.result)
238239
}
239240

240241
job(
@@ -250,9 +251,9 @@ workflow(
250251
run(
251252
name = "use output of script",
252253
command = """
253-
echo ${expr { testJob1.outputs.scriptKey }}
254-
echo ${expr { testJob1.outputs.scriptKey2 }}
255-
echo ${expr { testJob1.outputs.scriptResult }}
254+
echo ${testJob1.outputs.scriptKey.expressionString}
255+
echo ${expr(testJob1.outputs.scriptKey2.expression)}
256+
echo ${expr { testJob1.outputs.scriptResult.expression }}
256257
""".trimIndent(),
257258
)
258259

‎action-binding-generator/api/action-binding-generator.api‎

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,23 @@ public final class io/github/typesafegithub/workflows/actionbindinggenerator/dom
2323
public static final fun isTopLevel (Lio/github/typesafegithub/workflows/actionbindinggenerator/domain/ActionCoords;)Z
2424
}
2525

26+
public final class io/github/typesafegithub/workflows/actionbindinggenerator/domain/ActionTypings {
27+
public fun <init> ()V
28+
public fun <init> (Ljava/util/Map;Ljava/util/Map;Lio/github/typesafegithub/workflows/actionbindinggenerator/domain/TypingActualSource;)V
29+
public synthetic fun <init> (Ljava/util/Map;Ljava/util/Map;Lio/github/typesafegithub/workflows/actionbindinggenerator/domain/TypingActualSource;ILkotlin/jvm/internal/DefaultConstructorMarker;)V
30+
public final fun component1 ()Ljava/util/Map;
31+
public final fun component2 ()Ljava/util/Map;
32+
public final fun component3 ()Lio/github/typesafegithub/workflows/actionbindinggenerator/domain/TypingActualSource;
33+
public final fun copy (Ljava/util/Map;Ljava/util/Map;Lio/github/typesafegithub/workflows/actionbindinggenerator/domain/TypingActualSource;)Lio/github/typesafegithub/workflows/actionbindinggenerator/domain/ActionTypings;
34+
public static synthetic fun copy$default (Lio/github/typesafegithub/workflows/actionbindinggenerator/domain/ActionTypings;Ljava/util/Map;Ljava/util/Map;Lio/github/typesafegithub/workflows/actionbindinggenerator/domain/TypingActualSource;ILjava/lang/Object;)Lio/github/typesafegithub/workflows/actionbindinggenerator/domain/ActionTypings;
35+
public fun equals (Ljava/lang/Object;)Z
36+
public final fun getInputTypings ()Ljava/util/Map;
37+
public final fun getOutputTypings ()Ljava/util/Map;
38+
public final fun getSource ()Lio/github/typesafegithub/workflows/actionbindinggenerator/domain/TypingActualSource;
39+
public fun hashCode ()I
40+
public fun toString ()Ljava/lang/String;
41+
}
42+
2643
public final class io/github/typesafegithub/workflows/actionbindinggenerator/domain/CommitHash : io/github/typesafegithub/workflows/actionbindinggenerator/domain/MetadataRevision {
2744
public fun <init> (Ljava/lang/String;)V
2845
public final fun component1 ()Ljava/lang/String;
@@ -72,8 +89,8 @@ public final class io/github/typesafegithub/workflows/actionbindinggenerator/gen
7289
}
7390

7491
public final class io/github/typesafegithub/workflows/actionbindinggenerator/generation/GenerationKt {
75-
public static final fun generateBinding (Lio/github/typesafegithub/workflows/actionbindinggenerator/domain/ActionCoords;Lio/github/typesafegithub/workflows/actionbindinggenerator/versioning/BindingVersion;Lio/github/typesafegithub/workflows/actionbindinggenerator/domain/MetadataRevision;Lio/github/typesafegithub/workflows/actionbindinggenerator/metadata/Metadata;Lkotlin/Pair;)Ljava/util/List;
76-
public static synthetic fun generateBinding$default (Lio/github/typesafegithub/workflows/actionbindinggenerator/domain/ActionCoords;Lio/github/typesafegithub/workflows/actionbindinggenerator/versioning/BindingVersion;Lio/github/typesafegithub/workflows/actionbindinggenerator/domain/MetadataRevision;Lio/github/typesafegithub/workflows/actionbindinggenerator/metadata/Metadata;Lkotlin/Pair;ILjava/lang/Object;)Ljava/util/List;
92+
public static final fun generateBinding (Lio/github/typesafegithub/workflows/actionbindinggenerator/domain/ActionCoords;Lio/github/typesafegithub/workflows/actionbindinggenerator/versioning/BindingVersion;Lio/github/typesafegithub/workflows/actionbindinggenerator/domain/MetadataRevision;Lio/github/typesafegithub/workflows/actionbindinggenerator/metadata/Metadata;Lio/github/typesafegithub/workflows/actionbindinggenerator/domain/ActionTypings;)Ljava/util/List;
93+
public static synthetic fun generateBinding$default (Lio/github/typesafegithub/workflows/actionbindinggenerator/domain/ActionCoords;Lio/github/typesafegithub/workflows/actionbindinggenerator/versioning/BindingVersion;Lio/github/typesafegithub/workflows/actionbindinggenerator/domain/MetadataRevision;Lio/github/typesafegithub/workflows/actionbindinggenerator/metadata/Metadata;Lio/github/typesafegithub/workflows/actionbindinggenerator/domain/ActionTypings;ILjava/lang/Object;)Ljava/util/List;
7794
}
7895

7996
public final class io/github/typesafegithub/workflows/actionbindinggenerator/metadata/Input {

‎action-binding-generator/src/main/kotlin/io/github/typesafegithub/workflows/actionbindinggenerator/domain/ActionTypings.kt‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
package io.github.typesafegithub.workflows.actionbindinggenerator.domain
2+
3+
import io.github.typesafegithub.workflows.actionbindinggenerator.typing.Typing
4+
5+
public data class ActionTypings(
6+
val inputTypings: Map<String, Typing> = emptyMap(),
7+
val outputTypings: Map<String, Typing> = emptyMap(),
8+
val source: TypingActualSource? = null,
9+
)

0 commit comments

Comments
 (0)