chore: revert change in checker

Author: Jack-Works

src/compiler/checker.ts

@@ -16098,10 +16098,7 @@ namespace ts {
                 const isPerformingExcessPropertyChecks = !(intersectionState & IntersectionState.Target) && (isObjectLiteralType(source) && getObjectFlags(source) & ObjectFlags.FreshLiteral);
                 if (isPerformingExcessPropertyChecks) {
                     if (hasExcessProperties(<FreshObjectLiteralType>source, target, reportErrors)) {
-                        // Skip report relation error if there is diag with suggestion emitted
-                        // So the fixSpelling can work with JSX attribute suggestion
-                        const skipReport = isComparingJsxAttributes && errorInfo?.code === Diagnostics.Property_0_does_not_exist_on_type_1_Did_you_mean_2.code;
-                        if (reportErrors && !skipReport) {
+                        if (reportErrors) {
                             reportRelationError(headMessage, source, target);
                         }
                         return Ternary.False;

src/services/codefixes/fixSpelling.ts

@@ -7,12 +7,16 @@ namespace ts.codefix {
         Diagnostics.Cannot_find_name_0_Did_you_mean_the_instance_member_this_0.code,
         Diagnostics.Cannot_find_name_0_Did_you_mean_the_static_member_1_0.code,
         Diagnostics.Module_0_has_no_exported_member_1_Did_you_mean_2.code,
+        // for JSX class components
+        Diagnostics.No_overload_matches_this_call.code,
+        // for JSX FC
+        Diagnostics.Type_0_is_not_assignable_to_type_1.code,
     ];
     registerCodeFix({
         errorCodes,
         getCodeActions(context) {
-            const { sourceFile } = context;
-            const info = getInfo(sourceFile, context.span.start, context);
+            const { sourceFile, errorCode } = context;
+            const info = getInfo(sourceFile, context.span.start, context, errorCode);
             if (!info) return undefined;
             const { node, suggestedSymbol } = info;
             const { target } = context.host.getCompilationSettings();
@@ -21,18 +25,23 @@ namespace ts.codefix {
         },
         fixIds: [fixId],
         getAllCodeActions: context => codeFixAll(context, errorCodes, (changes, diag) => {
-            const info = getInfo(diag.file, diag.start, context);
+            const info = getInfo(diag.file, diag.start, context, diag.code);
             const { target } = context.host.getCompilationSettings();
             if (info) doChange(changes, context.sourceFile, info.node, info.suggestedSymbol, target!);
         }),
     });
 
-    function getInfo(sourceFile: SourceFile, pos: number, context: CodeFixContextBase): { node: Node, suggestedSymbol: Symbol } | undefined {
+    function getInfo(sourceFile: SourceFile, pos: number, context: CodeFixContextBase, errorCode: number): { node: Node, suggestedSymbol: Symbol } | undefined {
         // This is the identifier of the misspelled word. eg:
         // this.speling = 1;
         //      ^^^^^^^
         const node = getTokenAtPosition(sourceFile, pos);
         const parent = node.parent;
+        // Only fix spelling for No_overload_matches_this_call emitted on the React class component
+        if ((
+            errorCode === Diagnostics.No_overload_matches_this_call.code ||
+            errorCode === Diagnostics.Type_0_is_not_assignable_to_type_1.code) &&
+            !isJsxAttribute(parent)) return undefined;
         const checker = context.program.getTypeChecker();
 
         let suggestedSymbol: Symbol | undefined;