temp (#1127)

renovate[bot] · Josh Goldberg · web-flow · commit 5bc060645733 · 2021-07-03T11:23:31.000-04:00
Co-authored-by: Josh Goldberg &lt;josh@codecademy.com&gt;
diff --git a/.husky/pre-commit b/.husky/pre-commit
@@ -0,0 +1,4 @@
+#!/bin/sh
+. "$(dirname "$0")/_/husky.sh"
+
+npm run precommit
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -39,18 +39,13 @@
         "babel-jest": "27.0.6",
         "eslint": "7.30.0",
         "eslint-plugin-simple-import-sort": "7.0.0",
-        "husky": "6.0.0",
+        "husky": "^7.0.0",
         "jest": "27.0.6",
         "lint-staged": "11.0.0",
         "prettier": "2.3.2",
         "strip-ansi": "6.0.0"
     },
     "homepage": "https://github.com/typescript-eslint/tslint-to-eslint-config#readme",
-    "husky": {
-        "hooks": {
-            "pre-commit": "lint-staged"
-        }
-    },
     "keywords": [
         "eslint",
         "tslint",
@@ -71,6 +66,8 @@
     },
     "scripts": {
         "eslint": "eslint \"./src/*.ts\" \"./src/**/*.ts\" --report-unused-disable-directives",
+        "precommit": "lint-staged",
+        "prepare": "husky install",
         "prettier": "prettier \"./src/*.{js,json,ts,xml,yaml}\" \"./src/**/*.{js,json,ts,xml,yaml}\" --ignore-path .prettierignore",
         "prettier:write": "npm run prettier -- --write",
         "test": "jest",
diff --git a/src/converters/comments/parseFileComments.ts b/src/converters/comments/parseFileComments.ts
@@ -39,9 +39,10 @@ export const parseFileComments = (filePath: string, content: string) => {
 const tslintRegex = new RegExp(/tslint:(enable|disable)(?:-(line|next-line))?(:|\s|$)/g);
 
 const parseFileComment = (fullText: string, comment: ts.CommentRange): FileComment | undefined => {
-    const commentText = (comment.kind === ts.SyntaxKind.SingleLineCommentTrivia
-        ? fullText.substring(comment.pos + 2, comment.end)
-        : fullText.substring(comment.pos + 2, comment.end - 2)
+    const commentText = (
+        comment.kind === ts.SyntaxKind.SingleLineCommentTrivia
+            ? fullText.substring(comment.pos + 2, comment.end)
+            : fullText.substring(comment.pos + 2, comment.end - 2)
     ).trim();
     const match = commentText.match(tslintRegex);
     if (match === null) {
diff --git a/src/converters/lintConfigs/formatConvertedRules.ts b/src/converters/lintConfigs/formatConvertedRules.ts
@@ -8,9 +8,9 @@ export const formatConvertedRules = (
     tslintConfiguration: TSLintConfiguration,
 ) => {
     const output: Record<string, string | any[]> = {};
-    const sortedRuleEntries = Array.from(
-        conversionResults.converted,
-    ).sort(([ruleNameA], [ruleNameB]) => ruleNameA.localeCompare(ruleNameB));
+    const sortedRuleEntries = Array.from(conversionResults.converted).sort(
+        ([ruleNameA], [ruleNameB]) => ruleNameA.localeCompare(ruleNameB),
+    );
 
     for (const [ruleName, rule] of sortedRuleEntries) {
         output[ruleName] = formatConvertedRule(rule);
diff --git a/src/converters/lintConfigs/rules/ruleConverters/no-cookies.ts b/src/converters/lintConfigs/rules/ruleConverters/no-cookies.ts
@@ -7,8 +7,9 @@ export const convertNoCookies: RuleConverter = () => {
                 ruleArguments: [
                     {
                         message: "Forbidden call to document.cookie",
-                        selector: 'MemberExpression[object.name="document"][property.name="cookie"]',
-                    }
+                        selector:
+                            'MemberExpression[object.name="document"][property.name="cookie"]',
+                    },
                 ],
                 ruleName: "restricted-syntax",
             },
diff --git a/src/converters/lintConfigs/rules/ruleConverters/no-document-domain.ts b/src/converters/lintConfigs/rules/ruleConverters/no-document-domain.ts
@@ -6,12 +6,14 @@ export const convertNoDocumentDomain: RuleConverter = () => {
             {
                 ruleArguments: [
                     {
-                        message: 'Forbidden write to document.domain.',
-                        selector: 'AssignmentExpression[left.type="MemberExpression"][left.object.name="document"][left.property.name="domain"]',
+                        message: "Forbidden write to document.domain.",
+                        selector:
+                            'AssignmentExpression[left.type="MemberExpression"][left.object.name="document"][left.property.name="domain"]',
                     },
                     {
-                        message: 'Forbidden write to document.domain.',
-                        selector: 'AssignmentExpression[left.type="MemberExpression"][left.object.type="MemberExpression"][left.object.object.name="window"][left.object.property.name="document"][left.property.name="domain"]',
+                        message: "Forbidden write to document.domain.",
+                        selector:
+                            'AssignmentExpression[left.type="MemberExpression"][left.object.type="MemberExpression"][left.object.object.name="window"][left.object.property.name="document"][left.property.name="domain"]',
                     },
                 ],
                 ruleName: "no-restricted-syntax",
diff --git a/src/converters/lintConfigs/rules/ruleConverters/no-document-write.ts b/src/converters/lintConfigs/rules/ruleConverters/no-document-write.ts
@@ -6,12 +6,14 @@ export const convertNoDocumentWrite: RuleConverter = () => {
             {
                 ruleArguments: [
                     {
-                        message: 'Forbidden call to document.write.',
-                        selector: 'CallExpression[callee.type="MemberExpression"][callee.object.name="document"][callee.property.name=/^(write|writeln)$/]',
+                        message: "Forbidden call to document.write.",
+                        selector:
+                            'CallExpression[callee.type="MemberExpression"][callee.object.name="document"][callee.property.name=/^(write|writeln)$/]',
                     },
                     {
-                        message: 'Forbidden write to document.write.',
-                        selector: 'CallExpression[callee.type="MemberExpression"][callee.object.type="MemberExpression"][callee.object.object.name="window"][callee.object.property.name="document"][callee.property.name=/^(write|writeln)$/]',
+                        message: "Forbidden write to document.write.",
+                        selector:
+                            'CallExpression[callee.type="MemberExpression"][callee.object.type="MemberExpression"][callee.object.object.name="window"][callee.object.property.name="document"][callee.property.name=/^(write|writeln)$/]',
                     },
                 ],
                 ruleName: "no-restricted-syntax",
diff --git a/src/converters/lintConfigs/rules/ruleConverters/no-exec-script.ts b/src/converters/lintConfigs/rules/ruleConverters/no-exec-script.ts
@@ -8,7 +8,7 @@ export const convertNoExecScript: RuleConverter = () => {
                     {
                         message: "Forbidden call to execScript",
                         selector: 'CallExpression[callee.name="execScript"]',
-                    }
+                    },
                 ],
                 ruleName: "restricted-syntax",
             },
diff --git a/src/converters/lintConfigs/rules/ruleConverters/react-a11y-accessible-headings.ts b/src/converters/lintConfigs/rules/ruleConverters/react-a11y-accessible-headings.ts
@@ -2,7 +2,9 @@ import { RuleConverter } from "../ruleConverter";
 
 export const convertReactA11yAccessibleHeadings: RuleConverter = (tslintRule) => {
     return {
-        ...tslintRule.ruleArguments.length === 1 && { notices: ["jsx-a11y/heading-has-content rule does not support maxHeadingLength"] },
+        ...(tslintRule.ruleArguments.length === 1 && {
+            notices: ["jsx-a11y/heading-has-content rule does not support maxHeadingLength"],
+        }),
         plugins: ["jsx-a11y"],
         rules: [
             {
diff --git a/src/converters/lintConfigs/rules/ruleConverters/react-a11y-anchors.ts b/src/converters/lintConfigs/rules/ruleConverters/react-a11y-anchors.ts
@@ -2,9 +2,11 @@ import { RuleConverter } from "../ruleConverter";
 
 export const convertReactA11yAnchors: RuleConverter = (tslintRule) => {
     return {
-        ...(tslintRule.ruleArguments.length > 0 && ({
-            notices: Object.keys(tslintRule.ruleArguments[0] as Record<string, unknown>).map(key => `jsx-a11y/anchor-is-valid does not support the '${key}' option.`)
-        })),
+        ...(tslintRule.ruleArguments.length > 0 && {
+            notices: Object.keys(tslintRule.ruleArguments[0] as Record<string, unknown>).map(
+                (key) => `jsx-a11y/anchor-is-valid does not support the '${key}' option.`,
+            ),
+        }),
         plugins: ["jsx-a11y"],
         rules: [
             {
diff --git a/src/converters/lintConfigs/rules/ruleConverters/react-no-dangerous-html.ts b/src/converters/lintConfigs/rules/ruleConverters/react-no-dangerous-html.ts
@@ -2,7 +2,7 @@ import { RuleConverter } from "../ruleConverter";
 
 export const convertReactNoDangerousHtml: RuleConverter = () => {
     return {
-        plugins: ['eslint-plugin-react'],
+        plugins: ["eslint-plugin-react"],
         rules: [
             {
                 ruleName: "react/no-danger",
diff --git a/src/converters/lintConfigs/rules/ruleConverters/react-tsx-curly-spacing.ts b/src/converters/lintConfigs/rules/ruleConverters/react-tsx-curly-spacing.ts
@@ -8,8 +8,8 @@ export const convertReactTsxCurlySpacing: RuleConverter = (tslintRule) => {
                 ruleArguments: [
                     {
                         ...(tslintRule.ruleArguments.length > 1 && tslintRule.ruleArguments[1]),
-                        'when': tslintRule.ruleArguments[0],
-                    }
+                        when: tslintRule.ruleArguments[0],
+                    },
                 ],
                 ruleName: "react/jsx-curly-spacing",
             },
diff --git a/src/converters/lintConfigs/rules/ruleConverters/tests/no-cookies.test.ts b/src/converters/lintConfigs/rules/ruleConverters/tests/no-cookies.test.ts
@@ -12,8 +12,9 @@ describe(convertNoCookies, () => {
                     ruleArguments: [
                         {
                             message: "Forbidden call to document.cookie",
-                            selector: 'MemberExpression[object.name="document"][property.name="cookie"]',
-                        }
+                            selector:
+                                'MemberExpression[object.name="document"][property.name="cookie"]',
+                        },
                     ],
                     ruleName: "restricted-syntax",
                 },
diff --git a/src/converters/lintConfigs/rules/ruleConverters/tests/no-document-domain.test.ts b/src/converters/lintConfigs/rules/ruleConverters/tests/no-document-domain.test.ts
@@ -11,12 +11,14 @@ describe(convertNoDocumentDomain, () => {
                 {
                     ruleArguments: [
                         {
-                            message: 'Forbidden write to document.domain.',
-                            selector: 'AssignmentExpression[left.type="MemberExpression"][left.object.name="document"][left.property.name="domain"]',
+                            message: "Forbidden write to document.domain.",
+                            selector:
+                                'AssignmentExpression[left.type="MemberExpression"][left.object.name="document"][left.property.name="domain"]',
                         },
                         {
-                            message: 'Forbidden write to document.domain.',
-                            selector: 'AssignmentExpression[left.type="MemberExpression"][left.object.type="MemberExpression"][left.object.object.name="window"][left.object.property.name="document"][left.property.name="domain"]',
+                            message: "Forbidden write to document.domain.",
+                            selector:
+                                'AssignmentExpression[left.type="MemberExpression"][left.object.type="MemberExpression"][left.object.object.name="window"][left.object.property.name="document"][left.property.name="domain"]',
                         },
                     ],
                     ruleName: "no-restricted-syntax",
diff --git a/src/converters/lintConfigs/rules/ruleConverters/tests/no-document-write.test.ts b/src/converters/lintConfigs/rules/ruleConverters/tests/no-document-write.test.ts
@@ -11,12 +11,14 @@ describe(convertNoDocumentWrite, () => {
                 {
                     ruleArguments: [
                         {
-                            message: 'Forbidden call to document.write.',
-                            selector: 'CallExpression[callee.type="MemberExpression"][callee.object.name="document"][callee.property.name=/^(write|writeln)$/]',
+                            message: "Forbidden call to document.write.",
+                            selector:
+                                'CallExpression[callee.type="MemberExpression"][callee.object.name="document"][callee.property.name=/^(write|writeln)$/]',
                         },
                         {
-                            message: 'Forbidden write to document.write.',
-                            selector: 'CallExpression[callee.type="MemberExpression"][callee.object.type="MemberExpression"][callee.object.object.name="window"][callee.object.property.name="document"][callee.property.name=/^(write|writeln)$/]',
+                            message: "Forbidden write to document.write.",
+                            selector:
+                                'CallExpression[callee.type="MemberExpression"][callee.object.type="MemberExpression"][callee.object.object.name="window"][callee.object.property.name="document"][callee.property.name=/^(write|writeln)$/]',
                         },
                     ],
                     ruleName: "no-restricted-syntax",
diff --git a/src/converters/lintConfigs/rules/ruleConverters/tests/no-exec-script.test.ts b/src/converters/lintConfigs/rules/ruleConverters/tests/no-exec-script.test.ts
@@ -13,7 +13,7 @@ describe(convertNoExecScript, () => {
                         {
                             message: "Forbidden call to execScript",
                             selector: 'CallExpression[callee.name="execScript"]',
-                        }
+                        },
                     ],
                     ruleName: "restricted-syntax",
                 },
diff --git a/src/converters/lintConfigs/rules/ruleConverters/tests/react-a11y-accessible-headings.test.ts b/src/converters/lintConfigs/rules/ruleConverters/tests/react-a11y-accessible-headings.test.ts
@@ -18,9 +18,11 @@ describe(convertReactA11yAccessibleHeadings, () => {
 
     test("conversion with an argument", () => {
         const result = convertReactA11yAccessibleHeadings({
-            ruleArguments: [{
-                maxHeadingLength: 23,
-            }],
+            ruleArguments: [
+                {
+                    maxHeadingLength: 23,
+                },
+            ],
         });
 
         expect(result).toEqual({
diff --git a/src/converters/lintConfigs/rules/ruleConverters/tests/react-a11y-anchors.test.ts b/src/converters/lintConfigs/rules/ruleConverters/tests/react-a11y-anchors.test.ts
@@ -18,16 +18,18 @@ describe(convertReactA11yAnchors, () => {
 
     test("conversion with arguments", () => {
         const result = convertReactA11yAnchors({
-            ruleArguments: [{
-                'ignore-case': true,
-                'ignore-whitespace': 'trim'
-            }],
+            ruleArguments: [
+                {
+                    "ignore-case": true,
+                    "ignore-whitespace": "trim",
+                },
+            ],
         });
 
         expect(result).toEqual({
             notices: [
                 `jsx-a11y/anchor-is-valid does not support the 'ignore-case' option.`,
-                `jsx-a11y/anchor-is-valid does not support the 'ignore-whitespace' option.`
+                `jsx-a11y/anchor-is-valid does not support the 'ignore-whitespace' option.`,
             ],
             plugins: ["jsx-a11y"],
             rules: [
diff --git a/src/converters/lintConfigs/rules/ruleConverters/tests/react-no-dangerous-html.test.ts b/src/converters/lintConfigs/rules/ruleConverters/tests/react-no-dangerous-html.test.ts
@@ -7,7 +7,7 @@ describe(convertReactNoDangerousHtml, () => {
         });
 
         expect(result).toEqual({
-            plugins: ['eslint-plugin-react'],
+            plugins: ["eslint-plugin-react"],
             rules: [
                 {
                     ruleName: "react/no-danger",
diff --git a/src/converters/lintConfigs/rules/ruleConverters/tests/react-tsx-curly-spacing.test.ts b/src/converters/lintConfigs/rules/ruleConverters/tests/react-tsx-curly-spacing.test.ts
@@ -3,16 +3,14 @@ import { convertReactTsxCurlySpacing } from "../react-tsx-curly-spacing";
 describe(convertReactTsxCurlySpacing, () => {
     test("conversion with 'always'", () => {
         const result = convertReactTsxCurlySpacing({
-            ruleArguments: ['always'],
+            ruleArguments: ["always"],
         });
 
         expect(result).toEqual({
             plugins: ["eslint-plugin-react"],
             rules: [
                 {
-                    ruleArguments: [
-                        { when: 'always' }
-                    ],
+                    ruleArguments: [{ when: "always" }],
                     ruleName: "react/jsx-curly-spacing",
                 },
             ],
@@ -21,16 +19,14 @@ describe(convertReactTsxCurlySpacing, () => {
 
     test("conversion with 'never'", () => {
         const result = convertReactTsxCurlySpacing({
-            ruleArguments: ['never'],
+            ruleArguments: ["never"],
         });
 
         expect(result).toEqual({
             plugins: ["eslint-plugin-react"],
             rules: [
                 {
-                    ruleArguments: [
-                        { when: 'never' }
-                    ],
+                    ruleArguments: [{ when: "never" }],
                     ruleName: "react/jsx-curly-spacing",
                 },
             ],
@@ -39,17 +35,19 @@ describe(convertReactTsxCurlySpacing, () => {
 
     test("conversion with 'never' and 'allowMultiline'", () => {
         const result = convertReactTsxCurlySpacing({
-            ruleArguments: ['never', { allowMultiline: true }],
+            ruleArguments: ["never", { allowMultiline: true }],
         });
 
         expect(result).toEqual({
             plugins: ["eslint-plugin-react"],
             rules: [
                 {
-                    ruleArguments: [{
-                        allowMultiline: true,
-                        when: 'never',
-                    }],
+                    ruleArguments: [
+                        {
+                            allowMultiline: true,
+                            when: "never",
+                        },
+                    ],
                     ruleName: "react/jsx-curly-spacing",
                 },
             ],
diff --git a/src/input/findOriginalConfigurations.ts b/src/input/findOriginalConfigurations.ts
@@ -116,9 +116,10 @@ export const findOriginalConfigurations = async (
 };
 
 const getMissingPackageMessage = (error: Error) => {
-    const match = /(Cannot find module|could not require|couldn't find the plugin) ([a-zA-Z0-9-_"'@/]+)/.exec(
-        error.message.split("\n").slice(0, 2).join("\n"),
-    );
+    const match =
+        /(Cannot find module|could not require|couldn't find the plugin) ([a-zA-Z0-9-_"'@/]+)/.exec(
+            error.message.split("\n").slice(0, 2).join("\n"),
+        );
     if (match === null) {
         return undefined;
     }

Original file line number	Diff line number	Diff line change
`@@ -6,12 +6,14 @@ export const convertNoDocumentDomain: RuleConverter = () => {`
`6`	`6`	`{`
`7`	`7`	`ruleArguments: [`
`8`	`8`	`{`
`9`		`- message: 'Forbidden write to document.domain.',`
`10`		`- selector: 'AssignmentExpression[left.type="MemberExpression"][left.object.name="document"][left.property.name="domain"]',`
	`9`	`+ message: "Forbidden write to document.domain.",`
	`10`	`+ selector:`
	`11`	`+ 'AssignmentExpression[left.type="MemberExpression"][left.object.name="document"][left.property.name="domain"]',`
`11`	`12`	`},`
`12`	`13`	`{`
`13`		`- message: 'Forbidden write to document.domain.',`
`14`		`- selector: 'AssignmentExpression[left.type="MemberExpression"][left.object.type="MemberExpression"][left.object.object.name="window"][left.object.property.name="document"][left.property.name="domain"]',`
	`14`	`+ message: "Forbidden write to document.domain.",`
	`15`	`+ selector:`
	`16`	`+ 'AssignmentExpression[left.type="MemberExpression"][left.object.type="MemberExpression"][left.object.object.name="window"][left.object.property.name="document"][left.property.name="domain"]',`
`15`	`17`	`},`
`16`	`18`	`],`
`17`	`19`	`ruleName: "no-restricted-syntax",`
Original file line number	Diff line number	Diff line change
`@@ -6,12 +6,14 @@ export const convertNoDocumentWrite: RuleConverter = () => {`
`6`	`6`	`{`
`7`	`7`	`ruleArguments: [`
`8`	`8`	`{`
`9`		`- message: 'Forbidden call to document.write.',`
`10`		`- selector: 'CallExpression[callee.type="MemberExpression"][callee.object.name="document"][callee.property.name=/^(write\|writeln)$/]',`
	`9`	`+ message: "Forbidden call to document.write.",`
	`10`	`+ selector:`
	`11`	`+ 'CallExpression[callee.type="MemberExpression"][callee.object.name="document"][callee.property.name=/^(write\|writeln)$/]',`
`11`	`12`	`},`
`12`	`13`	`{`
`13`		`- message: 'Forbidden write to document.write.',`
`14`		`- selector: 'CallExpression[callee.type="MemberExpression"][callee.object.type="MemberExpression"][callee.object.object.name="window"][callee.object.property.name="document"][callee.property.name=/^(write\|writeln)$/]',`
	`14`	`+ message: "Forbidden write to document.write.",`
	`15`	`+ selector:`
	`16`	`+ 'CallExpression[callee.type="MemberExpression"][callee.object.type="MemberExpression"][callee.object.object.name="window"][callee.object.property.name="document"][callee.property.name=/^(write\|writeln)$/]',`
`15`	`17`	`},`
`16`	`18`	`],`
`17`	`19`	`ruleName: "no-restricted-syntax",`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ export const convertNoExecScript: RuleConverter = () => {`
`8`	`8`	`{`
`9`	`9`	`message: "Forbidden call to execScript",`
`10`	`10`	`selector: 'CallExpression[callee.name="execScript"]',`
`11`		`- }`
	`11`	`+ },`
`12`	`12`	`],`
`13`	`13`	`ruleName: "restricted-syntax",`
`14`	`14`	`},`