Lowered lib version to support Node 10 (#265)

* Lowered lib version to support Node 10

* Added tests, heh

Author: Josh Goldberg

src/creation/formatting/formatters/withKeysSorted.ts

@@ -1,7 +1,10 @@
 export const withKeysSorted = (input: any) => {
-    return Object.fromEntries(
-        Object.keys(input)
-            .sort((a, b) => a.localeCompare(b))
-            .map(key => [key, input[key]]),
-    );
+    const output: Record<string, any> = {};
+    const keys = Object.keys(input).sort((a, b) => a.localeCompare(b));
+
+    for (const key of keys) {
+        output[key] = input[key];
+    }
+
+    return output;
 };

src/input/findESLintConfiguration.ts

@@ -2,6 +2,7 @@ import { Exec } from "../adapters/exec";
 import { SansDependencies } from "../binding";
 import { ESLintRuleSeverity } from "../rules/types";
 import { TSLintToESLintSettings } from "../types";
+import { uniqueFromSources } from "../utils";
 import { findRawConfiguration } from "./findRawConfiguration";
 import { findReportedConfiguration } from "./findReportedConfiguration";
 import { OriginalConfigurations } from "./findOriginalConfigurations";
@@ -60,9 +61,7 @@ export const findESLintConfiguration = async (
         return reportedConfiguration;
     }
 
-    const extensions = [rawConfiguration.extends, [reportedConfiguration.extends || []]].flat(
-        Infinity,
-    );
+    const extensions = uniqueFromSources(rawConfiguration.extends, reportedConfiguration.extends);
 
     return {
         full: {

src/input/findTSLintConfiguration.ts

@@ -2,8 +2,8 @@ import { findRawConfiguration } from "./findRawConfiguration";
 import { findReportedConfiguration } from "./findReportedConfiguration";
 import { Exec } from "../adapters/exec";
 import { SansDependencies } from "../binding";
+import { uniqueFromSources } from "../utils";
 import { importer } from "./importer";
-import { isDefined } from "../utils";
 
 export type TSLintConfiguration = {
     extends?: string[];
@@ -44,13 +44,7 @@ export const findTSLintConfiguration = async (
         return rawConfiguration;
     }
 
-    const extensions = Array.from(
-        new Set(
-            [[rawConfiguration.extends], [reportedConfiguration.extends]]
-                .flat(Infinity)
-                .filter(isDefined),
-        ),
-    );
+    const extensions = uniqueFromSources(rawConfiguration.extends, reportedConfiguration.extends);
 
     const rules = {
         ...rawConfiguration.rules,

src/utils.test.ts

@@ -1,4 +1,4 @@
-import { isDefined, isError } from "./utils";
+import { isDefined, isError, uniqueFromSources } from "./utils";
 
 describe("isDefined", () => {
     it("returns true when the item is defined", () => {
@@ -47,3 +47,38 @@ describe("isError", () => {
         expect(result).toBe(false);
     });
 });
+
+describe("uniqueFromSources", () => {
+    it("returns unique items when multiple are given", () => {
+        // Arange
+        const sources = ["a", "b", "b", "c"];
+
+        // Act
+        const result = uniqueFromSources(...sources);
+
+        // Assert
+        expect(result).toEqual(["a", "b", "c"]);
+    });
+
+    it("returns items from a nested array", () => {
+        // Arange
+        const sources = ["a", ["b"], "c"];
+
+        // Act
+        const result = uniqueFromSources(...sources);
+
+        // Assert
+        expect(result).toEqual(["a", "b", "c"]);
+    });
+
+    it("filters out undefined inputs", () => {
+        // Arange
+        const sources = ["a", "b", "c", undefined];
+
+        // Act
+        const result = uniqueFromSources(...sources);
+
+        // Assert
+        expect(result).toEqual(["a", "b", "c"]);
+    });
+});

src/utils.ts

@@ -7,3 +7,17 @@ export type RemoveErrors<Items> = {
 };
 
 export type PromiseValue<T> = T extends Promise<infer R> ? R : never;
+
+export const uniqueFromSources = <T>(...sources: (T | T[] | undefined)[]) => {
+    const items: T[] = [];
+
+    for (const source of sources) {
+        if (source instanceof Array) {
+            items.push(...source.filter(isDefined));
+        } else if (source !== undefined) {
+            items.push(source);
+        }
+    }
+
+    return Array.from(new Set(items));
+};

tsconfig.json

@@ -4,7 +4,7 @@
         "declaration": true,
         "esModuleInterop": true,
         "incremental": true,
-        "lib": ["esnext"],
+        "lib": ["es2017"],
         "module": "commonjs",
         "noFallthroughCasesInSwitch": true,
         "noImplicitAny": true,