Skip to content

Commit d435ae6

Browse files
authored
Add codelyzer no-lifecycle-call converter (#540)
1 parent b165a6b commit d435ae6

File tree

3 files changed

+34
-2
lines changed

3 files changed

+34
-2
lines changed
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
import { RuleConverter } from "../../converter";
2+
3+
export const convertNoLifecycleCall: RuleConverter = () => {
4+
return {
5+
rules: [
6+
{
7+
ruleName: "@angular-eslint/no-lifecycle-call",
8+
},
9+
],
10+
plugins: ["@angular-eslint/eslint-plugin"],
11+
};
12+
};
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
import { convertNoLifecycleCall } from "../no-lifecycle-call";
2+
3+
describe(convertNoLifecycleCall, () => {
4+
test("conversion without arguments", () => {
5+
const result = convertNoLifecycleCall({
6+
ruleArguments: [],
7+
});
8+
9+
expect(result).toEqual({
10+
rules: [
11+
{
12+
ruleName: "@angular-eslint/no-lifecycle-call",
13+
},
14+
],
15+
plugins: ["@angular-eslint/eslint-plugin"],
16+
});
17+
});
18+
});

src/rules/rulesConverters.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -145,13 +145,14 @@ import { convertContextualLifecycle } from "./converters/codelyzer/contextual-li
145145
import { convertDirectiveClassSuffix } from "./converters/codelyzer/directive-class-suffix";
146146
import { convertDirectiveSelector } from "./converters/codelyzer/directive-selector";
147147
import { convertNoAttributeDecorator } from "./converters/codelyzer/no-attribute-decorator";
148-
import { convertUsePipeDecorator } from "./converters/codelyzer/use-pipe-decorator";
148+
import { convertNoConflictingLifecycle } from "./converters/codelyzer/no-conflicting-lifecycle";
149149
import { convertNoForwardRef } from "./converters/codelyzer/no-forward-ref";
150150
import { convertNoHostMetadataProperty } from "./converters/codelyzer/no-host-metadata-property";
151151
import { convertNoInputPrefix } from "./converters/codelyzer/no-input-prefix";
152152
import { convertNoInputRename } from "./converters/codelyzer/no-input-rename";
153153
import { convertNoInputsMetadataProperty } from "./converters/codelyzer/no-inputs-metadata-property";
154-
import { convertNoConflictingLifecycle } from "./converters/codelyzer/no-conflicting-lifecycle";
154+
import { convertNoLifecycleCall } from "./converters/codelyzer/no-lifecycle-call";
155+
import { convertUsePipeDecorator } from "./converters/codelyzer/use-pipe-decorator";
155156

156157
/**
157158
* Keys TSLint rule names to their ESLint rule converters.
@@ -239,6 +240,7 @@ export const rulesConverters = new Map([
239240
["no-invalid-template-strings", convertNoInvalidTemplateStrings],
240241
["no-invalid-this", convertNoInvalidThis],
241242
["no-irregular-whitespace", convertNoIrregularWhitespace],
243+
["no-lifecycle-call", convertNoLifecycleCall],
242244
["no-magic-numbers", convertNoMagicNumbers],
243245
["no-misused-new", convertNoMisusedNew],
244246
["no-multiline-string", convertNoMultilineString],

0 commit comments

Comments
 (0)