Skip to content

Commit 31a1955

Browse files
committed
Cleaned up the tempalte handler code and fixed unit tests
1 parent 9059fe3 commit 31a1955

File tree

3 files changed

+10
-5
lines changed

3 files changed

+10
-5
lines changed

lib/typescript/rails/template_handler.rb

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,11 @@ def self.call(template)
7777
def self.replace_relative_references(ts_path, source)
7878
ts_dir = File.dirname(File.expand_path(ts_path))
7979
escaped_dir = ts_dir.gsub(/["\\]/, '\\\\\&') # "\"" => "\\\"", '\\' => '\\\\'
80-
source.gsub(%r!(^///\s*<reference\s+path=")([^"]+)("\s*/>\s*)!) {|m| $1 + File.join(escaped_dir, $2) + $3 }
80+
%r!^///\s*<reference\s+path="([^"]+)"\s*/>\s*!.match(source) do |m|
81+
source = source.sub(m.captures[0], File.join(escaped_dir, m.captures[0]))
82+
end
83+
84+
source
8185
end
8286
end
8387
end

test/support/site/ref2_1.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
var f: (x: number, y: number) => number;
1+
declare var f: (x: number, y: number) => number;

test/template_handler_test.rb

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,17 +25,18 @@ def app
2525
test "typescript views are served as javascript" do
2626
get "/site/index.js"
2727

28-
assert_match "var x = 5;\r\n", last_response.body
28+
s = last_response.body
29+
assert_match "var x = 5;", last_response.body
2930
end
3031

3132
test "<reference> to other .ts file works" do
3233
get "/site/ref1_2.js"
33-
assert_match "var f = function (x, y) {\r\n return x + y;\r\n};\r\nf(1, 2);\r\n", last_response.body
34+
assert_match "var f = function (x, y) {\n return x + y;\n};\nf(1, 2);\n", last_response.body
3435
end
3536

3637
test "<reference> to other .d.ts file works" do
3738
get "/site/ref2_2.js"
38-
assert_match "f(1, 2);\r\n", last_response.body
39+
assert_match "f(1, 2);\n", last_response.body
3940
end
4041

4142
end

0 commit comments

Comments
 (0)