revert: manually remove changes introduced in #234

Author: NoNameProvided

src/TransformOperationExecutor.ts

@@ -225,7 +225,7 @@ export class TransformOperationExecutor {
                 if (newValue.constructor.prototype) {
                     const descriptor = Object.getOwnPropertyDescriptor(newValue.constructor.prototype, newValueKey);
                     if ((this.transformationType === TransformationType.PLAIN_TO_CLASS || this.transformationType === TransformationType.CLASS_TO_CLASS)
-                        && ((descriptor && !descriptor.writable) || newValue[newValueKey] instanceof Function)) //  || TransformationType === TransformationType.CLASS_TO_CLASS
+                        && ((descriptor && !descriptor.set) || newValue[newValueKey] instanceof Function)) //  || TransformationType === TransformationType.CLASS_TO_CLASS
                         continue;
                 }
 

test/functional/prototype-inheritance.spec.ts

@@ -0,0 +1,28 @@
+// import { expect } from "chai";
+
+// import { plainToClass } from "../../src";
+
+// describe("Prototype inheritance", () => {
+
+//   // https://github.com/typestack/class-transformer/issues/233
+//   it("should set value if property has default value in prototype chain.", () => {
+//     class TestObject {
+//       normalProp: string = "Hello!";
+//       prototypedProp: string;
+//     }
+
+//     TestObject.prototype.prototypedProp = "I'm a BUG!";
+
+//     const payload = {
+//       normalProp: "Goodbye!",
+//       prototypedProp: "Goodbye!"
+//     };
+
+//     const result = plainToClass(TestObject, payload);
+
+//     expect(result).to.eql({
+//       normalProp: "Goodbye!",
+//       prototypedProp: "Goodbye!"
+//     });
+//   });
+// });

test/functional/serialization-deserialization.spec.ts

@@ -129,24 +129,24 @@ describe("serialization and deserialization objects", () => {
 
     });
 
-    it("should overwrite default properties defined in prototype", () => {
-        class TestObject {
-            normalProp: string = "Hello!";
-            prototypedProp: string;
-        }
+    // it("should overwrite default properties defined in prototype", () => {
+    //     class TestObject {
+    //         normalProp: string = "Hello!";
+    //         prototypedProp: string;
+    //     }
 
-        TestObject.prototype.prototypedProp = "I'm a BUG!";
+    //     TestObject.prototype.prototypedProp = "I'm a BUG!";
 
 
-        const payload = {
-            normalProp: "Goodbye!",
-            prototypedProp: "Goodbye!"
-        };
+    //     const payload = {
+    //         normalProp: "Goodbye!",
+    //         prototypedProp: "Goodbye!"
+    //     };
 
-        const result = deserialize(TestObject, JSON.stringify(payload));
+    //     const result = deserialize(TestObject, JSON.stringify(payload));
 
-        result.normalProp.should.be.eql("Goodbye!");
-        result.prototypedProp.should.be.eql("Goodbye!");
-    });
+    //     result.normalProp.should.be.eql("Goodbye!");
+    //     result.prototypedProp.should.be.eql("Goodbye!");
+    // });
 
 });