#233 Change detection of capability to write value into property

nouc23 · nouc23 · commit 759a37499d3b · 2019-02-08T16:33:13.000+01:00
diff --git a/src/TransformOperationExecutor.ts b/src/TransformOperationExecutor.ts
@@ -205,7 +205,7 @@ export class TransformOperationExecutor {
                 if (newValue.constructor.prototype) {
                     const descriptor = Object.getOwnPropertyDescriptor(newValue.constructor.prototype, newValueKey);
                     if ((this.transformationType === TransformationType.PLAIN_TO_CLASS || this.transformationType === TransformationType.CLASS_TO_CLASS)
-                        && (newValue[newValueKey] instanceof Function || (descriptor && !descriptor.set))) //  || TransformationType === TransformationType.CLASS_TO_CLASS
+                        && (newValue[newValueKey] instanceof Function || (descriptor && !descriptor.writable))) //  || TransformationType === TransformationType.CLASS_TO_CLASS
                         continue;
                 }
 

Original file line number	Diff line number	Diff line change
`@@ -205,7 +205,7 @@ export class TransformOperationExecutor {`
`205`	`205`	`if (newValue.constructor.prototype) {`
`206`	`206`	`const descriptor = Object.getOwnPropertyDescriptor(newValue.constructor.prototype, newValueKey);`
`207`	`207`	`if ((this.transformationType === TransformationType.PLAIN_TO_CLASS \|\| this.transformationType === TransformationType.CLASS_TO_CLASS)`
`208`		`- && (newValue[newValueKey] instanceof Function \|\| (descriptor && !descriptor.set))) // \|\| TransformationType === TransformationType.CLASS_TO_CLASS`
	`208`	`+ && (newValue[newValueKey] instanceof Function \|\| (descriptor && !descriptor.writable))) // \|\| TransformationType === TransformationType.CLASS_TO_CLASS`
`209`	`209`	`continue;`
`210`	`210`	`}`
`211`	`211`