merge: show param name in BadRequestError

Author: NoNameProvided

src/ActionParameterHandler.ts

@@ -190,11 +190,12 @@ export class ActionParameterHandler<T extends BaseDriver> {
                 .catch((validationErrors: ValidationError[]) => {
                     const error: any = new BadRequestError(`Invalid ${paramMetadata.type}, check 'errors' property for more info.`);
                     error.errors = validationErrors;
+                    error.paramName = paramMetadata.name; 
                     throw error;
                 });
         }
 
         return value;
     }
 
-}
+}

test/functional/class-validator-options.spec.ts

@@ -8,6 +8,7 @@ import {Get} from "../../src/decorator/Get";
 import {QueryParam} from "../../src/decorator/QueryParam";
 import {ResponseClassTransformOptions} from "../../src/decorator/ResponseClassTransformOptions";
 import {RoutingControllersOptions} from "../../src/RoutingControllersOptions";
+
 const chakram = require("chakram");
 const expect = chakram.expect;
 
@@ -208,4 +209,48 @@ describe("parameters auto-validation", () => {
         });
     });
 
-});
+    describe("should contain param name on validation failed", () => {
+
+        let requestFilter: any;
+        beforeEach(() => {
+            requestFilter = undefined;
+        });
+
+        before(() => {
+            getMetadataArgsStorage().reset();
+
+            @JsonController()
+            class UserController {
+
+                @Get("/user")
+                getUsers(@QueryParam("filter") filter: UserFilter): any {
+                    requestFilter = filter;
+                    const user = new UserModel();
+                    user.id = 1;
+                    user._firstName = "Umed";
+                    user._lastName = "Khudoiberdiev";
+                    return user;
+                }
+            }
+        });
+
+        const options: RoutingControllersOptions = {
+            validation: true
+        };
+
+        let expressApp: any, koaApp: any;
+        before(done => expressApp = createExpressServer(options).listen(3001, done));
+        after(done => expressApp.close(done));
+        before(done => koaApp = createKoaServer(options).listen(3002, done));
+        after(done => koaApp.close(done));
+
+        const invalidFilter = {
+            keyword: "aa"
+        };
+
+        assertRequest([3001, 3002], "get", `user?filter=${JSON.stringify(invalidFilter)}`, response => {
+            expect(response).to.have.status(400);
+            expect(response.body.paramName).to.equal("filter");
+        });
+    });
+});