fix: adding more test cases according to the feedback provided, negative cases

Author: ivanproskuryakov

test/ActionParameterHandler.spec.ts

@@ -2,11 +2,16 @@ import {ActionParameterHandler} from "../src/ActionParameterHandler";
 import {ActionMetadata, ControllerMetadata, ExpressDriver, ParamMetadata} from "../src";
 import {ActionMetadataArgs} from "../src/metadata/args/ActionMetadataArgs";
 import {ControllerMetadataArgs} from "../src/metadata/args/ControllerMetadataArgs";
+import {ParamType} from "../src/metadata/types/ParamType";
 
 const expect = require("chakram").expect;
 
 describe("ActionParameterHandler", () => {
-  const buildParamMetadata = (): ParamMetadata => {
+  const buildParamMetadata = (
+      name: string = "id",
+      type: ParamType = "param",
+      isRequired: boolean = false,
+  ): ParamMetadata => {
     const controllerMetadataArgs: ControllerMetadataArgs = {
       target: function () {
       },
@@ -27,6 +32,8 @@ describe("ActionParameterHandler", () => {
     const actionMetadata = new ActionMetadata(controllerMetadata, args, {});
 
     return {
+      type,
+      name,
       targetName: "product",
       isTargetObject: true,
       actionMetadata,
@@ -36,10 +43,8 @@ describe("ActionParameterHandler", () => {
       object: "getProduct",
       extraOptions: undefined,
       index: 0,
-      type: "param",
-      name: "id",
       parse: undefined,
-      required: false,
+      required: isRequired,
       transform: function (action, value) {
         return value;
       },
@@ -53,45 +58,45 @@ describe("ActionParameterHandler", () => {
   it("handle - should process string parameters", async () => {
     const driver = new ExpressDriver();
     const actionParameterHandler = new ActionParameterHandler(driver);
-    const param = buildParamMetadata();
+    const param = buildParamMetadata("uuid");
 
     const action = {
       request: {
         params: {
-          id: "0b5ec98f-e26d-4414-b798-dcd35a5ef859",
+          uuid: "0b5ec98f-e26d-4414-b798-dcd35a5ef859",
         },
       },
       response: {},
     };
 
     const processedValue = await actionParameterHandler.handle(action, param);
 
-    expect(processedValue).to.be.eq(action.request.params.id);
+    expect(processedValue).to.be.eq(action.request.params.uuid);
   });
 
   it("handle - should process string parameters, returns empty if a given string is empty", async () => {
     const driver = new ExpressDriver();
     const actionParameterHandler = new ActionParameterHandler(driver);
-    const param = buildParamMetadata();
+    const param = buildParamMetadata("uuid");
 
     const action = {
       request: {
         params: {
-          id: "",
+          uuid: "",
         },
       },
       response: {},
     };
 
     const processedValue = await actionParameterHandler.handle(action, param);
 
-    expect(processedValue).to.be.eq(action.request.params.id);
+    expect(processedValue).to.be.eq(action.request.params.uuid);
   });
 
   it("handle - should process number parameters", async () => {
     const driver = new ExpressDriver();
     const actionParameterHandler = new ActionParameterHandler(driver);
-    const param = buildParamMetadata();
+    const param = buildParamMetadata("id");
 
     const action = {
       request: {
@@ -124,4 +129,46 @@ describe("ActionParameterHandler", () => {
     expect(processedValue).to.be.eq(undefined);
   });
 
+  it("handle - throws error if the parameter is required", async () => {
+    const driver = new ExpressDriver();
+    const actionParameterHandler = new ActionParameterHandler(driver);
+    const param = buildParamMetadata("uuid", "param", true);
+
+    const action = {
+      request: {},
+      response: {},
+    };
+    let error;
+
+    try {
+      await actionParameterHandler.handle(action, param);
+    } catch (e) {
+      error = e;
+    }
+
+    expect(error.toString()).to.be.eq('TypeError: Cannot read property \'uuid\' of undefined');
+  });
+
+  it("handle - throws error if the parameter is required, type file provided", async () => {
+    const driver = new ExpressDriver();
+    const actionParameterHandler = new ActionParameterHandler(driver);
+    const param = buildParamMetadata("uuid", "file", true);
+
+    const action = {
+      request: {},
+      response: {},
+    };
+    let error;
+
+    try {
+      await actionParameterHandler.handle(action, param);
+    } catch (e) {
+      error = e;
+    }
+
+    expect(error.httpCode).to.be.eq(400);
+    expect(error.name).to.be.eq("ParamRequiredError");
+    expect(error.message).to.be.eq("Uploaded file \"uuid\" is required for request on undefined undefined");
+  });
+
 });