fixes #42

Author: Umed Khudoiberdiev

src/Container.ts

@@ -4,6 +4,7 @@ import {Handler} from "./types/Handler";
 import {Token} from "./Token";
 import {ServiceIdentifier} from "./types/ServiceIdentifier";
 import {ServiceNotFoundError} from "./error/ServiceNotFoundError";
+import {MissingProvidedServiceTypeError} from "./error/MissingProvidedServiceTypeError";
 
 /**
  * Service container.
@@ -88,7 +89,7 @@ export class Container {
         // if service was not found then create a new one and register it
         if (!service) {
             if (!type)
-                throw new Error(`Cannot determine a class of the requesting service "${identifier}"`);
+                throw new MissingProvidedServiceTypeError(identifier);
 
             service = { type: type };
             this.services.push(service);
@@ -117,7 +118,7 @@ export class Container {
 
         } else {  // otherwise simply create a new object instance
             if (!type)
-                throw new Error(`Cannot determine a class of the requesting service "${identifier}"`);
+                throw new MissingProvidedServiceTypeError(identifier);
 
             params.unshift(null);
             service.value = new (type.bind.apply(type, params))();

src/decorators/Inject.ts

@@ -1,5 +1,6 @@
 import {Container} from "../Container";
 import {Token} from "../Token";
+import {CannotInjectError} from "../error/CannotInjectError";
 
 /**
  * Injects a service into a class property or constructor parameter.
@@ -40,6 +41,10 @@ export function Inject(typeOrName?: ((type?: any) => Function)|string|Token<any>
                 } else {
                     identifier = typeOrName();
                 }
+
+                if (identifier === Object)
+                    throw new CannotInjectError(target, propertyName);
+
                 return Container.get<any>(identifier);
             }
         });

src/error/CannotInjectError.ts

@@ -0,0 +1,15 @@
+/**
+ * Thrown when DI cannot inject value into property decorated by @Inject decorator.
+ */
+export class CannotInjectError extends Error {
+    name = "ServiceNotFoundError";
+
+    constructor(target: Object, propertyName: string) {
+        super(
+            `Cannot inject value into "${target.constructor.name}.${propertyName}". ` +
+            `Please make sure you setup reflect-metadata properly and you don't use interfaces without service tokens as injection value.`
+        );
+        Object.setPrototypeOf(this, CannotInjectError.prototype);
+    }
+
+}

src/error/MissingProvidedServiceTypeError.ts

@@ -0,0 +1,12 @@
+/**
+ * Thrown when service is registered without type.
+ */
+export class MissingProvidedServiceTypeError extends Error {
+    name = "ServiceNotFoundError";
+
+    constructor(identifier: any) {
+        super(`Cannot determine a class of the requesting service "${identifier}"`);
+        Object.setPrototypeOf(this, MissingProvidedServiceTypeError.prototype);
+    }
+
+}

test/github-issues/42/issue-42.spec.ts

@@ -0,0 +1,34 @@
+import "reflect-metadata";
+import {Container} from "../../../src/Container";
+import {Service} from "../../../src/decorators/Service";
+import {Inject} from "../../../src/decorators/Inject";
+import {expect} from "chai";
+
+describe("github issues > #42 Exception not thrown on missing binding", function() {
+
+    beforeEach(() => Container.reset());
+
+    it("should work properly", function() {
+
+        interface Factory {
+            create(): void;
+        }
+
+        @Service()
+        class CoffeeMaker {
+
+            @Inject() // This is an incorrect usage of typedi because Factory is an interface
+            private factory: Factory;
+
+            make() {
+                this.factory.create();
+            }
+
+        }
+
+        expect(() => {
+            Container.get(CoffeeMaker);
+        }).to.throw(Error);
+    });
+
+});