wip

Author: tangrufus

.golangci.yml

@@ -30,3 +30,7 @@ issues:
         - dupl
         - lll
         - funlen
+        - maintidx
+    - path: '(.+)_example_test\.go'
+      linters:
+        - gochecknoglobals

and.go

@@ -30,8 +30,8 @@ func And(es ...Endless) (CeilingFloorConstrainter, error) {
 		return es[0], nil
 	}
 
-	floor, floorOk := maxBoundedFloor(es)
-	ceiling, ceilingOk := minBoundedCeiling(es)
+	floor, floorOk := maxBoundedFloor(es...)
+	ceiling, ceilingOk := minBoundedCeiling(es...)
 
 	if !floorOk && !ceilingOk {
 		var c CeilingFloorConstrainter

ceilinger.go

@@ -6,19 +6,19 @@ type ceilinger interface {
 	ceiling() Endless
 }
 
-func minBoundedCeiling[S ~[]T, T ceilinger](cs S) (T, bool) {
-	cs = slices.Clone(cs)
+func minBoundedCeiling(es ...Endless) (Endless, bool) {
+	es = slices.Clone(es)
 
-	bcs := slices.DeleteFunc(cs, func(b T) bool {
+	bcs := slices.DeleteFunc(es, func(b Endless) bool {
 		return b.ceiling().version == nil
 	})
 
 	if len(bcs) == 0 {
-		var c T
+		var c Endless
 		return c, false
 	}
 
-	return slices.MinFunc(bcs, func(a, b T) int {
+	return slices.MinFunc(bcs, func(a, b Endless) int {
 		return a.ceiling().compare(b.ceiling())
 	}), true
 }

ceilinger_test.go

@@ -10,13 +10,13 @@ import (
 func Test_minBoundedCeiling(t *testing.T) {
 	t.Parallel()
 
-	type testCase[T ceilinger] struct {
+	type testCase struct {
 		name   string
-		cs     []T
-		want   ceilinger
+		cs     []Endless
+		want   Endless
 		wantOk bool
 	}
-	tests := []testCase[Endless]{
+	tests := []testCase{
 		{
 			name:   "empty",
 			cs:     []Endless{},
@@ -163,7 +163,7 @@ func Test_minBoundedCeiling(t *testing.T) {
 
 			original := slices.Clone(tt.cs)
 
-			got, gotOk := minBoundedCeiling(tt.cs)
+			got, gotOk := minBoundedCeiling(tt.cs...)
 
 			if gotOk != tt.wantOk {
 				t.Fatalf("minBoundedCeiling() gotOk = %v, want %v", gotOk, tt.wantOk)

endless.go

@@ -40,7 +40,9 @@ func NewGreaterThanOrEqualTo(v Version) Endless {
 }
 
 func NewWildcard() Endless {
-	return Endless{}
+	return Endless{ //nolint:exhaustruct
+		version: nil,
+	}
 }
 
 // Check reports whether a [Version] satisfies the constraint.

floorer.go

@@ -6,19 +6,19 @@ type floorer interface {
 	floor() Endless
 }
 
-func maxBoundedFloor[S ~[]T, T floorer](fs S) (T, bool) {
-	fs = slices.Clone(fs)
+func maxBoundedFloor(es ...Endless) (Endless, bool) {
+	es = slices.Clone(es)
 
-	bfs := slices.DeleteFunc(fs, func(c T) bool {
+	bfs := slices.DeleteFunc(es, func(c Endless) bool {
 		return c.floor().wildcard()
 	})
 
 	if len(bfs) == 0 {
-		var f T
+		var f Endless
 		return f, false
 	}
 
-	return slices.MaxFunc(bfs, func(a, b T) int {
+	return slices.MaxFunc(bfs, func(a, b Endless) int {
 		return a.floor().compare(b.floor())
 	}), true
 }

floorer_test.go

@@ -10,13 +10,13 @@ import (
 func Test_maxBoundedFloor(t *testing.T) {
 	t.Parallel()
 
-	type testCase[T floorer] struct {
+	type testCase struct {
 		name   string
-		fs     []T
-		want   floorer
+		fs     []Endless
+		want   Endless
 		wantOk bool
 	}
-	tests := []testCase[Endless]{
+	tests := []testCase{
 		{
 			name:   "empty",
 			fs:     []Endless{},
@@ -163,7 +163,7 @@ func Test_maxBoundedFloor(t *testing.T) {
 
 			original := slices.Clone(tt.fs)
 
-			got, gotOk := maxBoundedFloor(tt.fs)
+			got, gotOk := maxBoundedFloor(tt.fs...)
 
 			if gotOk != tt.wantOk {
 				t.Fatalf("maxBoundedFloor() gotOk = %v, want %v", gotOk, tt.wantOk)

or.go

@@ -77,7 +77,7 @@ func Compact(o Or) Constrainter { // TODO: Test me.
 		return compare(a, b) == 0
 	})
 
-	r := make(Or, 0, len(o)+2)
+	r := make(Or, 0, len(o)+2) //nolint:mnd
 	if len(o) != 0 {
 		p := o[0]
 		for i := range o {

or_test.go

@@ -1,11 +1,12 @@
 package comver
 
 import (
-	"github.com/google/go-cmp/cmp"
 	"math/rand/v2"
 	"reflect"
 	"slices"
 	"testing"
+
+	"github.com/google/go-cmp/cmp"
 )
 
 func TestCompact(t *testing.T) {