Add PHPStan (#47)

Author: tangrufus

.github/workflows/lint.yml

@@ -0,0 +1,30 @@
+name: Lint
+
+on:
+  workflow_dispatch:
+  pull_request:
+    branches:
+      - main
+  push:
+    branches:
+      - main
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref_name }}-${{ github.event.pull_request.number || github.sha }}
+  cancel-in-progress: true
+
+permissions: {}
+
+jobs:
+  phpstan:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v5
+
+      - uses: shivammathur/setup-php@v2
+        with:
+          php-version: '8.4'
+          coverage: none
+      - uses: ramsey/composer-install@v3
+
+      - run: vendor/bin/phpstan analyse --error-format=github

composer.json

@@ -34,7 +34,12 @@
   },
   "require-dev": {
     "mockery/mockery": "^1.6.12",
-    "pestphp/pest": "^4.1.2"
+    "pestphp/pest": "^4.1.2",
+    "phpstan/extension-installer": "^1.4",
+    "phpstan/phpstan": "^2.1",
+    "phpstan/phpstan-deprecation-rules": "^2.0",
+    "phpstan/phpstan-strict-rules": "^2.0",
+    "phpstan/phpstan-symfony": "^2.0"
   },
   "autoload": {
     "psr-4": {
@@ -51,7 +56,8 @@
   ],
   "config": {
     "allow-plugins": {
-      "pestphp/pest-plugin": true
+      "pestphp/pest-plugin": true,
+      "phpstan/extension-installer": true
     },
     "sort-packages": true
   },
@@ -67,10 +73,9 @@
     "pest:e2e": "XDEBUG_MODE=off pest --group=e2e",
     "pest:feature": "pest --group=feature",
     "pest:unit": "pest --group=unit",
-    "test": [
-      "@composer normalize --dry-run",
+    "lint": [
       "pint --test",
-      "XDEBUG_MODE=off pest"
+      "phpstan analyse"
     ]
   }
 }

composer.lock

@@ -0,0 +1,5 @@
+parameters:
+	level: max
+	paths:
+		- bin
+		- src

phpstan.neon

@@ -50,7 +50,7 @@ public function __invoke(
             return Command::FAILURE;
         }
 
-        if (empty($versions)) {
+        if ($versions === []) {
             $this->printError(
                 $io,
                 sprintf('No PHP versions could satisfy the constraint "%s".', $constraint)

src/Console/ConstraintCommand.php

@@ -15,7 +15,7 @@ public function __construct()
             Mode::description(),
             Mode::NAME,
             null,
-            Mode::cases(),
+            array_column(Mode::cases(), 'value'),
         );
     }
 }

src/Console/ModeOption.php

@@ -15,7 +15,7 @@ public function __construct()
             Source::description(),
             Source::NAME,
             null,
-            Source::cases(),
+            array_column(Source::cases(), 'value'),
         );
     }
 }

src/Console/SourceOption.php

@@ -20,7 +20,6 @@ public function satisfiedBy(string $constraint): array
             $versions[] = "{$major}.{$minor}";
         }
 
-        $versions = array_filter($versions);
         $versions = array_filter($versions, static fn (string $version) => ! str_starts_with($version, '.'));
         $versions = array_filter($versions, static fn (string $version) => ! str_ends_with($version, '.'));
         $versions = array_unique($versions);