Test Matrix does not invoke ReleasesInterface::all() when invalid constraint (#63)

Author: tangrufus

src/Matrices/Matrix.php

@@ -14,7 +14,7 @@
 {
     public function __construct(
         private ReleasesInterface $releases,
-        private VersionParser $versionParser = new VersionParser(),
+        private VersionParser $versionParser = new VersionParser,
     ) {}
 
     /**
@@ -36,6 +36,5 @@ public function satisfiedBy(string $constraint): array
                 previous: $e
             );
         }
-
     }
 }

tests/Unit/Matrices/MatrixTest.php

@@ -5,6 +5,7 @@
 namespace Tests\Unit\Matrices;
 
 use Mockery;
+use Throwable;
 use TypistTech\PhpMatrix\Exceptions\UnexpectedValueException;
 use TypistTech\PhpMatrix\Matrices\Matrix;
 use TypistTech\PhpMatrix\Matrices\MatrixInterface;
@@ -81,5 +82,22 @@
 
             $matrix->satisfiedBy('invalid constraint');
         })->throws(UnexpectedValueException::class);
+
+        it('does not invoke ReleasesInterface::all() when invalid constraint', function () {
+            $releases = Mockery::mock(ReleasesInterface::class);
+
+            $releases->expects()
+                ->all()
+                ->withAnyArgs()
+                ->never();
+
+            $matrix = new Matrix($releases);
+
+            try {
+                $matrix->satisfiedBy('invalid constraint');
+            } catch (Throwable $e) {
+                // No-op.
+            }
+        });
     });
 });