wip

Author: tangrufus

src/WpOrg/Api/Cache.php

@@ -27,15 +27,18 @@ public function read(string $slug): ?bool
 
         $content = $this->cache->read($key);
 
-        // Unexpected.
+        // Should never happen because of the age check.
         if ($content === false) {
             return null;
         }
 
         $lines = explode("\n", $content);
 
-        // TODO: Ensure expected!
-        return $lines[0] === 'closed';
+        return match ($lines[0]) {
+            'closed' => true,
+            'open' => false,
+            default => null, // Unexpected content. Treat as a cache miss.
+        };
     }
 
     public function write(string $slug, bool $isClosed): void

tests/Unit/WpOrg/Api/CacheTest.php

@@ -57,7 +57,26 @@ function (string $slug, bool $expected, string $firstLine): void {
             'expired' => 999_999,
         ]);
 
-        test('when unexpected content', function (): void {});
+        test('when unexpected content', function (false|string $content): void {
+            $composerCache = Mockery::mock(ComposerCache::class);
+            $composerCache->expects()
+                ->getAge()
+                ->with("foo.txt")
+                ->andReturn(123);
+            $composerCache->expects()
+                ->read()
+                ->with("foo.txt")
+                ->andReturn($content);
+
+            $cache = new Cache($composerCache);
+
+            $actual = $cache->read('foo');
+
+            expect($actual)->toBeNull();
+        })->with([
+            'missed' => false,
+            'unexpected' => 'not-closed-nor-open',
+        ]);
     });
 
     describe('::write()', static function (): void {