Skip to content

Conversation

@3w36zj6
Copy link
Member

@3w36zj6 3w36zj6 commented Jun 10, 2025

cf. #158 #170

@3w36zj6 3w36zj6 requested a review from Copilot June 10, 2025 10:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces an "original" translation status to denote content that is not translated from the official documentation. The key changes include:

  • Updating the JSON schemas and status files to support the new "original" status.
  • Adjusting translation progress calculations to exclude "original" pages.
  • Updating UI components and tests to reflect the new translation status.

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
website/translation-status.schema.json Added "original" to the enum for translation statuses.
website/translation-status.json Changed Japanese docs statuses from "translated" to "original".
website/src/utils/translationStatus.ts Extended TranslationStatus type and updated progress calculation logic.
website/src/utils/translationStatus.test.ts Added tests to verify that pages marked as "original" are excluded.
website/src/components/ui/common/TranslationStatusAlert.tsx Added UI configuration for the "original" translation state.
docs/japanese/*.md Removed info boxes indicating unofficial content since it is now marked as "original".

Copy link
Member

@kimushun1101 kimushun1101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ご対応いただきありがとうございます。全体へのコメント追記は省略しますが、以下の2点が気になりました。

@3w36zj6 3w36zj6 requested a review from kimushun1101 June 11, 2025 00:12
Copy link
Member

@kimushun1101 kimushun1101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ご回答、ご検討いただき、ありがとうございました。
LGTMです。

@3w36zj6 3w36zj6 requested a review from ultimatile June 11, 2025 07:06
@3w36zj6 3w36zj6 merged commit 43608fb into main Jun 11, 2025
5 checks passed
@3w36zj6 3w36zj6 deleted the feature/add-original-content-status branch June 11, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants