-
Notifications
You must be signed in to change notification settings - Fork 13
feat: 翻訳状態にオリジナルコンテンツを追加 #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces an "original" translation status to denote content that is not translated from the official documentation. The key changes include:
- Updating the JSON schemas and status files to support the new "original" status.
- Adjusting translation progress calculations to exclude "original" pages.
- Updating UI components and tests to reflect the new translation status.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| website/translation-status.schema.json | Added "original" to the enum for translation statuses. |
| website/translation-status.json | Changed Japanese docs statuses from "translated" to "original". |
| website/src/utils/translationStatus.ts | Extended TranslationStatus type and updated progress calculation logic. |
| website/src/utils/translationStatus.test.ts | Added tests to verify that pages marked as "original" are excluded. |
| website/src/components/ui/common/TranslationStatusAlert.tsx | Added UI configuration for the "original" translation state. |
| docs/japanese/*.md | Removed info boxes indicating unofficial content since it is now marked as "original". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ご対応いただきありがとうございます。全体へのコメント追記は省略しますが、以下の2点が気になりました。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ご回答、ご検討いただき、ありがとうございました。
LGTMです。
cf. #158 #170