Skip to content

Conversation

@3w36zj6
Copy link
Member

@3w36zj6 3w36zj6 commented Jun 11, 2025

close #24
close #170

変更点

  • Webサイトのヘッダーに翻訳率の表示を追加
  • READMEのバッジを削除

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a live translation progress badge to the site header and removes the static badge from the README.

  • Introduce TranslationCoverageBadge using calculateTranslationProgressRate()
  • Update desktop and mobile header layouts to include the new badge
  • Remove the old translation progress badge from README.md

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
website/src/components/ui/common/Header.tsx Added TranslationCoverageBadge component and integrated it into both header versions
README.md Deleted the outdated translation-progress badge
Comments suppressed due to low confidence (2)

website/src/components/ui/common/Header.tsx:24

  • Add unit tests for TranslationCoverageBadge and the calculateTranslationProgressRate logic to verify correct rendering across different percentage values.
const TranslationCoverageBadge = () => {

website/src/components/ui/common/Header.tsx:24

  • [nitpick] The term “coverage” in the component name and “率” (“rate”) in the UI label differ slightly; consider renaming to TranslationRateBadge to align terminology.
const TranslationCoverageBadge = () => {

@ultimatile
Copy link
Contributor

ご対応ありがとうございます。
1点確認なのですが、現在表示されているREADMEのバッジとヘッダーの表示がそれぞれ28%と19%と異なっていますが、問題ないでしょうか?

@3w36zj6
Copy link
Member Author

3w36zj6 commented Jun 12, 2025

@ultimatile

計算方法の違い(子ページをもつ親ページを数えるかどうか)によるものだと思います。
READMEにあったバッジの数値は手動で更新していましたが、しばらく更新されておらず実態と乖離していたため、メンテナンスの都合で削除しました。

@ultimatile
Copy link
Contributor

@3w36zj6 ありがとうございます。それなら問題なさそうですね。

Copy link
Member

@kimushun1101 kimushun1101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ご対応いただきありがとうございます。
動作確認できました。

Copy link
Contributor

@gomazarashi gomazarashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます。こちらでも動作を確認できました。

@3w36zj6 3w36zj6 merged commit d19438c into main Jun 13, 2025
5 checks passed
@3w36zj6 3w36zj6 deleted the feature/add-translation-coverage-to-website branch June 13, 2025 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

全ページの翻訳率を表示する 翻訳進捗を可視化

5 participants