-
Notifications
You must be signed in to change notification settings - Fork 13
feat: Webサイトに翻訳率を表示するバッジを追加 #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds a live translation progress badge to the site header and removes the static badge from the README.
- Introduce
TranslationCoverageBadgeusingcalculateTranslationProgressRate() - Update desktop and mobile header layouts to include the new badge
- Remove the old translation progress badge from README.md
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| website/src/components/ui/common/Header.tsx | Added TranslationCoverageBadge component and integrated it into both header versions |
| README.md | Deleted the outdated translation-progress badge |
Comments suppressed due to low confidence (2)
website/src/components/ui/common/Header.tsx:24
- Add unit tests for
TranslationCoverageBadgeand thecalculateTranslationProgressRatelogic to verify correct rendering across different percentage values.
const TranslationCoverageBadge = () => {
website/src/components/ui/common/Header.tsx:24
- [nitpick] The term “coverage” in the component name and “率” (“rate”) in the UI label differ slightly; consider renaming to
TranslationRateBadgeto align terminology.
const TranslationCoverageBadge = () => {
|
ご対応ありがとうございます。 |
|
計算方法の違い(子ページをもつ親ページを数えるかどうか)によるものだと思います。 |
|
@3w36zj6 ありがとうございます。それなら問題なさそうですね。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ご対応いただきありがとうございます。
動作確認できました。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ありがとうございます。こちらでも動作を確認できました。
close #24
close #170
変更点